Feature/38774 expensify persona #41343

koko57 · 2024-04-30T15:34:44Z

Details

Fixed Issues

$ #38774
PROPOSAL:

Tests

Open the app with an entire new user.
Complete the onboarding flow.
Repeat steps 1-2 a few times (create a few new users).
Verify that after onboarding flow you're redirected either to the Concierge chat or Expensify persona

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app with an entire new user.
Complete the onboarding flow.
Repeat steps 1-2 a few times (create a few new users).
Verify that after onboarding flow you're redirected either to the Concierge chat or Expensify persona

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Screen.Recording.2024-04-30.at.17.32.02.mp4

Screen.Recording.2024-04-30.at.17.33.19.mp4

melvin-bot · 2024-05-01T13:17:21Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2024-05-01T13:24:02Z

AuthPR deployed to prod, let's get this one reviewed.

github-actions · 2024-05-01T14:23:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41343/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41343/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41343/NewExpensify.dmg	https://41343.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

sobitneupane

@koko57

The chat with Expensify persona is created as a group chat with two members(user and Expensify persona). Is it expected?

The Expensify persona in message header changes to Expensify Concierge after few seconds.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-05-01.at.20.27.19.mov

Screen.Recording.2024-05-01.at.20.29.18.mov

sobitneupane · 2024-05-01T15:08:54Z

src/libs/ReportUtils.ts

@@ -4974,7 +4974,6 @@ function shouldReportBeInOptionList({
 // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
 report?.isHidden ||
 // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


Suggested change

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing

sobitneupane · 2024-05-01T15:11:46Z

src/libs/actions/Report.ts

 const actorAccountID = PersonalDetailsUtils.getAccountIDsByLogins([targetEmail])[0];
- const targetChatReport = ReportUtils.getChatByParticipants([actorAccountID]);
+ // TODO: using getSystemChat is rather not necessary if we could have participants list filled correctly
+ const targetChatReport = isAccountIDOdd ? ReportUtils.getSystemChat() : ReportUtils.getChatByParticipants([actorAccountID]);


Is this TODO within the scope of this PR?

sobitneupane · 2024-05-01T15:13:15Z

src/libs/SidebarUtils.ts

+ if (report.chatType === CONST.REPORT.CHAT_TYPE.SYSTEM) {
+ participantAccountIDs = [report.ownerAccountID ?? 0, ...PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.NOTIFICATIONS])];
+ }
+


Are we good to remove this block of code?

koko57 · 2024-05-02T09:44:40Z

@sobitneupane the comments in the code addressed, checking these ones now

mountiny · 2024-06-10T08:25:06Z

@sobitneupane I dont think its expected that its not showing up, are you able to debug, it should be in LHN.

the backend does return it correctly then?

koko57 · 2024-06-10T08:50:24Z

src/libs/ReportUtils.ts

@@ -5274,8 +5274,6 @@ function shouldReportBeInOptionList({
 report?.reportName === undefined ||
 // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
 report?.isHidden ||
- // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
- participantAccountIDs.includes(CONST.ACCOUNT_ID.NOTIFICATIONS) ||


@mountiny Replying - I've just fixed it. But I need to confirm - is there any other situation that we want to hide this kind of chat (including persona as a participant) from LHN? If there is any I need to think of changing this confition

I think it was added here #32361 but now we can show it at least in the LHN. You should still not bae able to start a new chat with the notification@expensify.com account

Even when a user accountID is even, we show Expensify persona.

Screen.Recording.2024-06-10.at.15.01.09.mov

Do we want to show chat with Expensify persona only for the first time? Or do we want to always show it (even after user re-login the account)?

@mountiny yeah, but even before my latest changes we had this account displayed when starting a new chat

Do we want to show chat with Expensify persona for the first time only? Do we want to always show it (even after user logs in to already active account)?

and I also wonder what is expected behavior here? Should we show the Expensify persona chat for all the users?

I think the logic is that in the onboarding flow, some will get the tasks from Concierge and some from the Expensify persona.

It should only show the Expensify persona for those who have the onboarding flow added to the persona chat. Not for the others. I now realize this might be tricky cc @francoisl

yeah, but even before my latest changes we had this account displayed when starting a new chat

I think that is a bug and it should not show up in any of those lists

notifications@expensify.com is visible even if I revert the latest changes, so I need to add a new filter.
For displaying the Expensify persona only for the users onboarded by persona - I still need to figure this out.

@mountiny should this persona chat be always visible, or it should disappear at some point?

is there any other situation that we want to hide this kind of chat

Users should not be able to create group chats with the system account, or invite it to existing rooms, workspaces, etc. For example, the "Add to group" button shouldn't appear here for the Expensify row (maybe we can look into that in a follow-up PR if that requires a lot of changes)

It should only show the Expensify persona for those who have the onboarding flow added to the persona chat. Not for the others. I now realize this might be tricky cc @francoisl

Yeah I don't think it's something we had considered originally. To be clear though, do you mean that EITHER Concierge or the system chat would remain sticky in the LHN when you're in "Most Recent" mode? Concierge is pinned by default (I unpinned it here to show that it remains in the LHN), but yes I think I agree that if the onboarding tasks are created in the Concierge chat, then it just adds extra noise in the LHN to also show the system DM, so it would make sense to hide it.

Yeah I don't think it's something we had considered originally. To be clear though, do you mean that EITHER Concierge or the system chat would remain sticky in the LHN when you're in "Most Recent" mode? Concierge is pinned by default (I unpinned it here to show that it remains in the LHN), but yes I think I agree that if the onboarding tasks are created in the Concierge chat, then it just adds extra noise in the LHN to also show the system DM, so it would make sense to hide it.

I agree. I dont think the system chat should be pinned really though so it would only show in the Most Recent as in focus mode it would not be unread

@mountiny @francoisl ok, so I added a logic to display Persona only for users onboarded this way. I agree with @francoisl - filtering notifications@expensify.com should be done in a follow-up, as it's something that is occurring on staging

koko57 · 2024-06-11T12:31:25Z

@mountiny lint & typecheck fixed

mountiny

Changes look good to me, asking if we can get the checklist soon

mountiny · 2024-06-11T14:48:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

@sobitneupane added above

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

sobitneupane · 2024-06-11T16:12:42Z

Thanks @mountiny for completing the checklist.

MacOS: Chrome / Safari

Screen.Recording.2024-06-11.at.21.50.47.mov

Screen.Recording.2024-06-11.at.21.52.04.mov

francoisl

Thanks! Looks good and works well.

francoisl · 2024-06-11T16:46:58Z

src/libs/AccountUtils.ts

@@ -5,4 +5,6 @@ import type {Account} from '@src/types/onyx';
 const isValidateCodeFormSubmitting = (account: OnyxEntry<Account>) =>
 !!account?.isLoading && account.loadingForm === (account.requiresTwoFactorAuth ? CONST.FORMS.VALIDATE_TFA_CODE_FORM : CONST.FORMS.VALIDATE_CODE_FORM);

-export default {isValidateCodeFormSubmitting};
+const isAccountIDOddNumber = (accountID: number) => accountID % 2 === 1;


NAB - this could be made a bit more generic as NumberUtils.isOdd(value: number)

OSBotify · 2024-06-11T16:56:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T22:27:44Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-13T15:30:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh · 2024-06-18T10:10:46Z

Hi team, coming from this issue #43564. Because I don't have access to the design doc of this PR. Can anyone confirm if step 4 in the Test steps is our new expected behavior for all platforms?

Verify that after onboarding flow you're redirected either to the Concierge chat or Expensify persona

Previously, when we only displayed onboarding information in the Concierge page, then in small screen devices(native, mWeb), we wouldn't redirect users to the Concierge page (user remains in LHN). (link to Stage 1 of Guided Setup design doc)

Now with A/B testing Expensify DM, I think step 4 above makes sense.

eVoloshchak · 2024-06-18T11:05:38Z

src/libs/SidebarUtils.ts

@@ -104,6 +105,12 @@ function getOrderedReportIDs(
 return false;
 }

+ const participantAccountIDs = Object.keys(report?.participants ?? {}).map(Number);
+
+ if (currentUserAccountID && AccountUtils.isAccountIDOddNumber(currentUserAccountID) && participantAccountIDs.includes(CONST.ACCOUNT_ID.NOTIFICATIONS)) {


Hey team, coming from #43782
This early return returns true (displays in LHN) for all chats that have CONST.ACCOUNT_ID.NOTIFICATIONS as a participant.
Domain chat room does have CONST.ACCOUNT_ID.NOTIFICATIONS as a participant, but doesn't need to be displayed in focus mode, since there are no unread messages

@eVoloshchak Should I fix it or you're going with someone's proposal?

@koko57, I'm not entirely sure
On the one hand, this PR was deployed to prod 5 days ago, it's still in 7-day regression period, so it makes sense to fix it here
On the other hand, we've opened up the issue to contributors and have already received valid proposals

@twisterdotcom, could you weigh in on this please?

@koko57 yes please, lets fix it, its still in the regression period

Similar issue was detected where expensify chat showed up in focus mode even though there were no unread messages #43599. This was fixed in #44061

hoangzinh · 2024-06-19T23:36:15Z

@mountiny can you help me to check a question here #41343 (comment)? 🏆

tgolen · 2024-06-24T13:46:42Z

src/libs/AccountUtils.ts

@@ -5,4 +5,6 @@ import type {Account} from '@src/types/onyx';
 const isValidateCodeFormSubmitting = (account: OnyxEntry<Account>) =>
 !!account?.isLoading && account.loadingForm === (account.requiresTwoFactorAuth ? CONST.FORMS.VALIDATE_TFA_CODE_FORM : CONST.FORMS.VALIDATE_CODE_FORM);

-export default {isValidateCodeFormSubmitting};
+const isAccountIDOddNumber = (accountID: number) => accountID % 2 === 1;


Can we please move this to the permissions file so that it is treated just like any of the other betas?

Fair, I think we were not looking at this as a beta, but I can see where you are coming from. @koko57 do you think you could move this around to permissions file?

burczu and others added 10 commits April 26, 2024 10:57

new persona added

e343aa6

using expensify persona only for odd account ids

9a58f4f

handling new system report type

6da74e4

navigating to system chat at the end of the onboarding process added

aaa3cd4

addional todo comment added

282490a

fix: resolve conflicts

f50eaaa

fix: minor fix

0410d8f

fix: remove comment

179575f

fix: remove unnecessary condition

9cba84a

fix: remove console log

ba3aa46

koko57 mentioned this pull request Apr 30, 2024

[HOLD for payment 2024-06-20] [Guided Setup Stage 2] Create Guided Setup messages and tasks from Expensify persona for every other user (Phase 2) #38774

Closed

trjExpensify changed the title ~~Feature/38774 expensify persona~~ [Hold Auth#10675] Feature/38774 expensify persona May 1, 2024

koko57 marked this pull request as ready for review May 1, 2024 13:17

koko57 requested a review from a team as a code owner May 1, 2024 13:17

melvin-bot bot removed the request for review from a team May 1, 2024 13:17

melvin-bot bot requested a review from sobitneupane May 1, 2024 13:17

trjExpensify changed the title ~~[Hold Auth#10675] Feature/38774 expensify persona~~ Feature/38774 expensify persona May 1, 2024

trjExpensify assigned koko57 May 1, 2024

trjExpensify added the Ready To Build label May 1, 2024

sobitneupane reviewed May 1, 2024

View reviewed changes

koko57 added 2 commits May 2, 2024 11:36

fix: remove unnecessary change

5c2e6d2

fix: apply requested changes

36842b8

fix: lint

a6b6593

fix: show only Expensify name for persona chat

99b7398

koko57 commented Jun 10, 2024

View reviewed changes

koko57 added 2 commits June 11, 2024 09:04

Merge branch 'main' into feature/38774-expensify-persona

0205df8

fix: show persona chat only for onboarded by persona users

08a87cd

koko57 requested review from mountiny and francoisl June 11, 2024 07:46

koko57 added 2 commits June 11, 2024 14:13

Merge branch 'main' into feature/38774-expensify-persona

2015e43

fix: lint and typecheck

5dc7f6c

mountiny approved these changes Jun 11, 2024

View reviewed changes

sobitneupane approved these changes Jun 11, 2024

View reviewed changes

francoisl approved these changes Jun 11, 2024

View reviewed changes

francoisl merged commit 56eb982 into Expensify:main Jun 11, 2024
18 checks passed

github-actions bot mentioned this pull request Jun 11, 2024

Deploy Checklist: New Expensify 2024-06-11 #43515

Closed

59 tasks

lanitochka17 mentioned this pull request Jun 12, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Expensify personal - Users are able to create threads in the "System" DM chat #43562

Closed

6 tasks

izarutskaya mentioned this pull request Jun 12, 2024

[$250] Chats - User remains on LHN page after onboarding flow completed #43564

Closed

6 tasks

eVoloshchak reviewed Jun 18, 2024

View reviewed changes

eVoloshchak mentioned this pull request Jun 18, 2024

[Awaiting checklist] [$125] [CRITICAL] [UX Reliability] Domain chat room is showing in focus mode in LHN despite not having any new messages #43782

Closed

koko57 mentioned this pull request Jun 24, 2024

fix: do not show domain chats in focus mode #43993

Merged

61 tasks

tgolen reviewed Jun 24, 2024

View reviewed changes

DylanDylann mentioned this pull request Jul 9, 2024

[HOLD for payment 2024-08-02] [$250] Concierge chat is read as it's selected during the onboarding flow #44728

Closed

6 tasks

alitoshmatov mentioned this pull request Jul 9, 2024

[HOLD for payment 2024-07-10] [$250] LHN-Unpinned and read "Expensify" chat persists in LHN in "#focus" priority mode #43599

Closed

6 tasks

Feature/38774 expensify persona #41343

Feature/38774 expensify persona #41343

Conversation

koko57 commented Apr 30, 2024 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 1, 2024

trjExpensify commented May 1, 2024

github-actions bot commented May 1, 2024

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koko57 commented May 2, 2024

mountiny commented Jun 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sobitneupane Jun 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koko57 commented Jun 11, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Jun 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

sobitneupane commented Jun 11, 2024

francoisl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 13, 2024

hoangzinh commented Jun 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Jun 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koko57 commented Apr 30, 2024 •

edited by github-actions bot

Loading

sobitneupane left a comment •

edited

Loading

sobitneupane Jun 10, 2024 •

edited

Loading

mountiny commented Jun 11, 2024 •

edited

Loading