Add a route for easy redirects to the start request flow #33303

tgolen · 2023-12-19T16:34:17Z

Details

This allows for easy URLs that can link straight to the request flows. These are used in promotional messages.

This is intended to only work with web and for people that are using mobile, we expect it to open on mobile web.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/352160

Tests

Go to https://dev.new.expensify.com:8082/start/request/manual
Verify you see the manual request start page
Go to https://dev.new.expensify.com:8082/start/request/scan
Verify you see the scan request start page
Go to https://dev.new.expensify.com:8082/start/request/distance
Verify you see the distance request start page

Verify that no errors appear in the JS console

Offline tests

None, this doesn't really work offline.

QA Steps

NOTE: You only need to test web and mobile web. This isn't intended to work on other platforms.

Go to https://staging.new.expensify.com/start/request/manual
Verify you see the manual request start page
Go to https://staging.new.expensify.com/start/request/scan
Verify you see the scan request start page
Go to https://staging.new.expensify.com/start/request/distance
Verify you see the distance request start page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-19T16:34:51Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2023-12-20T11:24:35Z

Should we add a C+ for review?

situchan · 2023-12-20T11:26:33Z

I'd be interested if requires C+ review

tgolen · 2023-12-20T18:08:29Z

Sure, go for it.

dylanexpensify · 2023-12-21T14:48:40Z

@situchan do we think you'll have review done today?

situchan · 2023-12-21T14:49:32Z

yes I'll

situchan · 2023-12-26T17:06:11Z

@tgolen please merge main

tgolen · 2023-12-26T17:28:21Z

I can, but is it necessary to?

situchan · 2023-12-26T17:29:28Z

I can, but is it necessary to?

just for safety. as 800 commits behind

tgolen · 2023-12-26T17:31:55Z

I think it's OK. There is nothing wrong with being 800 commits behind if there are no conflicts or changes to the areas being touched.

situchan · 2023-12-26T17:35:11Z

I think it's OK. There is nothing wrong with being 800 commits behind if there are no conflicts or changes to the areas being touched.

nvm, I am pulling main locally since there was expo image PR merged in between, which requires full android re-build

situchan · 2023-12-26T21:12:49Z

Please remove :8082 in QA steps

situchan · 2023-12-26T21:16:56Z

RHP page is opened 2 times

Screen.Recording.2023-12-27.at.3.15.42.AM.mov

And console error:

tgolen · 2023-12-26T21:33:00Z

Thanks for reporting the issue with the RHP opening twice. It doesn't appear like you are following the test steps, where the intention is just to modify the URL to go to those links. I guess I can add a dismissModal() aftering doing the redirect, but do you think it's necessary?

situchan · 2023-12-26T21:35:16Z

Thanks for reporting the issue with the RHP opening twice. It doesn't appear like you are following the test steps, where the intention is just to modify the URL to go to those links. I guess I can add a dismissModal() aftering doing the redirect, but do you think it's necessary?

I think that should be fixed. We can try either dismissModal or navigation replace

tgolen · 2023-12-26T21:58:29Z

OK, fixed and updated.

situchan · 2023-12-26T22:02:22Z

Can you also please check console error? I think the logic should be moved to component mount (useEffect with empty array dependency). It's not recommended to directly call function in render.

tgolen · 2023-12-26T22:44:07Z

Oh, sorry I forgot about that. I changed the component so that it doesn't redirect until the component has been mounted and this solves the console error. In order to prevent the "not found" page from briefly showing, I am just having the component return null so that nothing is displayed.

situchan · 2023-12-27T10:43:12Z

Console error when redirect https://dev.new.expensify.com:8082/start/request/other
Also empty screen shows.
I think the expected behavior is to show not found page

Actual:

Expected:

tgolen · 2023-12-27T15:49:19Z

OK, I added some type checking in order to show the "not found" page when there is an invalid URL param. I tested with these URLs:

I think the console prop type error is fine in these cases. The only way to make the error go away would be to relax the propType definition to accept any string, and I'd rather keep it strict.

situchan · 2023-12-27T16:14:42Z

src/pages/iou/request/IOURequestRedirectToStartPage.js

@@ -0,0 +1,64 @@
+import PropTypes from 'prop-types';
+import React, {useEffect} from 'react';
+import _ from 'underscore';


We prefer lodash to underscore.
Btw not blocker since both will be deprecated during TS migration

situchan · 2023-12-27T16:18:11Z

src/pages/iou/request/IOURequestRedirectToStartPage.js

+    const isIouTypeValid = _.values(CONST.IOU.TYPE).indexOf(iouType) > -1;
+    const isIouRequestTypeValid = _.values(CONST.IOU.REQUEST_TYPE).indexOf(iouRequestType) > -1;


Suggested change

const isIouTypeValid = _.values(CONST.IOU.TYPE).indexOf(iouType) > -1;

const isIouRequestTypeValid = _.values(CONST.IOU.REQUEST_TYPE).indexOf(iouRequestType) > -1;

const isIouTypeValid = _.values(CONST.IOU.TYPE).includes(iouType);

const isIouRequestTypeValid = _.values(CONST.IOU.REQUEST_TYPE).includes(iouRequestType);

situchan · 2023-12-27T16:23:40Z

src/pages/iou/request/IOURequestRedirectToStartPage.js

+    }, []);
+
+    if (!isIouTypeValid || !isIouRequestTypeValid) {
+        return <FullPageNotFoundView shouldShow />;


This should be wrapped with ScreenWrapper for iOS safe area to be considered.

tgolen · 2023-12-27T17:00:08Z

OK, I've added the screenwrapper. I was not sure which options were necessary, but I think that since the only child is the "not found" page, then none of the settings for padding or max height are needed?

situchan · 2023-12-27T18:30:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web-deep.mov

web-redirect.mov

MacOS: Desktop

situchan · 2023-12-27T18:32:57Z

OK, I've added the screenwrapper. I was not sure which options were necessary, but I think that since the only child is the "not found" page, then none of the settings for padding or max height are needed?

I think not needed. Also tested. If something is required even for this simple page, maybe better to update that prop as always required in propType.

situchan

melvin-bot · 2023-12-27T18:34:04Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-12-27T18:34:08Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #33655.

tgolen · 2023-12-27T20:03:46Z

If something is required even for this simple page, maybe better to update that prop as always required in propType.

Yes, this is a good call. I was reading the comments for each of the prop types, and a lot of them left me in a very confused state. Such as:

/** Whether to include padding bottom */

Why should it have padding bottom or not??

/** Whether KeyboardAvoidingView should be enabled. Use false for screens where this functionality is not necessary */

How do I know if the functionality is necessary or not if the functionality is not explained?

/** Whether to use the maxHeight (true) or use the 100% of the height (false) */

How would I know which one I should use?

/** Whether to use the minHeight. Use true for screens where the window height are changing because of Virtual Keyboard */

Finally! This one comes pretty close to giving a proper explanation.

Beamanator

LGTM!

OSBotify · 2023-12-28T17:25:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-28T21:37:07Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-29T18:14:00Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.19-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add a route for easy redirects to the start request flow

eade946

tgolen self-assigned this Dec 19, 2023

tgolen requested a review from a team as a code owner December 19, 2023 16:34

melvin-bot bot requested review from arosiclair and removed request for a team December 19, 2023 16:34

luacmartins previously approved these changes Dec 20, 2023

View reviewed changes

luacmartins requested a review from situchan December 21, 2023 10:23

arosiclair previously approved these changes Dec 26, 2023

View reviewed changes

tgolen added 2 commits December 26, 2023 14:55

Merge branch 'main' into tgolen-scan-landingpage

8a751af

Dismiss modal before redirecting

a203ca1

tgolen dismissed stale reviews from arosiclair and luacmartins via a203ca1 December 26, 2023 21:58

Do navigation once component has mounted

aa5b2ea

Check for valid iou types and show not found if invalid

c744ec1

situchan reviewed Dec 27, 2023

View reviewed changes

situchan mentioned this pull request Dec 27, 2023

Remove old receipt selector #32764

Merged

50 tasks

Add screenwrapper

9d960f3

situchan approved these changes Dec 27, 2023

View reviewed changes

melvin-bot bot requested a review from deetergp December 27, 2023 18:34

melvin-bot bot mentioned this pull request Dec 27, 2023

[PAY 5TH JAN] Payment issue for E/App PR#33303 #33655

Closed

Beamanator approved these changes Dec 28, 2023

View reviewed changes

Beamanator merged commit 34a7bbd into main Dec 28, 2023
16 checks passed

Beamanator deleted the tgolen-scan-landingpage branch December 28, 2023 17:21

github-actions bot mentioned this pull request Dec 28, 2023

Deploy Checklist: New Expensify 2023-12-28 #33727

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a route for easy redirects to the start request flow #33303

Add a route for easy redirects to the start request flow #33303

tgolen commented Dec 19, 2023 •

edited

Loading

melvin-bot bot commented Dec 19, 2023

luacmartins commented Dec 20, 2023

situchan commented Dec 20, 2023

tgolen commented Dec 20, 2023

dylanexpensify commented Dec 21, 2023

situchan commented Dec 21, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

situchan commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 27, 2023

tgolen commented Dec 27, 2023

situchan Dec 27, 2023

situchan Dec 27, 2023

situchan Dec 27, 2023 •

edited

Loading

tgolen commented Dec 27, 2023

situchan commented Dec 27, 2023

situchan commented Dec 27, 2023

situchan left a comment

melvin-bot bot commented Dec 27, 2023

melvin-bot bot commented Dec 27, 2023

tgolen commented Dec 27, 2023

Beamanator left a comment

OSBotify commented Dec 28, 2023

OSBotify commented Dec 28, 2023

OSBotify commented Dec 29, 2023

		const isIouTypeValid = _.values(CONST.IOU.TYPE).indexOf(iouType) > -1;
		const isIouRequestTypeValid = _.values(CONST.IOU.REQUEST_TYPE).indexOf(iouRequestType) > -1;

Add a route for easy redirects to the start request flow #33303

Add a route for easy redirects to the start request flow #33303

Conversation

tgolen commented Dec 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 19, 2023

luacmartins commented Dec 20, 2023

situchan commented Dec 20, 2023

tgolen commented Dec 20, 2023

dylanexpensify commented Dec 21, 2023

situchan commented Dec 21, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

situchan commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 26, 2023

tgolen commented Dec 26, 2023

situchan commented Dec 27, 2023

tgolen commented Dec 27, 2023

situchan Dec 27, 2023

Choose a reason for hiding this comment

situchan Dec 27, 2023

Choose a reason for hiding this comment

situchan Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

tgolen commented Dec 27, 2023

situchan commented Dec 27, 2023

Reviewer Checklist

Screenshots/Videos

situchan commented Dec 27, 2023

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 27, 2023

melvin-bot bot commented Dec 27, 2023

tgolen commented Dec 27, 2023

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 28, 2023

OSBotify commented Dec 28, 2023

OSBotify commented Dec 29, 2023

tgolen commented Dec 19, 2023 •

edited

Loading

situchan Dec 27, 2023 •

edited

Loading