Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default isLoading to false for reimbursementAccount param in WorkspacePageWithSections.tsx #35098

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Default isLoading to false for reimbursementAccount param in WorkspacePageWithSections.tsx #35098

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25b802e
Default shouldShowLoading to false in WorkspacePageWithSections
cristipaval Jan 24, 2024
1ba471f
revert bad initial change
cristipaval Jan 24, 2024
4144222
Fix deploy blocker
cristipaval Jan 24, 2024
fd6abea
Remove console debug
cristipaval Jan 24, 2024
0799200
make currentStep option in ACHData
cristipaval Jan 24, 2024
ba79d4e
Use ReimbursementAccountProps.reimbursementAccountDefaultProps
cristipaval Jan 24, 2024
20f70c6
Run prettier
cristipaval Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/workspace/WorkspacePageWithSections.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function WorkspacePageWithSections({
guidesCallTaskID = '',
headerText,
policy,
reimbursementAccount = {},
reimbursementAccount = {isLoading: false},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use ReimbursementAccountProps.reimbursementAccountDefaultProps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, tried that first, I just have to learn how to make that object written in js work in tsx

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

achData is missing currentStep required value in reimbursementAccountDefaultProps. I am not sure what is the default value for this.

Easiest solution will be to make it optional

Copy link
Contributor Author

@cristipaval cristipaval Jan 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just made currentStep optional in ACHData

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, thanks for teaching me some Typescript 🙌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed the change

route,
shouldUseScrollView = false,
shouldSkipVBBACall = false,
Expand Down
Loading