-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript #25175 #35890
Merged
Commits on Feb 5, 2024
-
TS Migration Expensify#25175: Update and rename AppDownloadLinks.js t…
…o AppDownloadLinks.tsx Updates related to Typescript Migration Expensify#25175. -Migrated component to Typescript -Extended MenuItemProps type as DownloadMenuItem type -Typed menu items as an array of DownloadMenuItems -Removed withWindowDimensions/withLocalize PropTypes and compose() from export per guidelines on migration -Used Hooks for localize instead for translation -Removed _ in JSX mapping of menu items. Saw other TSX files that removes and I was getting ESLint warnings. _ is noted as a best practice but given other TSX files have removed I followed suit. I also saw old ESlint ignores being used when removing _ but I didn't get flagged without this. -Removed onKeyDown attribute and blur() from MenuItem. I saw this nowhere else in the codebase and the removal had no impact on app use functionality (please advise if there's something I am missing but it appeared antiquated) -This component receives props from Navigation but I do not see elsewhere in the codebase that we are explicitly listing these as props via typescript (navigation props should inherintly apply to all pages) -TS warnings made me list translationKey as type TranslationPaths (warning only appears when not providing the translate from useLocalize() with a '' - others working on TS migrations may want to know this) -No ESlint warnings -No VSCode warnings or errors -No errors when testing -Only issue was on iOS simulator there's no App Store app so it doesn't know how to handle the download iOS click but the link is fine and it works everywhere else. -No other components or other files in codebase import this file so change from .js to .tsx should not require changes to imports anywhere. This component is routed to via its name as with other pages in codebase.
Configuration menu - View commit details
-
Copy full SHA for 73b15d0 - Browse repository at this point
Copy the full SHA 73b15d0View commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3297913 - Browse repository at this point
Copy the full SHA 3297913View commit details
Commits on Feb 12, 2024
-
Moved Type declaration out of component scope.
Configuration menu - View commit details
-
Copy full SHA for 8b90adf - Browse repository at this point
Copy the full SHA 8b90adfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 472f3d7 - Browse repository at this point
Copy the full SHA 472f3d7View commit details
Commits on Feb 14, 2024
-
Amended openAppDownloadLink and downloadLink in DownloadMenuItem back to action and link. Returned to original, simplified logic for Navigation.goBack()
Configuration menu - View commit details
-
Copy full SHA for a3fbb23 - Browse repository at this point
Copy the full SHA a3fbb23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ace68a - Browse repository at this point
Copy the full SHA 4ace68aView commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 235add7 - Browse repository at this point
Copy the full SHA 235add7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.