Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/address page state navigation 2 #36770

Merged
merged 75 commits into from
Apr 2, 2024
Merged

Fix/address page state navigation 2 #36770

merged 75 commits into from
Apr 2, 2024

Commits on Oct 7, 2023

  1. Convert StatePicker modal to StateSelection page

    @ygshbht
    ygshbht committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    cd8ca07 View commit details
    Browse the repository at this point in the history

  2. Incorporation state resets bugfix

    @ygshbht
    ygshbht committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1284e59 View commit details
    Browse the repository at this point in the history

  3. Modify pages to accomodate for StateSelection

    @ygshbht
    ygshbht committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    963cf67 View commit details
    Browse the repository at this point in the history

  4. Merge https://github.com/Expensify/App into fix/address-page-state-na… 

    …vigation
    @ygshbht
    ygshbht committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1305561 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Refactor to use useGeographicalStateFromRoute hook

    @ygshbht
    ygshbht committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    16ba084 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. move getStateFromRoute to useGeographicalStateFromRoute

    @ygshbht
    ygshbht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0f83cff View commit details
    Browse the repository at this point in the history

  2. Add displayname to StateSelectorWithRef

    @ygshbht
    ygshbht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0951d5d View commit details
    Browse the repository at this point in the history

  3. Merge https://github.com/Expensify/App into fix/address-page-state-na… 

    …vigation
    @ygshbht
    ygshbht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3b88d46 View commit details
    Browse the repository at this point in the history

  4. Fix AddressPage: State not changing on autocomplete

    @ygshbht
    ygshbht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    598c7c6 View commit details
    Browse the repository at this point in the history

  5. Refactor StateSelector logic

    @ygshbht
    ygshbht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    4a21636 View commit details
    Browse the repository at this point in the history

  6. Refactor AddressPage

    @ygshbht
    ygshbht committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    312d0c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. linting fixes StateSelector

    @ygshbht
    ygshbht committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    8a293b5 View commit details
    Browse the repository at this point in the history

  2. linting

    @ygshbht
    ygshbht committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    c946cbb View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. StateSelector and related files refactoring

    @ygshbht
    ygshbht committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    144eea9 View commit details
    Browse the repository at this point in the history

  2. Merge https://github.com/Expensify/App into fix/address-page-state-na… 

    …vigation
    @ygshbht
    ygshbht committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d2848d3 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect merge

    @ygshbht
    ygshbht committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    17f2aab View commit details
    Browse the repository at this point in the history

  4. Reverted scripts/shellCheck.sh to state at 33f15e8

    @ygshbht
    ygshbht committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    9fb4f72 View commit details
    Browse the repository at this point in the history

  5. Linting

    @ygshbht
    ygshbht committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d6a643c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge https://github.com/Expensify/App into fix/address-page-state-na… 

    …vigation
    @ygshbht
    ygshbht committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    080285a View commit details
    Browse the repository at this point in the history

  2. Comment formatting src/hooks/useGeographicalStateFromRoute.ts 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @ygshbht @parasharrajat
    ygshbht and parasharrajat committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9bb88ee View commit details
    Browse the repository at this point in the history

  3. Rename useStateFomrUrl to shouldUseStateFromUrl

    @ygshbht
    ygshbht committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5e38447 View commit details
    Browse the repository at this point in the history

  4. forwardedRef type correction StateSelector

    @ygshbht
    ygshbht committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    470ec03 View commit details
    Browse the repository at this point in the history

  5. StateSelector: rename paramName to queryParam

    @ygshbht
    ygshbht committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8f28580 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Remove lodashGet from useGeographicalStateFromRoute

    @ygshbht
    ygshbht committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7be20b3 View commit details
    Browse the repository at this point in the history

  2. StateSelectionPage appendParam restructuring

    @ygshbht
    ygshbht committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    428e48c View commit details
    Browse the repository at this point in the history

  3. Prettier formatting

    @ygshbht
    ygshbht committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7cd8b6f View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    5a02b71 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Comment typo fix src/pages/settings/Profile/PersonalDetails/StateSele… 

    …ctionPage.tsx

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ec0eb6f View commit details
    Browse the repository at this point in the history

  2. Comment formatting src/pages/settings/Profile/PersonalDetails/Address… 

    …Page.js

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    07f6f21 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    77f236c View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Fix TS errors

    @ygshbht
    ygshbht committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    877740b View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6731502 View commit details
    Browse the repository at this point in the history

  2. Refactor StateSelectionPage with more explanatory comments

    @ygshbht
    ygshbht committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a6faef4 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7db144b View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c0c1c6b View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Incorrect header space fix: src/pages/settings/Profile/PersonalDetail… 

    …s/StateSelectionPage.tsx

Co-authored-by: Rajat <parasharrajat@users.noreply.github.com>
    @ygshbht @parasharrajat
    ygshbht and parasharrajat committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7b15308 View commit details
    Browse the repository at this point in the history

  2. Remove unused code StateSelectionPage.tsx

    @ygshbht
    ygshbht committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    21b215a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0fd833f View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8c59969 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Prettier formatting

    @ygshbht
    ygshbht committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    397278d View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4a8d6d6 View commit details
    Browse the repository at this point in the history

  2. fix: handle potential 'undefined' object issue

    @ygshbht
    ygshbht committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5d223d6 View commit details
    Browse the repository at this point in the history

  3. Typo fix src/components/StateSelector.tsx 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3a3c767 View commit details
    Browse the repository at this point in the history

  4. Format src/libs/Url.ts 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c56f8d5 View commit details
    Browse the repository at this point in the history

  5. Format src/libs/Url.ts 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    470be54 View commit details
    Browse the repository at this point in the history

  6. Format src/pages/settings/Profile/PersonalDetails/StateSelectionPage.tsx 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    1670b66 View commit details
    Browse the repository at this point in the history

  7. Format src/pages/settings/Profile/PersonalDetails/AddressPage.tsx 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5d2ff1e View commit details
    Browse the repository at this point in the history

  8. Comment for function useGeographicalStateFromRoute

    @ygshbht
    ygshbht committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    18717ea View commit details
    Browse the repository at this point in the history

  9. hash append for StateSelector edge cases

    @ygshbht
    ygshbht committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3ba97a5 View commit details
    Browse the repository at this point in the history

  10. Comment update useGeographicalStateFromRoute

    @ygshbht
    ygshbht committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    0dc7f49 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Add StateSelector to MoneyRequest Navigation stack to work for /send/… 

    …new/add-debit-card
    @ygshbht
    ygshbht committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    57bcee2 View commit details
    Browse the repository at this point in the history

  2. Formatting src/pages/settings/Profile/PersonalDetails/AddressPage.tsx 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    9ffea05 View commit details
    Browse the repository at this point in the history

  3. Commnet udpate src/ROUTES.ts 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    d25904c View commit details
    Browse the repository at this point in the history

  4. Comment update ROUTES.ts

    @ygshbht
    ygshbht committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    81f452c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Example update src/hooks/useGeographicalStateFromRoute.ts 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @ygshbht @mountiny
    ygshbht and mountiny committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    dc35055 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a764d21 View commit details
    Browse the repository at this point in the history

  3. Refactor linking config StateSelector

    @ygshbht
    ygshbht committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    78afcd5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Revert "hash append for StateSelector edge cases" 

    This reverts commit 3ba97a5.
    @ygshbht
    ygshbht committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ecc3953 View commit details
    Browse the repository at this point in the history

  2. Sync URL 'state' param with StateSelector value

    @ygshbht
    ygshbht committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    713a91c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9a79421 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. change moneyrequest/state url to request/state 

    Co-authored-by: Rajat <parasharrajat@users.noreply.github.com>
    @ygshbht @parasharrajat
    ygshbht and parasharrajat committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2a76bed View commit details
    Browse the repository at this point in the history

  2. change moneyrequest/state url to request/state 

    Co-authored-by: Rajat <parasharrajat@users.noreply.github.com>
    @ygshbht @parasharrajat
    ygshbht and parasharrajat committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    49f2e46 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    15c54b2 View commit details
    Browse the repository at this point in the history

  2. StateSelector bugfix - for issue causing url to not update in browser… 

    … url bar
    @ygshbht
    ygshbht committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    58d92f1 View commit details
    Browse the repository at this point in the history

  3. useGeographicalStateFromRoute - check for state before accessing stat… 

    …eISO
    @ygshbht
    ygshbht committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    af6c3c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    24cbec3 View commit details
    Browse the repository at this point in the history

  2. Fix: Inconsistent validation error for required field in home address

    @ygshbht
    ygshbht committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    2619a29 View commit details
    Browse the repository at this point in the history

  3. Remove unused code: StateSelector

    @ygshbht
    ygshbht committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    f48a7fc View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. StateSelectionPage: Fix issue of page crash when country is changed m… 

    …ultiple times
    @ygshbht
    ygshbht committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4efccc0 View commit details
    Browse the repository at this point in the history

  2. es lint comment formatting

    @ygshbht
    ygshbht committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b9fe092 View commit details
    Browse the repository at this point in the history

  3. eslint Formatting fix

    @ygshbht
    ygshbht committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    5f0cc47 View commit details
    Browse the repository at this point in the history

  4. prettier

    @ygshbht
    ygshbht committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    3585296 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    639a646 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Merge branch 'main' into fix/address-page-state-navigation-2

    @ygshbht
    ygshbht committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    7e81480 View commit details
    Browse the repository at this point in the history

  2. Add explanatory comments to StateSelector

    @ygshbht
    ygshbht committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    3f87bf2 View commit details
    Browse the repository at this point in the history