-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the Report Details Page #3742
Conversation
@ctkochan22 Added some missing translations and took it off hold, should now be good for a review, thanks! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.74-1🚀
|
@jasperhuangg @ctkochan22 Heyo! We were not able to test this on our side. We're currently unable to add people to the workspace and create the chat rooms (On our expensifail domain). |
Tested this and it was a pass on Android, mWeb and Web, will get someone to test iOS and Desktop🎉(We were not sure on how to access rooms but Yuwen clarified here #3766 (comment)) |
Heads up @jasperhuangg @ctkochan22! Just FYI: this PR caused a bug here: #11982 |
Details
This PR adds the Report Details Page for default rooms and implements the ability to set notification preferences for a chatroom via a Picker.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/161785
Tests
Report_UpdateNotificationPreference
succeeds.QA Steps
Same as the above tests
Tested On
Screenshots
Web
web.mp4
Mobile Web
Desktop
desktop.mp4
iOS
ios.mp4
Android
2021-06-25_11-20-39.mp4
cc @yuwenmemon