Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Report Details Page #3742

Merged
merged 10 commits into from
Jun 28, 2021
Merged

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Jun 24, 2021

Details

This PR adds the Report Details Page for default rooms and implements the ability to set notification preferences for a chatroom via a Picker.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/161785

Tests

  1. Navigate to a default room.
  2. Clicked on the header for the default room. Verify it pulls up the report details page, and that it renders correctly.
  3. Change the notification preference. Verified that the Picker is updated to reflect the new notification preference, and that the API call to Report_UpdateNotificationPreference succeeds.
  4. Click on the "Members" menu item. Verify that the members list renders correctly.

QA Steps

Same as the above tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mp4

Mobile Web

Desktop

desktop.mp4

iOS

ios.mp4

Android

2021-06-25_11-20-39.mp4

cc @yuwenmemon

@jasperhuangg jasperhuangg self-assigned this Jun 24, 2021
@jasperhuangg jasperhuangg changed the title Create the Report Details Page [HOLD] Create the Report Details Page Jun 25, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review June 25, 2021 07:32
@jasperhuangg jasperhuangg requested a review from a team as a code owner June 25, 2021 07:32
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team June 25, 2021 07:32
@jasperhuangg jasperhuangg changed the title [HOLD] Create the Report Details Page Create the Report Details Page Jun 26, 2021
@jasperhuangg
Copy link
Contributor Author

@ctkochan22 Added some missing translations and took it off hold, should now be good for a review, thanks!

@ctkochan22 ctkochan22 merged commit 5eef861 into main Jun 28, 2021
@ctkochan22 ctkochan22 deleted the jasper-notificationPreferenceSetting branch June 28, 2021 19:07
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.74-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@jasperhuangg @ctkochan22 Heyo! We were not able to test this on our side. We're currently unable to add people to the workspace and create the chat rooms (On our expensifail domain).

@isagoico
Copy link

isagoico commented Jul 5, 2021

Tested this and it was a pass on Android, mWeb and Web, will get someone to test iOS and Desktop🎉(We were not sure on how to access rooms but Yuwen clarified here #3766 (comment))


image

@puneetlath
Copy link
Contributor

Heads up @jasperhuangg @ctkochan22! Just FYI: this PR caused a bug here: #11982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants