Start accounting for notificationPreferences in the unread indicator for Chat Rooms

[yuwenmemon]

@jasperhuangg please review

Details

When users have notificationPreferences in E.Chat for a given, room (comes live with https://github.com/Expensify/Expensify/issues/161785 cc @jasperhuangg) - follow them for push notifications within the app.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/161781

Tests/QA

1. Set your notification preferences for a policy's announce room to "always" by running the following JS in E.Web (User 1):

p = Policy.getCurrent();
announceID = p.policy.chatReportIDAnnounce
API._performPOSTRequest("Report_UpdateNotificationPreference", {
    reportID: announceID,
    notificationPreference: 'always'
});

2. For Phones, keep E.Chat running in the background for User 1, for Web/Desktop, have the tab or window open but not focused.
3. Open up E.Chat in another client from a different account that's also in the same policy (User 2)
4. From that account send 4 messages in the #announce room for that policy.
5. Make sure that the app indicator for the client User 1 is in shows 4

---

1. Set your notification preferences for a policy's announce room to "daily" by running the following JS in Web Expensify (OldDot) (User 1):

p = Policy.getCurrent();
announceID = p.policy.chatReportIDAnnounce
API._performPOSTRequest("Report_UpdateNotificationPreference", {
    reportID: announceID,
    notificationPreference: 'daily'
});

2. For Phones, keep E.Chat running in the background for User 1, for Web/Desktop, have the tab or window open but not focused.
3. Open up E.Chat in another client from a different account that's also in the same policy (User 2)
4. From that account send a message in the #announce room for that policy.
5. Make sure that the app indicator for the client User 1 is using shows 1 or is simply blank but present.

---

1. Set your notification preferences for a policy's announce room to "mute" by running the following JS in Web Expensify (OldDot) (User 1):

p = Policy.getCurrent();
announceID = p.policy.chatReportIDAnnounce
API._performPOSTRequest("Report_UpdateNotificationPreference", {
    reportID: announceID,
    notificationPreference: 'mute'
});

2. For Phones, keep E.Chat running in the background for User 1, for Web/Desktop, have the tab or window open but not focused.
3. Open up E.Chat in another client from a different account that's also in the same policy (User 2)
4. From that account send a message in the #announce room for that policy.
5. Make sure that you do not see any indicator update on the app icon for User 1

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android (Not Applicable)

Screenshots

Web

Mobile Web

N/A

Desktop

iOS

Android

Not Applicable

[jasperhuangg]

Hey @yuwenmemon! I can't seem to get this to work on Desktop when testing 'always'. I'm pretty sure I've followed the right steps, but the indicator always shows up as 1 regardless of how many messages I send, am I missing anything? Here's a screen capture:

demo.mp4

[yuwenmemon]

@jasperhuangg yep, unfortunately that's expected behavior for Desktop as the Electron API fails otherwise. See my QA step here:

Make sure that the app indicator for the client User 1 is using shows 1 or is simply blank but present.

and this comment here:
https://github.com/Expensify/Expensify.cash/pull/3766/files#diff-9276f078b750aa322d09bda48c79eb8034941df5b0f0f0c4f8b898cf9c652c41R244-R247

[thienlnam]

Awesome, thanks for entertaining my questions! Changes look good

[yuwenmemon]

Didn't see that you referring to an always preference @jasperhuangg - my bad. Just tested that again, not seeing what you're seeing. I have the always user signed in on the desktop app in this scenario:

[jasperhuangg]

Looks great and tests well :)

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.74-1🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@jasperhuangg @yuwenmemon Not sure if this is testable for us at the moment. I tried creating a workspace and adding members but I'm stuck on this page. It won't let me add members or create the chat rooms.

[yuwenmemon]

@isagoico can you add those folks to a policy in the "normal" Expensify web app?

[isagoico]

I created the workspace on an account and was unable to find the Policy in the classic app to add the members there. Not sure if I'm missing anything.

[yuwenmemon]

@isagoico perhaps just to keep things simple can you create the policy and add the members via the classic app?

[isagoico]

mmm I tried creating the policy in classic app and adding the members there and the workspace does not appear in e.cash. This is what I've tried, let me know if I'm missing something:

1. Create workspace in e.cash
2. Navigated to e.com to find the policy
3. Policy is not displayed in e.com
4. Tried accessing the policy via de Policy ID number in e.com (did not work)

Since above didn't work

1. I created a policy in e.com in a account that didn't have any previous policies
2. Added some members to the policy
3. Checked e.cash if I could see the workspace, nothing was displayed

[yuwenmemon]

I guess I'm a bit confused as to why you're looking for a workspace. We're not testing workspaces in this PR, we want to test the #announce room.

[isagoico]

OH I totally thought that the rooms like #announce were created when a workspace was set up. Not sure how to access the #announce room then 🤔 should it automatically appear on any account?

[yuwenmemon]

Try searching for the policy name OR announce in the E.Chat app:

[isagoico]

That worked! Thank you so much for the clarification, I was completely of the loop on how to access the rooms.
I tried following the steps and got this errors when running the snippets

Also when sending the messages, no notifications were received on the User 2 device (in my case it was my android phone)

[yuwenmemon]

@isagoico You'll need to run that snippet in the classic app.

There's no applicable test for this for Android, so that makes sense.

[isagoico]

Tested this and it was a pass:

• First scenario:

Got notifications for each message in this case 4

• Second scenario:

I got no notification but I did have the NEW! indicator.

• Third scenario:

No notification or NEW! indicator was displayed.