feat: policy add distance rate #38035

MrMuzyk · 2024-03-11T11:24:47Z

Details

added new page that allows user adding new distance rates

Fixed Issues

$ #37512
PROPOSAL:

Tests

Same as QA steps

Offline tests

QA Steps

have account with paid policy that has access to distance rates page
click on 'add rate' and fill in form
submit to add the rate
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.web.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…App into feat/policy-add-distance-rate

…icy-add-distance-rate

src/languages/es.ts

…icy-add-distance-rate

melvin-bot · 2024-03-12T08:17:16Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Policy.ts

src/pages/workspace/distanceRates/PolicyNewDistanceRatePage.tsx

src/libs/actions/Policy.ts

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

src/pages/workspace/distanceRates/PolicyNewDistanceRatePage.tsx

…icy-add-distance-rate

MrMuzyk · 2024-03-14T08:53:08Z

@situchan I did some minor changes to method that fires on clear - it works for me now. I've also fixed the autofocus bug. You can test it again

Screen.Recording.2024-03-14.at.09.48.56.mov

src/libs/actions/Policy.ts

src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx

luacmartins

Looking good. We need to address @situchan's comments + conflicts and we should be good to go. Please ping @situchan to continue their review when you've addressed the comments.

…icy-add-distance-rate

src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx

situchan · 2024-03-15T15:54:39Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

+    const validate = useCallback(
+        (values: FormOnyxValues<typeof ONYXKEYS.FORMS.POLICY_CREATE_DISTANCE_RATE_FORM>) => validateRateValue(values, outputCurrency, toLocaleDigit),
+        [outputCurrency, toLocaleDigit],
+    );


Please test this change at least on one platform to ensure that nothing broken.
I am testing this also.

Screen.Recording.2024-03-15.at.17.00.05.mov

I did. Just tested it again. Is something wrong?

Retested. Looks good

situchan · 2024-03-15T16:51:00Z

@luacmartins this is out of scope but this is already being handled in other PR, right?

Still able to access Distance rates, Add rate input pages after disabling in More features

bug.mov

OSBotify · 2024-03-15T17:12:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-18T16:30:31Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-19T23:11:35Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

alitoshmatov · 2024-04-11T16:09:32Z

src/libs/actions/Policy.ts

@@ -3621,6 +3622,83 @@ function openPolicyMoreFeaturesPage(policyID: string) {
    API.read(READ_COMMANDS.OPEN_POLICY_MORE_FEATURES_PAGE, params);
 }



Case missed when updating workspace currency distance rates are reset based on old logic which had one distance rate: #30156

DylanDylann · 2024-12-20T03:39:22Z

src/libs/PolicyDistanceRatesUtils.ts

+
+type RateValueForm = typeof ONYXKEYS.FORMS.WORKSPACE_RATE_AND_UNIT_FORM | typeof ONYXKEYS.FORMS.POLICY_CREATE_DISTANCE_RATE_FORM;
+
+function validateRateValue(values: FormOnyxValues<RateValueForm>, currency: string, toLocaleDigit: (arg: string) => string): FormInputErrors<RateValueForm> {


We miss to check the duplicated value and it caused this problem #51769

MrMuzyk added 8 commits March 7, 2024 15:14

feat: PolicyNewDistanceRatePage

c14fbf8

Merge branch 'feat/policy-distance-rates-page' of github.com:MrMuzyk/…

b20f519

…App into feat/policy-add-distance-rate

Merge branch 'feat/policy-distance-rates-page' of github.com:MrMuzyk/…

729c746

…App into feat/policy-add-distance-rate

Merge branch 'feat/policy-distance-rates-page' of github.com:MrMuzyk/…

84115b4

…App into feat/policy-add-distance-rate

feat: adding delete

f7567c3

Merge branch 'main' of https://github.com/Expensify/App into feat/pol…

c74c9fb

…icy-add-distance-rate

feat: add

d0d8d2c

fix: ts error

d27b9fe

MrMuzyk commented Mar 11, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

MrMuzyk added 3 commits March 11, 2024 13:32

fix: scrap delete from this PR

cfa9145

fix: one line

2b1baf7

feat: add validation

1b53b39

MrMuzyk mentioned this pull request Mar 11, 2024

feat: policy distance rates settings #38060

Merged

49 tasks

luacmartins self-requested a review March 12, 2024 00:46

Merge branch 'main' of https://github.com/Expensify/App into feat/pol…

f24b378

…icy-add-distance-rate

MrMuzyk marked this pull request as ready for review March 12, 2024 08:17

MrMuzyk requested a review from a team as a code owner March 12, 2024 08:17

melvin-bot bot requested review from situchan and removed request for a team March 12, 2024 08:17

situchan reviewed Mar 12, 2024

View reviewed changes

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

src/pages/workspace/distanceRates/PolicyNewDistanceRatePage.tsx Outdated Show resolved Hide resolved

luacmartins requested changes Mar 12, 2024

View reviewed changes

MrMuzyk added 2 commits March 13, 2024 09:49

Merge branch 'main' of https://github.com/Expensify/App into feat/pol…

bf5ba1d

…icy-add-distance-rate

fix: cr fixes

f6df548

MrMuzyk requested a review from luacmartins March 13, 2024 12:16

MrMuzyk added 3 commits March 13, 2024 14:43

fix: error handling

ba3f3b3

Merge branch 'main' of https://github.com/Expensify/App into feat/pol…

ddeabce

…icy-add-distance-rate

Merge branch 'main' of https://github.com/Expensify/App into feat/pol…

94638fc

…icy-add-distance-rate

MrMuzyk mentioned this pull request Mar 13, 2024

feat: policy distance rates edit #38237

Merged

50 tasks

MrMuzyk requested a review from situchan March 13, 2024 15:37

MrMuzyk requested a review from luacmartins March 14, 2024 08:53

situchan reviewed Mar 14, 2024

View reviewed changes

src/libs/actions/Policy.ts Outdated Show resolved Hide resolved

situchan reviewed Mar 14, 2024

View reviewed changes

src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx Outdated Show resolved Hide resolved

luacmartins reviewed Mar 14, 2024

View reviewed changes

MrMuzyk added 2 commits March 15, 2024 08:43

fix: last cr fixes

d04d2a3

Merge branch 'main' of https://github.com/Expensify/App into feat/pol…

9522399

…icy-add-distance-rate

MrMuzyk requested review from situchan and luacmartins March 15, 2024 12:22

situchan reviewed Mar 15, 2024

View reviewed changes

src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx Outdated Show resolved Hide resolved

MrMuzyk added 2 commits March 15, 2024 14:39

fix: move validate to util

78bd350

fix: remove extra const

e096ce3

MrMuzyk requested a review from situchan March 15, 2024 13:48

luacmartins approved these changes Mar 15, 2024

View reviewed changes

situchan reviewed Mar 15, 2024

View reviewed changes

situchan approved these changes Mar 15, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 15, 2024 17:00

luacmartins approved these changes Mar 15, 2024

View reviewed changes

luacmartins merged commit 1f232f2 into Expensify:main Mar 15, 2024
16 of 20 checks passed

github-actions bot mentioned this pull request Mar 18, 2024

Deploy Checklist: New Expensify 2024-03-18 #38489

Closed

65 tasks

kbecciv mentioned this pull request Mar 18, 2024

[Simplified Collect][Distance Rates] Distance rates - Enter key does not save distance rate #38509

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 19, 2024

[$500] [Simplified Collect][Distance Rates] Implement CreateDistanceRatePage #37512

Closed

alitoshmatov reviewed Apr 11, 2024

View reviewed changes

alitoshmatov mentioned this pull request Apr 11, 2024

[HOLD for payment 2024-04-09] [Simplified Collect][Distance rates] - Distance rates disappear when changing default workspace currency offline #38928

Closed

6 tasks

DylanDylann reviewed Dec 20, 2024

View reviewed changes

DylanDylann mentioned this pull request Dec 20, 2024

[PAID] [$250] Distance rate- WS owner can create multiple distance rate with same amount #51769

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: policy add distance rate #38035

feat: policy add distance rate #38035

MrMuzyk commented Mar 11, 2024 •

edited

Loading

melvin-bot bot commented Mar 12, 2024

MrMuzyk commented Mar 14, 2024 •

edited

Loading

luacmartins left a comment •

edited

Loading

situchan Mar 15, 2024

MrMuzyk Mar 15, 2024

situchan Mar 15, 2024

situchan commented Mar 15, 2024

OSBotify commented Mar 15, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

alitoshmatov Apr 11, 2024

DylanDylann Dec 20, 2024

		@@ -3621,6 +3622,83 @@ function openPolicyMoreFeaturesPage(policyID: string) {
		API.read(READ_COMMANDS.OPEN_POLICY_MORE_FEATURES_PAGE, params);
		}


		type RateValueForm = typeof ONYXKEYS.FORMS.WORKSPACE_RATE_AND_UNIT_FORM \| typeof ONYXKEYS.FORMS.POLICY_CREATE_DISTANCE_RATE_FORM;

		function validateRateValue(values: FormOnyxValues<RateValueForm>, currency: string, toLocaleDigit: (arg: string) => string): FormInputErrors<RateValueForm> {

feat: policy add distance rate #38035

feat: policy add distance rate #38035

Conversation

MrMuzyk commented Mar 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 12, 2024

MrMuzyk commented Mar 14, 2024 • edited Loading

luacmartins left a comment • edited Loading

Choose a reason for hiding this comment

situchan Mar 15, 2024

Choose a reason for hiding this comment

MrMuzyk Mar 15, 2024

Choose a reason for hiding this comment

situchan Mar 15, 2024

Choose a reason for hiding this comment

situchan commented Mar 15, 2024

OSBotify commented Mar 15, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

alitoshmatov Apr 11, 2024

Choose a reason for hiding this comment

DylanDylann Dec 20, 2024

Choose a reason for hiding this comment

MrMuzyk commented Mar 11, 2024 •

edited

Loading

MrMuzyk commented Mar 14, 2024 •

edited

Loading

luacmartins left a comment •

edited

Loading