fix empty chat displayed in focus mode #40336

tienifr · 2024-04-17T08:18:07Z

Details

Fixed Issues

$ #38368
PROPOSAL: #38368 (comment)

Tests

Open app
Log out
Log in with a new account
Go to setting page and switch to focus mode
Return to chat list
Verify there are no selfDM chat displays (selfDM is the report contains (You) at the end.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app
Log out
Log in with a new account
Go to setting page and switch to focus mode
Return to chat list
Verify there are no selfDM chat displays (selfDM is the report contains (You) at the end.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-17.at.15.34.25.mov

Android: mWeb Chrome

Screen.Recording.2024-04-17.at.15.32.50.mov

iOS: Native

Screen.Recording.2024-04-17.at.15.29.27.mov

iOS: mWeb Safari

Screen.Recording.2024-04-17.at.15.27.22.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.15.09.26.mov

MacOS: Desktop

Screen.Recording.2024-04-17.at.15.23.41.mov

melvin-bot · 2024-04-17T08:18:11Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-04-18T14:40:57Z

tests/unit/SidebarOrderTest.ts

-            const report2 = LHNTestUtils.getFakeReport([3, 4], 2, true);
-            const report3 = LHNTestUtils.getFakeReport([5, 6], 1, true);
-            const report4 = LHNTestUtils.getFakeReport([7, 8], 0, true);
+            const report1 = {...LHNTestUtils.getFakeReport([1, 2], 3, true), lastMessageText: 'test'};


Add lastMessageText to getFakeReport

Actually let's not block on this. I see getFakeReport used in many places where we just extend its response

s77rt · 2024-04-18T15:01:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

flodnv

Looks good but can we do this too?

I'm not sure why we named this like that, but seeing as it's called "focus" mode through the stack, let's name this to isInFocusMode

tienifr · 2024-04-19T07:57:37Z

@flodnv Apologies, I'm not entirely clear on your meaning:

but seeing as it's referred to as "focus" mode throughout the stack, let's name this to isInFocusMode

Please indicate where it's referenced as "focus" mode by commenting on the code. Thanks

flodnv · 2024-04-19T13:04:38Z

Apologies for my lack of clarity. I meant, can we rename isInGSDMode to isInFocusMode everywhere in the code?

tienifr · 2024-04-22T22:41:35Z

@flodnv I resolved your comment

flodnv · 2024-04-23T13:54:44Z

src/libs/ReportUtils.ts

@@ -4616,11 +4616,23 @@ function buildOptimisticMoneyRequestEntities(
    return [createdActionForChat, createdActionForIOUReport, iouAction, transactionThread, createdActionForTransactionThread];
 }

+// Check if the report is empty report


We should use comments to be descriptive and explain why or how the code is doing so and so, instead of using comments to repeat what the code is already saying.

So here, we can say something like:

// Check if the report is empty, meaning it has no visible messages (i.e. only a "created" report action).

I updated comment

flodnv · 2024-04-24T13:39:37Z

It looks like this PR may have broken Reassure Performance Tests?

tienifr · 2024-04-25T09:44:25Z

I am investigating the Reassure Performance Tests issue

s77rt · 2024-05-01T12:57:29Z

Any update on this?

tienifr · 2024-05-04T07:39:11Z

I am still investigating how to pass the perf test. @s77rt. Do you have any suggestions?

CortneyOfstad · 2024-05-06T14:35:26Z

@s77rt any update on @tienifr's question here? Thanks!

s77rt · 2024-05-06T17:37:58Z

@tienifr In the SidebarLinks perf test the mocked reports are empty thus they are skipped and we end up with 0 reports so we don't render the FlatList. Solution: In getMockedReportsMap make the reports non-empty i.e.

const report = {...LHNTestUtils.getFakeReport(participants, 1, true), lastMessageText: 'hey'};

tienifr · 2024-05-07T08:00:11Z

@s77rt Thanks for your suggestion.

@flodnv Perf test is passed. Can you help review? Thanks

flodnv · 2024-05-08T13:12:51Z

Setting myself a reminder to merge on Monday - https://expensify.slack.com/archives/C01GTK53T8Q/p1715105636003919

OSBotify · 2024-05-10T14:48:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-13T08:42:01Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.4.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lanitochka17 · 2024-05-13T14:17:51Z

This PR is failing because of issue #42070

330089805-c1565812-33b6-4347-af2a-53d104cba0cb.mp4

OSBotify · 2024-05-15T09:50:10Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fedirjh · 2024-07-22T10:23:02Z

src/libs/ReportUtils.ts

+    if (!report) {
+        return true;
+    }
+    const lastVisibleMessage = ReportActionsUtils.getLastVisibleMessage(report.reportID);


Coming from this bug #43994, we should have used ReportUtils.getLastVisibleMessage instead of ReportActionsUtils.getLastVisibleMessage to avoid such a bug, more context in #43994 (comment)

Why do we have two functions? We should merge into one. Looking at the function names alone you can't tell which one to use

The only difference is that when a message is deleted:

ReportUtils.getLastVisibleMessage will return [Deleted message];

ReportActionsUtils.getLastVisibleMessage will return an empty string '';

Hm, I agree this is error prone and will tend to lead to more bugs.

fix empty chat displayed in focus mode

a743ffc

tienifr requested a review from a team as a code owner April 17, 2024 08:18

melvin-bot bot removed the request for review from a team April 17, 2024 08:18

melvin-bot bot requested a review from s77rt April 17, 2024 08:18

tienifr mentioned this pull request Apr 17, 2024

[HOLD for payment 2024-05-22] CRITICAL: [$500] Random empty chats are showing in LHN in focus mode #38368

Closed

6 tasks

fix jest test

787ad3b

s77rt suggested changes Apr 18, 2024

View reviewed changes

s77rt approved these changes Apr 18, 2024

View reviewed changes

melvin-bot bot requested a review from flodnv April 18, 2024 15:04

flodnv reviewed Apr 18, 2024

View reviewed changes

fix merge main

f63b00a

tienifr added 2 commits April 23, 2024 05:34

fix merge main

5ba3936

fix rename isInGSDMode

8b1fce7

flodnv requested changes Apr 23, 2024

View reviewed changes

fix update comment

53fecfa

fix merge main

36b0a8d

tienifr added 2 commits May 7, 2024 14:47

fix perf test

580e4a0

fix merge main

9509578

flodnv approved these changes May 8, 2024

View reviewed changes

flodnv merged commit ce1fd06 into Expensify:main May 10, 2024
15 checks passed

github-actions bot mentioned this pull request May 13, 2024

Deploy Checklist: New Expensify 2024-05-13 #42040

Closed

74 tasks

lanitochka17 mentioned this pull request May 13, 2024

[$250] Chat - Self DM is automatically pinned and doesn't disappear in #focus mode #42070

Closed

6 tasks

thienlnam mentioned this pull request May 13, 2024

[HOLD for payment 2024-06-05] [UX Reliability] [$250] Expense - LHN shows blank row when opening transaction thread #42096

Closed

6 tasks

fedirjh reviewed Jul 22, 2024

View reviewed changes

fedirjh mentioned this pull request Jul 22, 2024

[Awaiting checklist] [$250] 'Mark Unread' button unresponsive despite green line in composer #43994

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix empty chat displayed in focus mode #40336

fix empty chat displayed in focus mode #40336

tienifr commented Apr 17, 2024 •

edited

Loading

melvin-bot bot commented Apr 17, 2024

s77rt Apr 18, 2024

s77rt Apr 18, 2024

s77rt commented Apr 18, 2024

flodnv left a comment

tienifr commented Apr 19, 2024

flodnv commented Apr 19, 2024

tienifr commented Apr 22, 2024

flodnv Apr 23, 2024

tienifr Apr 24, 2024

flodnv commented Apr 24, 2024

tienifr commented Apr 25, 2024

s77rt commented May 1, 2024

tienifr commented May 4, 2024

CortneyOfstad commented May 6, 2024

s77rt commented May 6, 2024

tienifr commented May 7, 2024

flodnv commented May 8, 2024

OSBotify commented May 10, 2024

OSBotify commented May 13, 2024

lanitochka17 commented May 13, 2024

OSBotify commented May 15, 2024

fedirjh Jul 22, 2024

s77rt Jul 22, 2024

fedirjh Jul 22, 2024

flodnv Jul 22, 2024

fix empty chat displayed in focus mode #40336

fix empty chat displayed in focus mode #40336

Conversation

tienifr commented Apr 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt commented Apr 18, 2024

Reviewer Checklist

Screenshots/Videos

flodnv left a comment

Choose a reason for hiding this comment

tienifr commented Apr 19, 2024

flodnv commented Apr 19, 2024

tienifr commented Apr 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flodnv commented Apr 24, 2024

tienifr commented Apr 25, 2024

s77rt commented May 1, 2024

tienifr commented May 4, 2024

CortneyOfstad commented May 6, 2024

s77rt commented May 6, 2024

tienifr commented May 7, 2024

flodnv commented May 8, 2024

OSBotify commented May 10, 2024

OSBotify commented May 13, 2024

lanitochka17 commented May 13, 2024

OSBotify commented May 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tienifr commented Apr 17, 2024 •

edited

Loading