[HOLD for payment 2024-06-05] [UX Reliability] [$250] Expense - LHN shows blank row when opening transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.73-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com, go offline
2. Submit two expenses to a user with no chat history
3. Click on the IOU preview in the main chat
4. Click on the first expense

Expected Result:

LHN will display the transaction thread of the first expense

Actual Result:

LHN displays a blank row for the transaction thread of the first expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479555_1715616252998.20240513_235920.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a437d649825676f1
• Upwork Job ID: 1790367877808570368
• Last Price Increase: 2024-05-14
• Automatic offers:
• DylanDylann | Contributor | 0

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[thienlnam]

Can be produced offline so it's probably not an API blocker

[thienlnam]

Thought it might have been #40336 but I can still reproduce with it - it requires that you are offline

[thienlnam]

I can still reproduce with #41821 so it isn't that one either

[Beamanator]

Hmm confirmed this isn't happening in prod 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a437d649825676f1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[Beamanator]

I believe this can be external, since this pretty much is only happening when offline 🤔

[ishpaul777]

i think this one is offending PR #41898

[Beamanator]

@ishpaul777 can you please explain why you think so? :D 🙏

[ishpaul777]

there's a View added instead of returning null here - https://github.com/Expensify/App/pull/41898/files#diff-a15d3e01be92ab98c02424f703df250303283d66591b3a86aa825534278e0d4cR65, reverting PR solves the empty space issue

Untitled.mov

[ishpaul777]

There's another issue i noticed after the revert the expense details report is not in LHN (reproduce on prod. also)

PROD VIDEO:

Screen.Recording.2024-05-14.at.10.27.53.PM.mov

[thienlnam]

Removing the blocker for this reasoning

1. It only happens if you try to create multiple submits and open one offline, but doesn’t actually prevent you from doing anything
2. The reduction in memory is a more important PR

That being said, we should aim to fix this soon but not a blocker since it's a specific offline flow

[mountiny]

Jack is ooo, I will take this over

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: empty cell being shown when submitting and opening an expense in offline mode #42276

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

I believe this will be $250 to @DylanDylann as the only payment on this issue

[twisterdotcom]

Offer sent. Will pay out on Wednesday.

[twisterdotcom]

Payment Summary:

• @DylanDylann paid $250 here (C+)