perf: fix significant memory consumption on web and desktop #41898

hurali97 · 2024-05-09T12:15:09Z

Details

This PR fixes the significant amount of memory consumption on web and desktop.

Before:

Part 1

before-1.mp4

Part 2

before-2.mp4

After:

after.mp4

Fixed Issues

$ #41903
PROPOSAL: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1715176526258709?thread_ts=1714771702.057689&cid=C05LX9D6E07

Tests

Testing Steps

Sign in to a heavy account on web or desktop and wait for the UI to load
Once the UI is visible, the app shouldn't freeze and shouldn't consume huge amount of memory
Switch to settings, the app shouldn't freeze and shouldn't consume huge amount of memory
If want to see how I tested it, more details can be found here
Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…FlashList to render all its children and consume signficant memory

…s FlashList renders all its children when we switch from LHN to settings

src/libs/Navigation/FreezeWrapper.tsx

src/components/LHNOptionsList/OptionRowLHN.tsx

DylanDylann · 2024-05-09T13:01:27Z

@mountiny How I can access PROPOSAL: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1715176526258709?thread_ts=1714771702.057689&cid=C05LX9D6E07 ?

If it is a private room, please help to make a brief overview here. Thanks
cc @hurali97

mountiny · 2024-05-09T13:09:31Z

@DylanDylann https://expensify.slack.com/archives/C05LX9D6E07/p1715260159661179?thread_ts=1714771702.057689&cid=C05LX9D6E07

melvin-bot · 2024-05-10T07:20:59Z

@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-05-10T07:35:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-10.at.16.28.38.mov

Android: mWeb Chrome

Screen.Recording.2024-05-10.at.16.10.43.mov

iOS: Native

Screen.Recording.2024-05-10.at.16.26.45.mov

iOS: mWeb Safari

Screen.Recording.2024-05-10.at.16.04.17.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-10.at.15.53.31.mov

MacOS: Desktop

Screen.Recording.2024-05-10.at.15.58.40.mov

src/libs/Navigation/shouldSetScreenBlurred/index.tsx

mountiny · 2024-05-10T12:00:52Z

src/libs/Navigation/shouldSetScreenBlurred/index.tsx

+ * Allow freezing the first screen and more in the stack only on
+ * web and desktop platforms. The reason is that in the case of
+ * LHN, we have FlashList rendering in the back while we are on
+ * Settings screen.


Is this assuming then that web/desktop is wide layout and native is narrow layout?

Its not a best practice and we should avoid that if that is the case as we are working on allowing wide layout on native ipad too and then this would not work that well. Not a blocker though

OSBotify · 2024-05-10T12:10:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-13T08:43:27Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

thienlnam · 2024-05-14T18:56:53Z

@hurali97 Looks like this PR caused #42096, are you able to take a look please?

OSBotify · 2024-05-15T09:51:37Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hurali97 · 2024-05-15T13:38:46Z

@hurali97 Looks like this PR caused #42096, are you able to take a look please?

@thienlnam I will take a look at this tomorrow 👍

hurali97 added 2 commits May 9, 2024 17:12

perf: avoid rendering null as FlashList render item which causes the …

14c14f6

…FlashList to render all its children and consume signficant memory

perf: allow freezing the first screen on web and desktop. Without thi…

81f1f5a

…s FlashList renders all its children when we switch from LHN to settings

mountiny requested changes May 9, 2024

View reviewed changes

src/libs/Navigation/FreezeWrapper.tsx Outdated Show resolved Hide resolved

danieldoglas reviewed May 9, 2024

View reviewed changes

src/components/LHNOptionsList/OptionRowLHN.tsx Show resolved Hide resolved

mountiny assigned hurali97 May 9, 2024

mountiny requested a review from DylanDylann May 9, 2024 12:54

hurali97 added 2 commits May 10, 2024 12:04

refactor: use dedicated platform files for platform dependent code

140a02e

feat: add comments for why we need to render a placeholder view

3695e88

hurali97 marked this pull request as ready for review May 10, 2024 07:20

hurali97 requested a review from a team as a code owner May 10, 2024 07:20

melvin-bot bot removed the request for review from a team May 10, 2024 07:20

melvin-bot bot requested a review from danieldoglas May 10, 2024 07:20

mountiny reviewed May 10, 2024

View reviewed changes

src/libs/Navigation/shouldSetScreenBlurred/index.tsx Outdated Show resolved Hide resolved

feat: add descriptive comments for shouldSetScreenBlurred function

456fe95

DylanDylann approved these changes May 10, 2024

View reviewed changes

danieldoglas approved these changes May 10, 2024

View reviewed changes

mountiny approved these changes May 10, 2024

View reviewed changes

danieldoglas merged commit 7fc1590 into Expensify:main May 10, 2024
18 checks passed

github-actions bot mentioned this pull request May 13, 2024

Deploy Checklist: New Expensify 2024-05-13 #42040

Closed

74 tasks

This was referenced May 14, 2024

Revert "perf: fix significant memory consumption on web and desktop" #42150

Closed

[HOLD for payment 2024-06-05] [UX Reliability] [$250] Expense - LHN shows blank row when opening transaction thread #42096

Closed

melvin-bot bot mentioned this pull request May 15, 2024

[HOLD for payment 2024-05-22] New Expensify is using too much memory #41903

Closed

aimane-chnaif mentioned this pull request May 22, 2024

[Hold for 40548] [$500] iOS - Chat - Send button is not responding after viewing avatar in full screen #40797

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: fix significant memory consumption on web and desktop #41898

perf: fix significant memory consumption on web and desktop #41898

hurali97 commented May 9, 2024 •

edited

Loading

DylanDylann commented May 9, 2024 •

edited

Loading

mountiny commented May 9, 2024

melvin-bot bot commented May 10, 2024

DylanDylann commented May 10, 2024 •

edited

Loading

mountiny May 10, 2024

OSBotify commented May 10, 2024

OSBotify commented May 13, 2024

thienlnam commented May 14, 2024

OSBotify commented May 15, 2024

hurali97 commented May 15, 2024

perf: fix significant memory consumption on web and desktop #41898

perf: fix significant memory consumption on web and desktop #41898

Conversation

hurali97 commented May 9, 2024 • edited Loading

Details

Before:

After:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

DylanDylann commented May 9, 2024 • edited Loading

mountiny commented May 9, 2024

melvin-bot bot commented May 10, 2024

DylanDylann commented May 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny May 10, 2024

Choose a reason for hiding this comment

OSBotify commented May 10, 2024

OSBotify commented May 13, 2024

thienlnam commented May 14, 2024

OSBotify commented May 15, 2024

hurali97 commented May 15, 2024

hurali97 commented May 9, 2024 •

edited

Loading

DylanDylann commented May 9, 2024 •

edited

Loading

DylanDylann commented May 10, 2024 •

edited

Loading