-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍒 Cherry pick PR #40824 to staging 🍒 #40825
Conversation
(cherry picked from commit ad68a46)
Fix: Correct Footer Display in MoneyRequestConfirmationList Component (cherry picked from commit 4b0e4ee)
(cherry picked from commit 5c6a99d)
[CP Staging] Revert "Block edit assignee and mark as complete simultaneously" (cherry picked from commit 51f1c2a)
(cherry picked from commit 63affdb)
…is-ur-magic-code-shows-briefly [CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link" (cherry picked from commit 767367b)
(cherry picked from commit bebeed1)
…d-followups [CP Staging] Feat/36985 create new rate field followups (cherry picked from commit 7e5b436)
(cherry picked from commit 6b18ee9)
[CP Staging] Fix: Android - Workspace list - Workspace name and email address are truncated (cherry picked from commit 109d0f0)
This pull request has merge conflicts and can not be automatically merged. 😞 |
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Ok the difference was in - style={[styles.workspaceThreeDotMenu]}
+ style={[!isSmallScreenWidth && styles.workspaceThreeDotMenu]} |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
d1b44b0
to
eb6331c
Compare
Well this fell through the cracks, we need to improve the actions to inform people in Slack as I was not checking all the github notification 😡 this is already in staging so we can close it |
🍒 Cherry pick #40824 to staging 🍒
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined