-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][TS Migration] Add comments for remaining properties in Onyx types #41956
Merged
mountiny
merged 28 commits into
Expensify:main
from
callstack-internal:pac-guerreiro/refactor/39129-add-comments-to-remaining-onyx-types
Jun 7, 2024
Merged
Changes from 19 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
5b9433c
docs: add onyx types descriptions
pac-guerreiro 4dac52f
docs: add missing onyx types descriptions
pac-guerreiro ee11f2e
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 8631fa8
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 13029ae
docs: add missing type descriptions
pac-guerreiro 3494545
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 96f6955
docs: apply pull request suggestions
pac-guerreiro 65022fb
refactor: apply pull request suggestions
pac-guerreiro f3e1c8f
refactor: apply pull request suggestions
pac-guerreiro 530d6d6
refactor: remove unused property from wallet additional details
pac-guerreiro 9a50d43
docs: add missing type description
pac-guerreiro 611266d
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro a4d4102
chore: resolve pending descriptions
pac-guerreiro 8025926
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 5599455
docs: apply suggestions
pac-guerreiro 2d91475
docs: apply suggestions
pac-guerreiro da515a8
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 530b1ce
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 68ce115
refactor: apply pull request suggestions
pac-guerreiro 279e50a
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 9fe6712
chore: apply pull request suggestions and address types with missing …
pac-guerreiro c46d709
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 6dabcc0
chore: enable eslint rule that requires comments on onyx types and th…
pac-guerreiro 11090bd
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
pac-guerreiro 453343e
refactor: apply pull request suggestions
pac-guerreiro 98fa483
Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to…
fabioh8010 a354239
Fix lint errors and improve comments
fabioh8010 199e228
Merge remote-tracking branch 'origin/main' into pac-guerreiro/refacto…
fabioh8010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ import type {GestureResponderEvent, TextInput} from 'react-native'; | |
import {InteractionManager, View} from 'react-native'; | ||
import type {OnyxCollection, OnyxEntry} from 'react-native-onyx'; | ||
import {withOnyx} from 'react-native-onyx'; | ||
import type {ValueOf} from 'type-fest'; | ||
import type {Emoji} from '@assets/emojis/types'; | ||
import {AttachmentContext} from '@components/AttachmentContext'; | ||
import Button from '@components/Button'; | ||
|
@@ -393,7 +394,10 @@ function ReportActionItem({ | |
const attachmentContextValue = useMemo(() => ({reportID: report.reportID, type: CONST.ATTACHMENT_TYPE.REPORT}), [report.reportID]); | ||
|
||
const actionableItemButtons: ActionableItem[] = useMemo(() => { | ||
if (!isActionableWhisper && (!ReportActionsUtils.isActionableJoinRequest(action) || action.originalMessage.choice !== '')) { | ||
if ( | ||
!isActionableWhisper && | ||
(!ReportActionsUtils.isActionableJoinRequest(action) || action.originalMessage.choice !== ('' as ValueOf<typeof CONST.REPORT.ACTIONABLE_MENTION_JOIN_WORKSPACE_RESOLUTION>)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And here. |
||
) { | ||
return []; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets create a type for
ValueOf<typeof CONST.REPORT.ACTIONABLE_MENTION_JOIN_WORKSPACE_RESOLUTION>
and use it here.