Refactor/36648 wallet enablement flow connect steps #42589

koko57 · 2024-05-24T13:28:41Z

Details

Fixed Issues

$ #36648
PROPOSAL: -

Tests

Go to Settings/Wallet
Click on Enable Wallet button
Verify that you're redirected to /settings/wallet/enable-payments page.
Go through the flow, verify that you can pass the flow successfully and the fields are validated properly.

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Go to Settings/Wallet
Click on Enable Wallet button
Verify that you're redirected to /settings/wallet/enable-payments page.
Go through the flow, verify that you can pass the flow successfully and the fields are validated properly.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…-identity

…tor/36648-wallet-enablement-flow-verify-identity-draft

…-identity-draft

…y when missing data

…t-steps

DylanDylann · 2024-06-10T13:27:03Z

@koko57 Please address the lint error

koko57 · 2024-06-10T14:05:50Z

@DylanDylann lint error fixed

koko57 · 2024-06-10T14:30:26Z

@Pujan92 fixed

mountiny

@Pujan92 @DylanDylann are you happy with the changes?

github-actions · 2024-06-10T15:21:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42589/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42589/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42589/NewExpensify.dmg	https://42589.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

DylanDylann · 2024-06-10T15:35:25Z

Please give me an hour to review the change

Pujan92 · 2024-06-10T16:13:22Z

@Pujan92 @DylanDylann are you happy with the changes?

Yes @mountiny, changes look good to me.

jamesdeanexpensify · 2024-06-10T16:25:15Z

Hi all - apologies for the late copy suggestions, but I have a few. Let me know if this isn't the right place or time:

Under "What's your address?" could we do "No PO boxes or mail-drop addresses, please."
The first "Fees and terms" screen, maybe the header could just be "Please review the fees below"
The second "Fees and terms" screen, maybe the header could just be "Please check the boxes below"

jamesdeanexpensify · 2024-06-10T23:40:06Z

Getting Spanish translations for the suggestions above, hold tight!

koko57 · 2024-06-11T06:36:07Z

@jamesdeanexpensify ping me when you will have the translations ready, I will add them to this PR, thanks!

jamesdeanexpensify · 2024-06-11T16:36:51Z

No PO boxes or mail-drop addresses, please. > Nada de apartados de correos ni direcciones de envío, por favor.
Please review the fees below > Por favor, revisa las siguientes tarifas
Please check the boxes below > Por favor, marca las siguientes casillas

jamesdeanexpensify · 2024-06-11T16:37:25Z

ready for you @koko57 !

koko57 · 2024-06-11T17:01:02Z

@jamesdeanexpensify thanks! applying them to this PR!

…t-steps

koko57 · 2024-06-11T18:04:35Z

@jamesdeanexpensify changes applied - the first pair of translations (No PO boxes...) was already in the app, but I needed to swap the translation key. The other translations were added.

jamesdeanexpensify · 2024-06-11T18:09:32Z

Thank you!

mountiny

Thanks @koko57 @DylanDylann @Pujan92 for getting this across the finish line 🙇

OSBotify · 2024-06-12T12:09:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-14T23:03:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh · 2024-07-19T11:51:04Z

src/pages/EnablePayments/EnablePayments.tsx

+            <>
+                <HeaderWithBackButton
+                    title={translate('additionalDetailsStep.headerTitle')}
+                    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}
+                />
+                <FailedKYC />
+            </>


We missed wrapping those into ScreenWrapper, therefore it caused a UI bug here #44805

koko57 added 28 commits April 17, 2024 22:00

feat: verify identity step setup

1e0e916

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

bd97f55

…-identity

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

d0d6b66

…-identity

Merge branch 'refactor/36648-wallet-enablement-flow-terms' into refac…

37072ac

…tor/36648-wallet-enablement-flow-verify-identity-draft

refactor: wip - connect all the steps

ca6201f

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

7a7c56e

…-identity-draft

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

1db17ab

…-identity-draft

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

eeb89be

…-identity-draft

feat: add verify identity intro page

5c427c1

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

f31778a

…-identity-draft

fix: get token and applicantID from walletOnfidoData

2ec3411

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

3c3e875

…-identity-draft

feat: change wallet agreement url for bancorp

4706357

refactor: cleanup

c6028f7

Merge branch 'main' into refactor/36648-wallet-enablement-flow-verify…

b3627ae

…-identity-draft

chore: clean wallet draft after finishing the flow

9764c60

fix: remove old add plaid bank account layout

aa7d744

fix: include add bank acount to the flow

f189a8c

fix: show loading when confirming personal info, fetch userWallet onl…

034b82d

…y when missing data

Merge branch 'main' into refactor/36648-wallet-enablement-flow-connec…

75a219f

…t-steps

fix: proper submit/go back handling for the terms step

c5291d7

fix: properly show the first step

3538c69

fix: remove unnecessary comment

c1bea82

feat: routes cleanup

f3287b8

fix: minor fixes, lint

8e268c4

Merge branch 'main' into refactor/36648-wallet-enablement-flow-connec…

ac5dc1e

…t-steps

fix: minor fixes

9178916

fix: minor fix

0a5ce01

koko57 marked this pull request as ready for review May 27, 2024 13:48

koko57 requested a review from a team as a code owner May 27, 2024 13:48

fix: lint

f94279f

fix: change deprecated withOnyx for useOnyx

441e298

mountiny previously approved these changes Jun 10, 2024

View reviewed changes

DylanDylann approved these changes Jun 10, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny June 10, 2024 16:44

koko57 added 2 commits June 11, 2024 19:02

Merge branch 'main' into refactor/36648-wallet-enablement-flow-connec…

7c6e7f0

…t-steps

fix: replace translations

a327b9b

koko57 dismissed mountiny’s stale review via a327b9b June 12, 2024 11:23

mountiny approved these changes Jun 12, 2024

View reviewed changes

mountiny merged commit 69dfe2a into Expensify:main Jun 12, 2024
16 checks passed

github-actions bot mentioned this pull request Jun 13, 2024

Deploy Checklist: New Expensify 2024-06-13 #43655

Closed

64 tasks

lanitochka17 mentioned this pull request Jun 13, 2024

Wallet - Wallet cannot be enabled after Onfido identify #43709

Closed

6 tasks

hoangzinh reviewed Jul 19, 2024

View reviewed changes

hoangzinh mentioned this pull request Jul 19, 2024

[HOLD for payment 2024-07-17] Wallet - Error page overlaps with device status bar #44805

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/36648 wallet enablement flow connect steps #42589

Refactor/36648 wallet enablement flow connect steps #42589

koko57 commented May 24, 2024 •

edited by github-actions bot

Loading

DylanDylann commented Jun 10, 2024

koko57 commented Jun 10, 2024

koko57 commented Jun 10, 2024

mountiny left a comment

github-actions bot commented Jun 10, 2024

DylanDylann commented Jun 10, 2024

Pujan92 commented Jun 10, 2024

jamesdeanexpensify commented Jun 10, 2024

jamesdeanexpensify commented Jun 10, 2024

koko57 commented Jun 11, 2024

jamesdeanexpensify commented Jun 11, 2024

jamesdeanexpensify commented Jun 11, 2024

koko57 commented Jun 11, 2024

koko57 commented Jun 11, 2024

jamesdeanexpensify commented Jun 11, 2024

mountiny left a comment

OSBotify commented Jun 12, 2024

OSBotify commented Jun 14, 2024

hoangzinh Jul 19, 2024

Refactor/36648 wallet enablement flow connect steps #42589

Refactor/36648 wallet enablement flow connect steps #42589

Conversation

koko57 commented May 24, 2024 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

DylanDylann commented Jun 10, 2024

koko57 commented Jun 10, 2024

koko57 commented Jun 10, 2024

mountiny left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 10, 2024

DylanDylann commented Jun 10, 2024

Pujan92 commented Jun 10, 2024

jamesdeanexpensify commented Jun 10, 2024

jamesdeanexpensify commented Jun 10, 2024

koko57 commented Jun 11, 2024

jamesdeanexpensify commented Jun 11, 2024

jamesdeanexpensify commented Jun 11, 2024

koko57 commented Jun 11, 2024

koko57 commented Jun 11, 2024

jamesdeanexpensify commented Jun 11, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 12, 2024

OSBotify commented Jun 14, 2024

hoangzinh Jul 19, 2024

Choose a reason for hiding this comment

koko57 commented May 24, 2024 •

edited by github-actions bot

Loading