-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error above Submit button is delayed by a moment when sending invoice without merchant #43455
Fix error above Submit button is delayed by a moment when sending invoice without merchant #43455
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Native43455.Android.mp4Android: mWeb Chrome43455.mWeb-Chrome.mp4iOS: Native43455.iOS.moviOS: mWeb Safari43455.mWeb-Safari.movMacOS: Chrome / Safari43455.Web.mp4MacOS: Desktop43455.Desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@bernhardoj You'll need to run prettier |
Done |
@bernhardoj Could you resolve the conflicts? Thank you! |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bump @yuwenmemon
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.86-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.86-0 🚀
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.86-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.0-9 🚀
|
Details
The form error for invoice request is shown with a delay. This PR fix it.
Fixed Issues
$ #43184
PROPOSAL: #43184 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-06-11.at.12.39.51.mov
Android: mWeb Chrome
Screen.Recording.2024-06-11.at.12.42.08.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-06-11.at.12.39.20.mov
MacOS: Chrome / Safari
Screen.Recording.2024-06-11.at.12.38.21.mov
MacOS: Desktop
Screen.Recording.2024-06-11.at.12.38.41.mov