Add default/delete popover and supporting methods

[stitesExpensify]

Details

Adding the ability to set a default wallet account, and delete payment methods. The default functionality is hidden behind the wallet beta.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/169126

Tests

1. Make sure you have a gold wallet
2. Add a personal bank account to an account
3. Add a debit card to your account
4. Run this query to set up the account properly

update funds set additionalData='{"isBillingCard":false,"isP2PDebitCard":true}' where fundID=<INSERT ID>;

4. Make sure you can set both types of account to the default
5. Make sure you can delete both types of account and that the message makes sense
6. Add a paypal.me
7. Delete the paypal.me
8. On an account that is not on the wallet beta, select an account and make sure you do not see the "default" button

QA Steps

1. Make sure you have a gold wallet
2. Add a personal bank account to an account via the add payment method button on the payments page
3. Add a debit card to your account via the add payment method button on the payments page
4. Make sure you can set both types of account to the default
5. Make sure you can delete both types of account and that the message makes sense
6. Add a paypal.me
7. Make sure you can't set the paypal as default
8. Delete the paypal.me
9. On an account that is not on the wallet beta, select an account and make sure you do not see the "default" button

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[stitesExpensify]

Updated!

[shawnborton]

Looks great, thanks!

[stitesExpensify]

Chatted with Kevin and we want the "default" button behind the wallet beta.

[pecanoro]

What happens if this fails? We don't catch it like other cases? Maybe I am missing that part when following the flow

[stitesExpensify]

It looks like it would just fail. I will make a new issue to fix that as it looks like we don't return the call in NVP.set so none of our calls to that method have a failure case.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @marcaaron in version: 1.1.30-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mvtglobally]

@Julesssss @stitesExpensify @pecanoro @shawnborton How do we get Gold account? What is the way to enable different account wallet types ?

[stitesExpensify]

@kevinksullivan can we get applause a gold wallet? Or should this be internal QA?

[mvtglobally]

@stitesExpensify If you think in future we may need to validate different accounts on regular bases, we need to have QA access to such accounts somehow. If this is a one time test, you can validate internally if its faster

[kevinksullivan]

@stitesExpensify Let's go to internal QA for now. We will need to allow for some test creds to go through KYC once the Wallet is live and we want to test that flow, but I don't think that's worth developing prior before getting it on prod with our own QA first.

[stitesExpensify]

Cool, I'll test it this morning

[stitesExpensify]

If you think in future we may need to validate different accounts on regular bases, we need to have QA access to such accounts somehow

We will probably want to test this type of PR at some point, but for now it's under a beta :)

[stitesExpensify]

QA passed

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[PauloGasparSv]

Hi there,

I think this resulted in a bug issue #14524 where the "Make Default" and "Delete" popups were not being dismissed if another session deleted the same selected Payment Method.

Pretty sure this is a detail we missed as I didn't find any mention of it in the Design Doc.