Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-01-18 #7297

Closed
56 tasks done
OSBotify opened this issue Jan 18, 2022 · 18 comments
Closed
56 tasks done

Deploy Checklist: New Expensify 2022-01-18 #7297

OSBotify opened this issue Jan 18, 2022 · 18 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 18, 2022 •
edited by chiragsalian
Loading

Release Version: 1.1.31-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 18, 2022
@mvtglobally
Copy link

Starting QA

@stitesExpensify
Copy link
Contributor

Checking off #4437

@chiragsalian
Copy link
Contributor

Hows QA going along @mvtglobally? 🙂

@mvtglobally
Copy link

@chiragsalian QA is almost done. I will be updating checkboxes in the next hr.

@mvtglobally
Copy link

#6882 is failing due to #7310
#7104 is failing due to
#7210 is failing due to #7320
#7271 is still repro #7271 (comment)
#7289 is failing with console error #7293. Can we check off?

@chiragsalian
Copy link
Contributor

#7289 is failing with console error #7293. Can we check off?

Yes, looks like its not breaking anything and there is a GH issue recorded. So yeah feel free to check it off.

@chiragsalian
Copy link
Contributor

chiragsalian commented Jan 19, 2022 •
edited
Loading 

#7104 is failing due to

Why was #7104 failing? I don't see any comment here or on the issue.

It also looks like #7310 was closed. Can you retest #6882 or ask the author for clarification if there is some confusion there?

@chiragsalian
Copy link
Contributor

chiragsalian commented Jan 19, 2022 •
edited
Loading

  • Looks like #6882 was retested.
  • Could you explain where #7104 was failing.
  • I think #7320 is a non issue (explained here) so #7210 can be tested again
  • #7271 looks legit. Not a blocker though so we can ignore that for now as we work on other stuff.
  • I'll check #7289 (my reasoning posted here).

@mvtglobally
Copy link

Checking off #7271 & #7210
#7104 has an issue with leading zeroes. I was waiting for the team to confirm. Will update in another min

@mvtglobally
Copy link

mvtglobally commented Jan 20, 2022 •
edited
Loading

@chiragsalian Updated the comment. We are not sure if this is expected or no. This is the last open PR on the checklist and once confirmed, we should be ok to deploy.
#7104 (comment)

@mvtglobally
Copy link

checking of #7104 based on the #7104 (comment)

@chiragsalian
Copy link
Contributor

chiragsalian commented Jan 20, 2022 •
edited
Loading

Just addressed #7321 and i've asked @kavimuru to retest.
The PR that resolved the issue is #7339. So once it's tested we can check off both and I'll be clear to deploy.

@mvtglobally
Copy link

Checking off #7339. It is pass

@chiragsalian
Copy link
Contributor

:shipit:

@OSBotify OSBotify reopened this Jan 20, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@chiragsalian
Copy link
Contributor

:shipit:

@OSBotify OSBotify reopened this Jan 20, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@chiragsalian
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chiragsalian @applausebot @stitesExpensify @mvtglobally @OSBotify