fix workspace save btn float issue #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
chiragsalian and
rushatgabhane
and removed request for
a team
|
@thesahindia could you please update the QA steps, and add iOS video/screenshot? Appreciate it! |
|
Ah I didn't press the update button 🤦🏻♂️. Updated now. |
rushatgabhane
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Sorry this one got buried in the notifications 😅
LGTM! 🎉 @chiragsalian
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
56 tasks
|
🚀 Deployed to staging by @chiragsalian in version: 1.1.30-4 🚀
|
|
🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed workspace general settings save button float issue
Fixed Issues
$ #7140
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android