-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No wrap style #7339
No wrap style #7339
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but not explicitly approving because I haven't tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey, I am here. Sorry for the delay. If you want it to look like the old way then we should use numberOfLines={2} then it will start clipping from second line. |
Does it look different this way? I'm not seeing it |
I think the style change alone is fine for now. Plus i feel this keeps the UI consistent with mobile and web since i see a single line on them as well. |
Previously, HeaderView was used to wrap to two lines and then clipped with an ellipsis. You can see that on PROD. |
Gotcha. Well since we only see one line on web, I think this is fine 👍 |
No wrap style (cherry picked from commit b069acd)
🚀 Cherry-picked to staging by @stitesExpensify in version: 1.1.31-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀
|
Details
Fixed Issues
$ #7321
Tests / QA
Tested the same steps mentioned on #7321 and confirmed the image has ellipses on mWeb.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android