Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No wrap style #7339

Merged
merged 1 commit into from
Jan 20, 2022
Merged

No wrap style #7339

merged 1 commit into from
Jan 20, 2022

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Jan 20, 2022

Details

Fixed Issues

$ #7321

Tests / QA

Tested the same steps mentioned on #7321 and confirmed the image has ellipses on mWeb.
image

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@chiragsalian chiragsalian marked this pull request as ready for review January 20, 2022 20:10
@chiragsalian chiragsalian requested a review from a team as a code owner January 20, 2022 20:10
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team January 20, 2022 20:11
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not explicitly approving because I haven't tested.

Copy link
Contributor

@stitesExpensify stitesExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parasharrajat
Copy link
Member

Hey, I am here. Sorry for the delay.

If you want it to look like the old way then we should use numberOfLines={2} then it will start clipping from second line.

@stitesExpensify
Copy link
Contributor

Does it look different this way? I'm not seeing it

@chiragsalian
Copy link
Contributor Author

I think the style change alone is fine for now. Plus i feel this keeps the UI consistent with mobile and web since i see a single line on them as well.

@parasharrajat
Copy link
Member

Previously, HeaderView was used to wrap to two lines and then clipped with an ellipsis. You can see that on PROD.

@stitesExpensify
Copy link
Contributor

Gotcha. Well since we only see one line on web, I think this is fine 👍

@stitesExpensify stitesExpensify merged commit b069acd into main Jan 20, 2022
@stitesExpensify stitesExpensify deleted the chirag-adding-noWrap-style branch January 20, 2022 21:11
OSBotify pushed a commit that referenced this pull request Jan 20, 2022
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @stitesExpensify in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants