Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show "Message <user>" button when seeing your own profile #7228

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Do not show "Message <user>" button when seeing your own profile #7228

merged 1 commit into from
Jan 18, 2022

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Jan 14, 2022 •
edited
Loading

Details

Prevents showing the Message <user> button when trying to message yourself.

Fixed Issues

$ #7203

Tests

  1. Start a chat with a user.
  2. Click on your avatar in the chat and verify that no Message <user> button is visible.
  3. Now click on another user's avatar and verify that the Message <user> button is visible and clicking it opens the chat with that user.
  • Verify that no errors appear in the JS console

QA Steps

Steps above.

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Jan 14, 2022
@luacmartins luacmartins changed the title Fix message button error Do not show "Message <user>" button when seeing your own profile Jan 14, 2022
@luacmartins luacmartins marked this pull request as ready for review January 14, 2022 18:20
@luacmartins luacmartins requested a review from a team as a code owner January 14, 2022 18:20
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team January 14, 2022 18:20
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@luacmartins
Copy link
Contributor Author

Reassigning since Jasper is on school leave.

@luacmartins luacmartins requested review from a team and removed request for jasperhuangg January 17, 2022 16:57
@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team January 17, 2022 16:57
marcochavezf
marcochavezf approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@marcochavezf marcochavezf merged commit 54580da into main Jan 18, 2022
@marcochavezf marcochavezf deleted the cmartins-fixMessageButton branch January 18, 2022 17:37
OSBotify pushed a commit that referenced this pull request Jan 18, 2022
@marcochavezf @OSBotify
Merge pull request #7228 from Expensify/cmartins-fixMessageButton
073291e 
Do not show "Message <user>" button when seeing your own profile

(cherry picked from commit 54580da)
This was referenced Jan 18, 2022
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @marcochavezf in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jan 19, 2022
Closed
56 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
@s77rt s77rt mentioned this pull request May 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcochavezf marcochavezf marcochavezf approved these changes

Assignees

@luacmartins luacmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @marcochavezf