Fix Plaid modal by updating to latest version of react-native-plaid-link-sdk / resolve stashed token issue

[marcaaron]

Details

cc @Julesssss @luacmartins

Fixed Issues

$ #4959

Tests AND QA Steps

1. Start with a non-public domain account that has not yet set up a workspace or bank account
2. Create a new workspace by tapping on the green FAB button
3. Navigate to /bank-account by selecting the workspace and tapping the "Get Started" button
4. Tap button to add account via Plaid (Note: This step may take time to complete)
5. Enter test credentials user_good pass_good
6. Press "Continue"
7. Verify that the account selection dropdown appears

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[marcaaron]

Note: These changes are not related, but I noticed my test builds were showing the metrics despite being set to CAPTURE_METRICS=false in .env file and decided to fix this here.

[marcaaron]

This should be ready for review now

[marcaaron]

So... actually.... I'm still experiencing issues on Android on debug builds. Building for release works fine. @yuwenmemon lmk if you need help figuring out how to do this (there is a SO post somewhere).

[marcaaron]

Hmm actually it's worse than I thought and also happens in release but inconsistently.
Gonna put this back into draft and file see if I can get some help from Plaid.

[marcaaron]

Ok, this is ready for a review now.

There is still an issue with Plaid that causes the UI to load very slowly and basically makes it seem broken on dev, but I got to the bottom of the worst of the Android issues. Plaid is aware of the issue and working on it - it's related to their web bundle that is getting served via a WebView. But not sure what we can do about this from our end at the moment.

A more extreme idea is to create our own native module, but Plaid is also working on that for react-native so it seems like we should #do-nothing and wait for improvements.

[luacmartins]

Thanks for working on this @marcaaron! The Plaid modal is opening on Android now! I still see the following error when confirming the account though. Is that part of the issue that Plaid is trying to fix?

Invariant Violation: No callback found with cbID 17868 and callID 8934 for  PlaidAndroid.startLinkActivityForResult - most likely the callback was already invoked. Args: '[{"publicToken":"public-sandbox-53eb79a5-bfdd-4aa5-80c7-e45fa0695ed0","metadata":{"metadataJson":"{\"institution\":{\"name\":\"Chase\",\"institution_id\":\"ins_3\"},\"account\":{\"id\":null,\"name\":null,\"type\":nul...(truncated)...","linkSessionId":"0f3901e3-83f7-48b3-8191-e12c818c3247","institution":{"name":"Chase","id":"ins_3"},"accounts":[{"subtype":"checking","type":"depository","mask":"0000","name":"Plaid Checking","id":"jq958bm9a6s5Errllw8AtW3pPd35lWFy9ez3n"},{"subtype":"savings","type":"depository","mask":"1111","name":"Plaid Saving","id":"7Mxb9p5xeNFZ3zzjjDwEhxvDRVv1gxCN3qAGv"}]}}]', js engine: hermes

[marcaaron]

Can you make sure you have the latest commits? I can try to test again tomorrow but that error should now be resolved.

…

On Wed, Sep 1, 2021, 3:15 PM Carlos Martins ***@***.***> wrote: ***@***.**** commented on this pull request. Thanks for working on this @marc <https://github.com/marc>! The Plaid modal is opening on Android now! I still see the following error when confirming the account though. Is that part of the issue that Plaid is trying to fix? Invariant Violation: No callback found with cbID 17868 and callID 8934 for PlaidAndroid.startLinkActivityForResult - most likely the callback was already invoked. Args: '[{"publicToken":"public-sandbox-53eb79a5-bfdd-4aa5-80c7-e45fa0695ed0","metadata":{"metadataJson":"{\"institution\":{\"name\":\"Chase\",\"institution_id\":\"ins_3\"},\"account\":{\"id\":null,\"name\":null,\"type\":nul...(truncated)...","linkSessionId":"0f3901e3-83f7-48b3-8191-e12c818c3247","institution":{"name":"Chase","id":"ins_3"},"accounts":[{"subtype":"checking","type":"depository","mask":"0000","name":"Plaid Checking","id":"jq958bm9a6s5Errllw8AtW3pPd35lWFy9ez3n"},{"subtype":"savings","type":"depository","mask":"1111","name":"Plaid Saving","id":"7Mxb9p5xeNFZ3zzjjDwEhxvDRVv1gxCN3qAGv"}]}}]', js engine: hermes — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#4962 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3RC72Y7HNPMESAA2MNWCDT73F2JANCNFSM5DFDMLBQ> .

[luacmartins]

I'll try testing again tomorrow!

[Julesssss]

Working flawlessly for me on Android devices, thanks for looking into this. Personally, I've never found the slow loading time to be that problematic, but nice to hear Plaid is looking into improvements anyway.

[luacmartins]

Just tested again and it's working!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[marcaaron]

Personally, I've never found the slow loading time to be that problematic, but nice to hear Plaid is looking into improvements anyway.

Oh nice! It could be related to my device or internet now that I think about it. Glad to hear it's only slow for me!

[marcaaron]

@Julesssss @luacmartins thanks for testing! 🙇

[OSBotify]

🚀 Deployed to staging by @luacmartins in version: 1.0.92-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[isagoico]

@marcaaron @luacmartins Hello! We're currently unable to test this in iOS and Android since we can't navigate to a specific URL in-app This might have to be tested internally or if you know another method please let us know.

[marcaaron]

Same answer as here -> #5029 (comment) but please let us know here if that's not going to work! Thanks!

[isagoico]

This issue is failing this PR #5075

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅