-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Plaid Link for web / Fix logic breaking Plaid flow on web #5029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, worked for me on web.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.0.92-1 🚀
|
@marcaaron Hello! Can we test this by navigating to |
I think this requirement can be worked around by using a deep link (sent via gmail) and then opening in https://staging.new.expensify.com/bank-account If it doesn't work let us know and we'll find another way to test |
@marcaaron It worked on Android but not on iOS. On iOS it opens mWeb directly |
I'll look into that. I think I know why. |
This issue is failing this PR #5075 |
Let me know if I should open a separate issue for this. |
Can you try |
This worked but this issue was also reproducible there #5075 |
Ok cool thanks! Glad the deep link worked. I'm unsure what could be causing this issue, but asking for help now and re-testing on dev to make sure things still work locally. |
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀
|
cc @aldo-expensify this should fix the bug you ran into on
main
Details
We discovered while testing Plaid Link on the web side that the flow is broken after the changes here. Taking this opportunity to fix and update Plaid.
Fixed Issues (Comment)
$ #4785 (comment)
Tests AND QA Steps
/bank-account
by selecting the workspace and tapping the "Get Started" buttonuser_good
pass_good
Tested On
Screenshots
Web
Mobile Web
Skip because they use the same code as web + there is no UI change.
Desktop
Skip because they use the same code as web + there is no UI change.
iOS
Android