Use small icon in tabs #50324

ShridharGoel · 2024-10-07T07:20:03Z

Details

Use small icon in tabs of create expense.

Fixed Issues

$ #49577
PROPOSAL: #49577 (comment)

Tests

Open the submit expense flow.
The tab icons' size should be 16x16.

QA Steps

Open the submit expense flow.
The tab icons' size should be 16x16.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-07T07:20:08Z

@dubielzyk-expensify @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2024-10-07T07:32:03Z

Will upload mobile screenshots soon.

dubielzyk-expensify · 2024-10-08T03:19:31Z

Thanks. Let me know and I'll do a review 👍

thesahindia · 2024-10-08T15:36:15Z

Will upload mobile screenshots soon.

Bump @ShridharGoel

thesahindia · 2024-10-11T17:30:52Z

Bump @ShridharGoel

ShridharGoel · 2024-10-13T20:16:11Z

@thesahindia Only 2 screenshots are pending, because I'm facing some issues on Android mweb and iOS native. Will add them once I'm able to use the app on these.

ShridharGoel · 2024-10-13T20:19:44Z

If possible, kindly go ahead with the C+ review in the meantime.

thesahindia · 2024-10-14T17:30:07Z

@thesahindia Only 2 screenshots are pending, because I'm facing some issues on Android mweb and iOS native. Will add them once I'm able to use the app on these.

What issue are you facing? Could you ask for help in the Slack channel?

thesahindia · 2024-10-14T17:30:18Z

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

thesahindia · 2024-10-14T17:31:45Z

@dubielzyk-expensify, I have attached the screenshots in the comment above.

thesahindia

Looks good!

thesahindia · 2024-10-14T17:33:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

dubielzyk-expensify · 2024-10-15T04:36:14Z

The icon size is looking good but looking at the mocks in Figma vs the branch I've noticed a few discrepancies:

In Figma the height of the button/pill is 40px. On the branch it's 42px
In Figma the text uses Label (font size 13px) and on the branch it seems to be body (font size 15px).

Once we fix that, we'll be good to go. cc @Expensify/design team as well :)

shawnborton · 2024-10-15T06:53:18Z

Good catches, I agree with Jon's feedback. Also, just want to confirm that at this button size (40px tall) we are using a 4px gap between the icon and label?

thesahindia · 2024-10-15T13:39:42Z

Once we fix that, we'll be good to go.

cc: @ShridharGoel

dannymcclain · 2024-10-15T13:42:59Z

Also, just want to confirm that at this button size (40px tall) we are using a 4px gap between the icon and label?

@shawnborton In Figma we have the gap between text and icon set to 8px— do we need to update that to make it match the button styles more closely?

shawnborton · 2024-10-15T15:04:24Z

I would say yeah - I don't think there's a good reason to have the styles slightly differ like that, I like making them even more consistent. What do you think?

jasperhuangg · 2024-10-15T16:11:18Z

Code looks good to me although we should hold on design to see if these will need to change.

dannymcclain · 2024-10-15T16:23:34Z

Works for me! I'll make sure I update the Figma component. And just for clarity: we do want the gap between the icon and text to be 4px.

shawnborton · 2024-10-15T16:30:06Z

Sweet, let's get confirmation from @ShridharGoel on that

ShridharGoel · 2024-10-15T16:47:33Z

Thanks for the confirmation, I'll update it accordingly.

ShridharGoel · 2024-10-16T20:05:19Z

Does this look good? Doesn't the gap between icon and text feel a bit less?

dannymcclain · 2024-10-16T20:13:41Z

That looks correct to me based on the new styles.

@Expensify/design if we feel like it's too tight, we can always update the gap for the tabs and medium buttons to be 8px instead of 4px. I think both look good so I don't know that I have a strong argument for one vs. the other.

dubielzyk-expensify · 2024-10-17T02:31:57Z

I think the screenshot above is too tight. If that's 4, then I'd vote 8.

shawnborton · 2024-10-28T08:56:29Z

Feels pretty good to me from a design perspective 👍

shawnborton · 2024-10-29T15:17:53Z

Sounds good, let's go ahead and get this into final review!

thesahindia · 2024-10-29T15:41:07Z

@ShridharGoel, you still haven't attached all the screenshots.

thesahindia

Tested well!

thesahindia · 2024-10-30T10:16:59Z

@jasperhuangg, could you please re run the checks?

jasperhuangg · 2024-10-30T16:40:00Z

@ShridharGoel please fix conflicts!

thesahindia · 2024-10-30T21:18:30Z

@ShridharGoel, you still haven't attached all the screenshots.

Bump @ShridharGoel

jasperhuangg

Please add screenshots @ShridharGoel

ShridharGoel · 2024-11-01T03:32:06Z

Just iOS native screenshot is pending, which is because there's some issue with that build on my setup. Will try it again.

shawnborton · 2024-11-01T07:28:26Z

Sounds good, let's try to get this one wrapped up today if we can!

thesahindia · 2024-11-04T17:45:24Z

Just iOS native screenshot is pending, which is because there's some issue with that build on my setup. Will try it again.

What's the issue? Could you ask for help in the Slack channel?

ShridharGoel · 2024-11-04T20:06:12Z

Found a thread on Slack which talks about the same issue which I was getting: https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1704303546736909?thread_ts=1704303546.736909&cid=C01GTK53T8Q Going to try these steps.

thesahindia · 2024-11-06T17:35:32Z

Going to try these steps.

Any update @ShridharGoel?

ShridharGoel · 2024-11-07T12:21:12Z

Apologies for the delay, this will be done within 2 days.

shawnborton · 2024-11-08T14:30:59Z

Any updates on this one today? We're close, let's get it over the finish line!

ShridharGoel · 2024-11-08T15:30:41Z

Added the iOS native screenshot, that was the only pending thing.

jasperhuangg · 2024-11-08T18:16:06Z

Thanks!

OSBotify · 2024-11-08T18:26:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-11T18:39:05Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-13T00:42:34Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

ShridharGoel requested a review from a team as a code owner October 7, 2024 07:20

melvin-bot bot requested review from dubielzyk-expensify and thesahindia and removed request for a team October 7, 2024 07:20

thesahindia approved these changes Oct 14, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg October 14, 2024 17:32

jasperhuangg previously approved these changes Oct 15, 2024

View reviewed changes

ShridharGoel requested a review from thesahindia October 29, 2024 13:39

thesahindia approved these changes Oct 30, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg October 30, 2024 10:15

jasperhuangg previously approved these changes Oct 30, 2024

View reviewed changes

Merge branch 'main' into patch-20

b9bf021

ShridharGoel dismissed jasperhuangg’s stale review via b9bf021 October 30, 2024 19:59

ShridharGoel requested a review from jasperhuangg October 30, 2024 19:59

jasperhuangg requested changes Oct 31, 2024

View reviewed changes

jasperhuangg approved these changes Nov 8, 2024

View reviewed changes

jasperhuangg merged commit 1fc5ae3 into Expensify:main Nov 8, 2024
20 checks passed

github-actions bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-21] Deploy Checklist: New Expensify 2024-11-11 #52320

Closed

95 tasks

melvin-bot bot mentioned this pull request Nov 13, 2024

[HOLD for payment 2024-11-20] [$250] Tab bar in create expense flows uses incorrect icon size #49577

Closed

6 tasks

Use small icon in tabs #50324

Use small icon in tabs #50324

Conversation

ShridharGoel commented Oct 7, 2024 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 7, 2024

ShridharGoel commented Oct 7, 2024

dubielzyk-expensify commented Oct 8, 2024

thesahindia commented Oct 8, 2024

thesahindia commented Oct 11, 2024

ShridharGoel commented Oct 13, 2024

ShridharGoel commented Oct 13, 2024 via email

thesahindia commented Oct 14, 2024

thesahindia commented Oct 14, 2024 • edited Loading

Screenshots/Videos

thesahindia commented Oct 14, 2024

thesahindia left a comment

Choose a reason for hiding this comment

thesahindia commented Oct 14, 2024

Reviewer Checklist

dubielzyk-expensify commented Oct 15, 2024

shawnborton commented Oct 15, 2024

thesahindia commented Oct 15, 2024

dannymcclain commented Oct 15, 2024

shawnborton commented Oct 15, 2024

jasperhuangg commented Oct 15, 2024

dannymcclain commented Oct 15, 2024

shawnborton commented Oct 15, 2024

ShridharGoel commented Oct 15, 2024 via email

ShridharGoel commented Oct 16, 2024

dannymcclain commented Oct 16, 2024

dubielzyk-expensify commented Oct 17, 2024

shawnborton commented Oct 28, 2024

shawnborton commented Oct 29, 2024

thesahindia commented Oct 29, 2024

thesahindia left a comment

Choose a reason for hiding this comment

thesahindia commented Oct 30, 2024 • edited Loading

jasperhuangg commented Oct 30, 2024

thesahindia commented Oct 30, 2024

jasperhuangg left a comment

Choose a reason for hiding this comment

ShridharGoel commented Nov 1, 2024

shawnborton commented Nov 1, 2024

thesahindia commented Nov 4, 2024

ShridharGoel commented Nov 4, 2024 via email

thesahindia commented Nov 6, 2024

ShridharGoel commented Nov 7, 2024 via email

shawnborton commented Nov 8, 2024

ShridharGoel commented Nov 8, 2024 • edited Loading

jasperhuangg commented Nov 8, 2024

OSBotify commented Nov 8, 2024

github-actions bot commented Nov 11, 2024

github-actions bot commented Nov 13, 2024

ShridharGoel commented Oct 7, 2024 •

edited

Loading

thesahindia commented Oct 14, 2024 •

edited

Loading

thesahindia commented Oct 30, 2024 •

edited

Loading

ShridharGoel commented Nov 8, 2024 •

edited

Loading