-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] Merge the attendee tracking changes, but block use #51329
Conversation
Co-authored-by: Błażej Kustra <46095609+blazejkustra@users.noreply.github.com>
* main: (66 commits) Uploading images for a Help Site Update es.ts Update en.ts Update version to 9.0.53-0 e2e: unify test metrics naming Revert "Revert "Search suffix tree implementation"" lint remove unnecessary code blur when modal focus trap is activated fix double focus trap Add files via upload added MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK fix: prepare bootsplash for hybrid update test with request check add UpdateComment test update requestMatcher by request.command usage rename matcher fn to be more descriptive use constant instead of string add filterUpdateCommentRequest and filterRequestByCommand utils fix: update patch ... # Conflicts: # src/libs/OptionsListUtils.ts
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
As discussed, the useOnyx migration can be done when we continue development of this unused feature. So I am ignoring the remaining 2 ESLint errors. |
I'll go ahead and merge this since it doesn't pick up more conflicts. @carlosmiceli I see you are listed as a reviewer. If you do want to review it and find anything that needs to be changed, those can be done in a follow-up PR. |
@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.54-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
Details
This PR simply merges the
feature-attendeeTracking
branch. We have tested individual changes when merging individual PRs to this branch.This project has been put on hold due to project prioritisation changes. Keeping this feature branch aligned with
main
is already complex due to conflicts. We are simply blocking the future from use here.The feature cannot be fully tested yet as we need to complete these tasks once the project is picked back up at a later date. Two ESLint issues remain (
'withOnyx' is deprecated
), but we will fix these once the feature is back in development.Fixed Issues
$ #51335
Tests
Attendees feature should not appear
Offline tests
Attendees feature should not appear
QA Steps
Attendees feature should not appear
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps./** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)Screenshots/Videos
Disabled
Working prior to disabling the feature: