Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Merge the attendee tracking changes, but block use #51329

Merged
merged 69 commits into from
Oct 24, 2024

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Oct 23, 2024

Details

This PR simply merges the feature-attendeeTracking branch. We have tested individual changes when merging individual PRs to this branch.

This project has been put on hold due to project prioritisation changes. Keeping this feature branch aligned with main is already complex due to conflicts. We are simply blocking the future from use here.

The feature cannot be fully tested yet as we need to complete these tasks once the project is picked back up at a later date. Two ESLint issues remain ('withOnyx' is deprecated), but we will fix these once the feature is back in development.

Fixed Issues

$ #51335

Tests

Attendees feature should not appear

  • Create an expense
  • Select a workspace as the recipient
  • Tap 'Show more' to view additional expense fields
  • Attendees SHOULD NOT appear
  • Finish submitting the expense
  • Open the expense details
  • The Attendees item row SHOULD NOT appear

Offline tests

Attendees feature should not appear

  • Create an expense
  • Select a workspace as the recipient
  • Tap 'Show more' to view additional expense fields
  • Attendees SHOULD NOT appear
  • Finish submitting the expense
  • Open the expense details
  • The Attendees item row SHOULD NOT appear

QA Steps

Attendees feature should not appear

  • Create an expense
  • Select a workspace as the recipient
  • Tap 'Show more' to view additional expense fields
  • Attendees SHOULD NOT appear
  • Finish submitting the expense
  • Open the expense details
  • The Attendees item row SHOULD NOT appear

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I verified that similar component doesn't exist in the codebase
  • I verified that all props are defined accurately and each prop has a /** comment above it */
  • I verified that each file is named correctly
  • I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • I verified that the only data being stored in component state is data necessary for rendering and nothing else
  • In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • I verified that all JSX used for rendering exists in the render method
  • I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Disabled
Screenshot 2024-10-23 at 13 18 31
Screenshot 2024-10-23 at 13 25 34

Working prior to disabling the feature:
Screenshot 2024-10-23 at 13 16 00

@melvin-bot melvin-bot bot requested a review from tgolen October 23, 2024 17:41
Copy link

melvin-bot bot commented Oct 23, 2024

@tgolen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tgolen
tgolen previously approved these changes Oct 23, 2024
* main: (66 commits)
  Uploading images for a Help Site
  Update es.ts
  Update en.ts
  Update version to 9.0.53-0
  e2e: unify test metrics naming
  Revert "Revert "Search suffix tree implementation""
  lint
  remove unnecessary code
  blur when modal focus trap is activated
  fix double focus trap
  Add files via upload
  added MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK
  fix: prepare bootsplash for hybrid
  update test with request check
  add UpdateComment test
  update requestMatcher by request.command usage
  rename matcher fn to be more descriptive
  use constant instead of string
  add filterUpdateCommentRequest and filterRequestByCommand utils
  fix: update patch
  ...

# Conflicts:
#	src/libs/OptionsListUtils.ts
@melvin-bot melvin-bot bot requested a review from MonilBhavsar October 24, 2024 10:33

This comment was marked as off-topic.

@Julesssss Julesssss requested review from fedirjh and removed request for MonilBhavsar October 24, 2024 11:01
@melvin-bot melvin-bot bot requested a review from carlosmiceli October 24, 2024 12:38

This comment was marked as off-topic.

@Julesssss
Copy link
Contributor Author

As discussed, the useOnyx migration can be done when we continue development of this unused feature. So I am ignoring the remaining 2 ESLint errors.

@tgolen
Copy link
Contributor

tgolen commented Oct 24, 2024

I'll go ahead and merge this since it doesn't pick up more conflicts.

@carlosmiceli I see you are listed as a reviewer. If you do want to review it and find anything that needs to be changed, those can be done in a follow-up PR.

@tgolen tgolen merged commit 642fd97 into main Oct 24, 2024
16 of 17 checks passed
@tgolen tgolen deleted the feature-attendeeTracking branch October 24, 2024 14:17
Copy link

melvin-bot bot commented Oct 24, 2024

@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Oct 24, 2024
@Julesssss
Copy link
Contributor Author

Not an emergency, see here for context.

@tgolen we can ignore the 2nd and 3rd PR review assignments, they occurred after Fedi's 2nd and 3rd review for some reason

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.54-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄 skipped 🚫

Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄 skipped 🚫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants