bump Onyx to v2.0.79 #52007

huult · 2024-11-05T03:51:02Z

Details

Fixed Issues

$ #49493
PROPOSAL: #49493 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open new dot
Log in and navigate to the "DM" (Direct Messages) section.
Submit the first expense by filling out the required fields and clicking submit.
Submit the second expense by repeating the process.
Navigate to the "Search" feature within the application.
Click on the "Outstanding" section to view submitted expenses.
Click "View" next to one of the submitted expenses to open its details.
Click on the "Amount" section to edit the expense.
Change the currency to your desired one and save the changes.
Dismiss any open right-hand panel (RHP).
Verify that the total amount reflects the updated currency correctly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-05.at.10.37.46.mp4

Android: mWeb Chrome

Screen.Recording.2024-11-05.at.10.39.17.mp4

iOS: Native

Screen.Recording.2024-11-05.at.10.42.27.mp4

iOS: mWeb Safari

Screen.Recording.2024-11-05.at.10.44.15.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-11-05.at.10.31.09.mp4

MacOS: Desktop

Screen.Recording.2024-11-05.at.10.34.19.mp4

melvin-bot · 2024-11-05T03:51:07Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2024-11-05T04:53:45Z

@eh2077 you can ignore this PR. Another C+ was assigned just because I was removed from Github.
I will be OOO soon but I can take care of this.

situchan · 2024-11-05T06:20:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

situchan

Looks good but let's hold this for #51942 so that we won't take responsible for potential regressions caused by other Onyx changes between 2.0.74-2.0.78

…v-2.0.79

huult · 2024-11-13T12:28:24Z

@situchan @eh2077 #51942 has been deployed to production. I think we can merge this pull request.

marcochavezf

Thanks!

marcochavezf · 2024-11-13T20:09:48Z

Oops the package files were updated in main

…v-2.0.79

huult · 2024-11-13T23:42:35Z

@marcochavezf I resolved the conflict. We had a version conflict with another package. React-native-onyx on main branch is still on version 2.0.78, we can merge this branch to bump it to 2.0.79.

App/package.json

Line 155 in a20cfef

"react-native-onyx": "2.0.78",

huult · 2024-11-13T23:48:49Z

@marcochavezf The TypeScript checks failed due to changes from the latest main branch

App/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx

Line 76 in a20cfef

    
           onBackButtonPress={() => TwoFactorAuthActions.quitAndNavigateBack(route.params.forwardTo?.includes(READ_COMMANDS.CONNECT_POLICY_TO_XERO) ? '' : backTo)}

melvin-bot · 2024-11-14T00:10:20Z

@marcochavezf looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

marcochavezf · 2024-11-14T00:10:59Z

Removing emergency label per #52007 (comment), the ts/eslint check errors are unrelated to this PR

github-actions · 2024-11-14T00:53:02Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2024-11-15T14:16:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

bump Onyx to v2.0.79

d4882b6

huult requested a review from a team as a code owner November 5, 2024 03:51

melvin-bot bot requested a review from eh2077 November 5, 2024 03:51

melvin-bot bot removed the request for review from a team November 5, 2024 03:51

huult mentioned this pull request Nov 5, 2024

[HOLD for payment 2024-11-22] [HOLD FOR #52007] [$250] Search - Total amount does not auto update after changing the expense currency #49493

Open

6 tasks

situchan approved these changes Nov 5, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 49493-bump-onyx-to-…

dec0737

…v-2.0.79

eh2077 approved these changes Nov 13, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf November 13, 2024 14:52

marcochavezf previously approved these changes Nov 13, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 49493-bump-onyx-to-…

5edbc41

…v-2.0.79

huult dismissed marcochavezf’s stale review via 5edbc41 November 13, 2024 23:39

marcochavezf approved these changes Nov 13, 2024

View reviewed changes

marcochavezf merged commit 826e8eb into Expensify:main Nov 14, 2024
17 of 19 checks passed

melvin-bot bot added the Emergency label Nov 14, 2024

marcochavezf removed the Emergency label Nov 14, 2024

github-actions bot mentioned this pull request Nov 14, 2024

Deploy Checklist: New Expensify 2024-11-14 #52512

Closed

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump Onyx to v2.0.79 #52007

bump Onyx to v2.0.79 #52007

huult commented Nov 5, 2024

melvin-bot bot commented Nov 5, 2024

situchan commented Nov 5, 2024

situchan commented Nov 5, 2024 •

edited

Loading

situchan left a comment

huult commented Nov 13, 2024

marcochavezf left a comment

marcochavezf commented Nov 13, 2024

huult commented Nov 13, 2024

huult commented Nov 13, 2024

melvin-bot bot commented Nov 14, 2024

marcochavezf commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

bump Onyx to v2.0.79 #52007

bump Onyx to v2.0.79 #52007

Conversation

huult commented Nov 5, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 5, 2024

situchan commented Nov 5, 2024

situchan commented Nov 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

huult commented Nov 13, 2024

marcochavezf left a comment

Choose a reason for hiding this comment

marcochavezf commented Nov 13, 2024

huult commented Nov 13, 2024

huult commented Nov 13, 2024

melvin-bot bot commented Nov 14, 2024

marcochavezf commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

situchan commented Nov 5, 2024 •

edited

Loading