Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fundlist instead of cardlist for payment methods #5212

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

stitesExpensify
Copy link
Contributor

Details

When I initially implemented this I used the cardList instead of the fundList. cardList is used for scraped/imported cards, we actually want billing cards which is fundList

Fixed Issues

$ #5205

Tests

  1. Log into an account with a billing card and an expensify card
  2. Go to settings->payments and make sure you see the debit card, but not the expensify card

QA Steps

  1. Log into an account with a billing card and an expensify card
  2. Go to settings->payments and make sure you see the debit card, but not the expensify card

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

2021-09-10_17-35-08

@stitesExpensify stitesExpensify requested a review from a team as a code owner September 10, 2021 23:38
@stitesExpensify stitesExpensify self-assigned this Sep 10, 2021
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team September 10, 2021 23:38
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Beamanator Beamanator merged commit 38c70a2 into main Sep 13, 2021
@Beamanator Beamanator deleted the stites-changeCardListToFundList branch September 13, 2021 13:39
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.0.97-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@stitesExpensify I tested this with our account tester@applausecard.expensifail.com and I think it was a pass 🤔 it's the only account we have with an active expensify card. Not sure if you want to double check on your side

image
image

@stitesExpensify
Copy link
Contributor Author

Looks like a pass to me! Thanks for double checking 😄

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants