-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update payments page to use Expensify logo for Expensify Card #5216
Conversation
Should I review this? Asking because it's WIP |
Not yet! I guess PR's automatically get assigned our in this repo, even though I hadn't assigned puller bear yet. I'll ping you when it's no longer WIP. |
@iwiznia it's ready for your review now! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@puneetlath @iwiznia what account can we use to validate this PR? |
You can use any account that has an Expensify Card assigned to it and log into new.expensify.com and view the Payments page. |
@puneetlath I checked on our testing account that has an active Expensify Card and it's not visible in the payments Page. |
Ah, it looks like this PR made my PR obsolete: #5212 |
Oh, how should we proceed here then? Should I create a separate issue about the card not appearing? |
We can go ahead and let this go to production, it won't hurt anything. And I'll submit a follow-up PR to clean up the logic given that the change made here is no longer needed. |
Details
Updates the icon used in the payments section of the app for the Expensify Card. For other cards, we're using the logo of the issuer. In this case, since Expensify is the issuer, the logo being used is the Expensify logo.
Fixed Issues
$ #5215
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android