Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payments page to use Expensify logo for Expensify Card #5216

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Sep 12, 2021

Details

Updates the icon used in the payments section of the app for the Expensify Card. For other cards, we're using the logo of the issuer. In this case, since Expensify is the issuer, the logo being used is the Expensify logo.

Fixed Issues

$ #5215

Tests

  1. Go to Settings > Payments in an account that has an Expensify Card assigned and is also importing other cards
  2. Look at the list of Payment methods
  3. Make sure the Expensify Card is showing the Expensify logo
  4. Make sure all other logos are showing as expected

QA Steps

  1. Go to Settings > Payments in an account that has an Expensify Card assigned and is also importing other cards
  2. Look at the list of Payment methods
  3. Make sure the Expensify Card is showing the Expensify logo
  4. Make sure all other logos are showing as expected

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

Screen Shot 2021-09-14 at 12 49 06 PM

Android

image

@puneetlath puneetlath self-assigned this Sep 12, 2021
@puneetlath puneetlath requested a review from a team as a code owner September 12, 2021 22:18
@MelvinBot MelvinBot requested review from iwiznia and removed request for a team September 12, 2021 22:19
@iwiznia
Copy link
Contributor

iwiznia commented Sep 13, 2021

Should I review this? Asking because it's WIP

@puneetlath
Copy link
Contributor Author

Not yet! I guess PR's automatically get assigned our in this repo, even though I hadn't assigned puller bear yet. I'll ping you when it's no longer WIP.

@puneetlath puneetlath changed the title [WIP] Update payments page to use Expensify logo for Expensify Card Update payments page to use Expensify logo for Expensify Card Sep 14, 2021
@puneetlath
Copy link
Contributor Author

@iwiznia it's ready for your review now!

@iwiznia iwiznia merged commit 651c948 into main Sep 14, 2021
@iwiznia iwiznia deleted the puneet-expensifycard-logo branch September 14, 2021 17:24
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.0.98-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@puneetlath @iwiznia what account can we use to validate this PR?
We are unable to see needed details with Applausecard account

@puneetlath
Copy link
Contributor Author

You can use any account that has an Expensify Card assigned to it and log into new.expensify.com and view the Payments page.

@isagoico
Copy link

@puneetlath I checked on our testing account that has an active Expensify Card and it's not visible in the payments Page.
tester@applausecard.expensifail.com (Credentials in 1Password)

image

@puneetlath
Copy link
Contributor Author

Ah, it looks like this PR made my PR obsolete: #5212

@isagoico
Copy link

Oh, how should we proceed here then? Should I create a separate issue about the card not appearing?

@puneetlath
Copy link
Contributor Author

We can go ahead and let this go to production, it won't hurt anything. And I'll submit a follow-up PR to clean up the logic given that the change made here is no longer needed.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants