Refactor IOU.categorizeTrackedExpense function #52221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am waiting on BE to solve the issue for workspace with tax rates enabled as mentioned here #50368 (comment). |
3 tasks
melvin-bot
bot
requested review from
dukenv0307
and removed request for
a team
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
dukenv0307
reviewed
Dec 5, 2024
src/libs/actions/IOU.ts
Outdated
| taxAmount = 0, | ||
| billable?: boolean, | ||
| receipt?: Receipt, | ||
| trackedExpenseInformation: CategorizeTrackedExpenseInformation, |
There was a problem hiding this comment.
Can you create the type that contains all params? We already discussed it in #52231 (comment)
dukenv0307
reviewed
Dec 5, 2024
|
@ChavdaSachin We already merged several PRs like this, so you can refer to how we're doing. |
dukenv0307
reviewed
Dec 9, 2024
src/libs/actions/IOU.ts
Outdated
| billable, | ||
| trackedReceipt, | ||
| receipt: trackedReceipt, | ||
| } as CategorizeTrackedExpenseTransactionParams; |
There was a problem hiding this comment.
Why do we need type assertion here?
dukenv0307
reviewed
Dec 9, 2024
src/libs/actions/IOU.ts
Outdated
| createdWorkspaceParams, | ||
| ); | ||
| } as CategorizeTrackedExpenseParams; |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-09.at.09.03.40.movAndroid: mWeb ChromeScreen.Recording.2024-12-09.at.08.56.47.moviOS: NativeScreen.Recording.2024-12-09.at.08.58.48.moviOS: mWeb SafariScreen.Recording.2024-12-09.at.08.56.06.movMacOS: Chrome / SafariScreen.Recording.2024-12-09.at.08.53.52.movMacOS: DesktopScreen.Recording.2024-12-09.at.09.06.25.mov |
|
looks good, just left some minor comments |
dukenv0307
approved these changes
Dec 10, 2024
neil-marcellini
approved these changes
Dec 11, 2024
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
paultsimura
reviewed
Dec 11, 2024
| moneyRequestReportID, | ||
| moneyRequestCreatedReportActionID, | ||
| actionableWhisperReportActionID, | ||
| onyxData, |
There was a problem hiding this comment.
Why do you pass onyxData in the API request params?
There was a problem hiding this comment.
That seems to be a blunder made by me while resolving conflicts.
Thank you @paultsimura.
Now there are two options, you could remove it in your current PR or else I would fix it in my upcoming refactor PR.
Also I am re checking this PR to make sure no other such mistakes are done.
There was a problem hiding this comment.
Also linkedTrackedExpenseReportAction from ...reportInformation
48 tasks
55 tasks
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.75-0 🚀
|
8 tasks
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Refactor IOU.categorizeTrackedExpense function.
Fixed Issues
$ #50368
PROPOSAL: NA
Tests
Same as QA Tests.
Offline tests
Same as QA Tests.
QA Steps
Just Track It(don't submit it)option.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-05.at.3.48.56.AM.online-video-cutter.com.mp4
Android: mWeb Chrome
Screen.Recording.2024-12-05.at.2.25.40.AM.mov
iOS: Native
Screen.Recording.2024-12-05.at.2.37.14.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-12-05.at.2.16.41.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-05.at.2.07.12.AM.mp4
MacOS: Desktop
Screen.Recording.2024-12-05.at.3.58.20.AM.mp4