Add safety net for timezone in DateUtils #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not able to test iOS and Desktop ATM, I can try them later |
luacmartins
approved these changes
Sep 16, 2021
|
|
|
Merging to fix a deploy blocker! Sorry @Gonals! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
…ial-value-fix Add safety net for timezone in DateUtils (cherry picked from commit ea45c24)
This was referenced Sep 16, 2021
|
🚀 Cherry-picked to staging by @luacmartins in version: 1.0.99-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Tested this PR and it was a pass. @AndrewGable not sure if you want to check on your side to double check. |
|
I can login with no white screens 👍 |
31 tasks
|
🚀 Deployed to staging by @luacmartins in version: 1.0.99-5 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Handle the cases where
timezoneis used before the Onyx connection has provided a valueor when the value lacks timezone
Handle response errors in the
API.GetinAuthScreensFixed Issues
$ #5305
Tests
Test that there are no regressions regarding locale assignment
QA Steps
Same as above
Tested On
Screenshots
Web
New.Expensify.-.Google.Chrome.2021-09-16.22-48-31.mp4
Mobile Web
Android.Emulator.-.Pixel_2_API_29_5554.2021-09-16.22-54-12.mp4
Desktop
iOS
Android
Android.Emulator.-.Pixel_2_API_29_5554.2021-09-16.22-51-56.mp4