Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2021-09-20 #5368

Closed
31 tasks done
OSBotify opened this issue Sep 20, 2021 · 6 comments
Closed
31 tasks done

Deploy Checklist: New Expensify 2021-09-20 #5368

OSBotify opened this issue Sep 20, 2021 · 6 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 20, 2021

Release Version: 1.1.0-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

@isagoico
Copy link

Starting QA

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 20, 2021
@Jag96
Copy link
Contributor

Jag96 commented Sep 20, 2021

Cherry-picking #5369 to staging, will update the list once its done

@Jag96
Copy link
Contributor

Jag96 commented Sep 20, 2021

Checking off #5357

image

@isagoico
Copy link

Regression is finished!
Issues found:

  1. VBA flow - Different error message modal appears for choose an account field #5383
  2. Workspace - Manage cards button is not responding #5382
  3. Log in - Error message doesn't disappear when editing the email or phone number  #5389

PRs are finished too.
No comments added.

#5384 is blocking the "Forgot?" password flow.

Thanks!

@Jag96
Copy link
Contributor

Jag96 commented Sep 21, 2021

@isagoico #5398 has been added to fix the deploy blocker, can we get a retest for #5384?

@Jag96
Copy link
Contributor

Jag96 commented Sep 21, 2021

:shipit:

@Jag96 Jag96 closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants