Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate the link only when page is focused #5354

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Activate the link only when page is focused #5354

merged 1 commit into from
Sep 20, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Sep 20, 2021 •
edited
Loading

Details

Fixed Issues

$ #5331

Tests | QA Steps

Mobile| Mobile Web

  1. Create| Open Workspace on mobile.
  2. Open the Invite Page.
  3. Go back to the Workspace setting screen.
  4. No Tab should be shown as selected.

Web | Desktop

  1. Create| Open Workspace on web| desktop.
  2. Open the Invite Page.
  3. Respective Tab should be shown as selected in the sidebar based on the page opened in the Workspace Modal.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

Screenshot 2021-09-20 at 22-17-37 New Expensify - Chat with friends to send and receive money

Mobile Web

Screenshot 2021-09-20 at 22-16-43 New Expensify - Chat with friends to send and receive money

iOS

Android

Screenshot 2021-09-20 22:17:22

@parasharrajat parasharrajat requested a review from a team as a code owner September 20, 2021 16:52
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team September 20, 2021 16:52
roryabraham
roryabraham approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham
Copy link
Contributor

Merging because this is N6 polish

@roryabraham roryabraham merged commit 64d3541 into Expensify:main Sep 20, 2021
@OSBotify OSBotify mentioned this pull request Sep 20, 2021
Closed
31 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.99-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@NikkiWines NikkiWines mentioned this pull request Sep 28, 2021
Closed
@parasharrajat parasharrajat deleted the workspace-sidebar branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @roryabraham @OSBotify