Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Props Warning #5320

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Sep 17, 2021

@Jag96

Details

Refer comment from PR -> #5095 (comment)
Should not show that warning, so handled in the PR. The changes don't affect any expected behavior in production. But based on code changes it looks like affecting native mobile devices, so added tests for that.

Fixed Issues

$ #4645

Tests

  1. Run the app in development mode locally on Android and iOS devices.
  2. You should not see the warning in this comment

QA Steps

  1. Go to Settings
  2. Click Profile
  3. Click the pen icon to update or add a photo
  4. Click upload photo
  5. Refer Fix section below, it should work as shown there.
  6. Create a new workspace if you don't have one.
  7. Go to Setting
  8. Click on your workspace.
  9. Tap on the Workspace icon
  10. Click the pen icon to update or add a photo
  11. Click upload photo

We should show only two options now

  • Take photos
  • Choose from gallery

Tested On

  • iOS
  • Android

Screenshots

iOS

For Reviewer - No warning now.
Warning.mp4
For QA

Simulator Screen Shot - iPhone 12 - 2021-09-17 at 19 54 39

Android

For QA

Screenshot_1631889430

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner September 17, 2021 14:58
@MelvinBot MelvinBot requested review from tgolen and removed request for a team September 17, 2021 14:58
@tgolen tgolen merged commit dfd470b into Expensify:main Sep 17, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Santhosh-Sellavel
Copy link
Collaborator Author

@tgolen clarification should I wait for this PR to get deployed in production to get paid?.

@tgolen
Copy link
Contributor

tgolen commented Sep 20, 2021

I believe so, yes.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @tgolen in version: 1.0.99-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants