Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labels in VBA flow to have correct spacing #5329

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Sep 17, 2021

Details

This PR updates some labels that had incorrect spacing on iOS and Android while navigating the VBA flow. This fix uses the translateX prop introduced in #3414 to make these changes, eventually, we may want to refactor that since the spacing is not uniform for all inputs across the app, but for N6 this approach will work.

Fixed Issues

Fixes issue from discussion in slack

Tests/QA

  1. Create a new workspace and go through the VBA flow, confirm all of the labels have proper spacing
    1. Confirm First Name, Last Name, City, Incorporation Date specifically, as this PR fixes those

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Company Info

Web iOS Android
image image image

Personal Info

Web iOS Android
image image image

@Jag96 Jag96 requested a review from a team as a code owner September 17, 2021 20:30
@Jag96 Jag96 self-assigned this Sep 17, 2021
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team September 17, 2021 20:30
@stitesExpensify stitesExpensify merged commit 509d2a9 into main Sep 20, 2021
@stitesExpensify stitesExpensify deleted the joe-fix-mobile-labels branch September 20, 2021 18:16
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.0.99-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants