Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room" #53598

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Revert "Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room" #53598

merged 1 commit into from
Dec 4, 2024

Conversation

yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon self-assigned this Dec 4, 2024
@yuwenmemon yuwenmemon requested a review from a team as a code owner December 4, 2024 20:25
@melvin-bot melvin-bot bot requested review from blimpich and removed request for a team December 4, 2024 20:25
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 4, 2024

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@yuwenmemon
Copy link
Contributor Author

@blimpich Before merging I'd check in on the thread here: https://expensify.slack.com/archives/C07HPDRELLD/p1733344036391719?thread_ts=1733314330.634409&cid=C07HPDRELLD

blimpich
blimpich approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@blimpich blimpich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a straight revert?

@blimpich blimpich merged commit ffd18cd into main Dec 4, 2024
14 of 16 checks passed
@blimpich blimpich deleted the revert-52314-wip-move-tasks-to-admin-2 branch December 4, 2024 23:00
@melvin-bot melvin-bot bot added the Emergency label Dec 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 4, 2024

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@blimpich blimpich removed the Emergency label Dec 4, 2024
@blimpich
Copy link
Contributor

blimpich commented Dec 4, 2024

Not an emergency, revert PR

@OSBotify
Copy link
Contributor

OSBotify commented Dec 4, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 4, 2024
@blimpich @OSBotify
Merge pull request #53598 from Expensify/revert-52314-wip-move-tasks-…
fd50d70 
…to-admin-2

(cherry picked from commit ffd18cd)

(CP triggered by puneetlath)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Dec 4, 2024
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Closed
35 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.0.71-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.71-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

@c3024 c3024 mentioned this pull request Dec 5, 2024
Merged
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blimpich blimpich blimpich approved these changes

Assignees

@yuwenmemon yuwenmemon

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwenmemon @blimpich @OSBotify