Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workspace settings #5642

Merged
merged 135 commits into from
Oct 8, 2021
Merged

Refactor workspace settings #5642

merged 135 commits into from
Oct 8, 2021

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Oct 4, 2021 •
edited
Loading

This PR adds a lot of feature promotion to the workspace settings

Fixed Issues

$ #5689

Tests

  1. Log into NewDot
  2. Create a workspace
  3. Go to Settings > Workspace
  4. Navigate around all the pages and see that most features are locked without a bank account
  5. Add a bank account
  6. Navigate around all the pages and see that the features are now unlocked

QA Steps

Tests are all written in this doc and will be performed internally

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

image

Android

tgolen and others added 30 commits October 4, 2021 15:21
@tgolen
Add new routes and link configs
36115d2
@tgolen
Rename some workspace pages
eb2a247
@tgolen
Rename editor to settings
98e02af
@tgolen
Add new skeleton pages
80f2d6d
@tgolen
Merge branch 'main' into tgolen-workspace-settings
719c713
@tgolen
Get site running with navigation pieces in place
4142566
@tgolen
Update link text and icons
cbe7b39
@tgolen
Add copy and a new component for ordered list
ae5a51e
@tgolen
Add MenuItemList component
0258acd
@tgolen
Add navigation to cards page
6bd1721
@tgolen
Move the view into a subView
cabe79b
@tgolen
DRY up the code some and add a new view
20407a1
@tgolen
Add third view and unDRY things
a17caa7
@tgolen
Add logic for detecting the state of the VBA
a15c8c8
@marcaaron
Move bank-account flow into workspace flow
73ff6ab
@tgolen
DRY up the code with a section component
86b27c3
@tgolen
Move card pages into a folder
7efa7e7
@tgolen
Rename folder to just card
10563c7
@tgolen
Move reimburse page to a folder
734184e
@tgolen
Add the reimburse pages
1e1615a
@marcaaron
adding the basically done thing page but bank icons need a bankName a…
a7727f4 
…nd none exists
@tgolen
Add copy to clipboard component
b259d54
@tgolen
Add the proper links to the reimburse pages
bc53e47
@marcaaron
Create interstitial page to redirect or show continue button
16a458e
@tgolen
Add the bill pay pages
eaa4780
@tgolen
Parse user's email domain
191273d
@marcaaron
fix subStep logic so that we remember the option selected;
9e03ec0
@tgolen
Remove loading indicators so pages will work offline
782816f
@tgolen
DRY up the section pages
7039372
@tgolen
DRY up the reimburse page
4f15e2a
marcaaron
marcaaron previously approved these changes Oct 8, 2021
View reviewed changes
@marcaaron marcaaron self-requested a review October 8, 2021 18:43
@marcaaron marcaaron merged commit 2ae2fd8 into main Oct 8, 2021
@marcaaron marcaaron deleted the tgolen-workspace-settings branch October 8, 2021 19:22
github-actions bot pushed a commit that referenced this pull request Oct 8, 2021
@marcaaron
Merge pull request #5642 from Expensify/tgolen-workspace-settings
df2b2d8 
Refactor workspace settings

(cherry picked from commit 2ae2fd8)
@OSBotify OSBotify mentioned this pull request Oct 8, 2021
Merged
AndrewGable added a commit that referenced this pull request Oct 9, 2021
@AndrewGable
Merge pull request #5735 from Expensify/OSBotify-cherry-pick-staging-…
9721d40 
…5642

🍒 Cherry pick PR #5642 to staging 🍒
@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2021

🚀 Cherry-picked to staging by @marcaaron in version: 1.1.7-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Oct 11, 2021
Closed
36 tasks
@isagoico isagoico mentioned this pull request Oct 11, 2021
Closed
@isagoico
Copy link

We found this issue while QAing this PR #5760 Not sure if a deploy blocker tho, added the label so it can be decided there

@luacmartins luacmartins mentioned this pull request Oct 12, 2021
Closed
5 tasks
@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Beamanator Beamanator mentioned this pull request Jan 5, 2022
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
parasharrajat
parasharrajat reviewed Jun 28, 2023
View reviewed changes
src/styles/styles.js
@@ -1861,6 +1872,10 @@ const styles = {
cursor: 'not-allowed',
},

cursorPointer: {
cursor: 'pointer',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style property is not supported on RN. It is a browser-only css property. Because we used the same styles for all platforms, it caused a console error on native platforms #20589.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could fix this generically by passing all styles through StyleSheet.create?

@parasharrajat parasharrajat mentioned this pull request Jun 28, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@parasharrajat parasharrajat parasharrajat left review comments

@Gonals Gonals Gonals left review comments

@TomatoToaster TomatoToaster TomatoToaster left review comments

@Julesssss Julesssss Julesssss left review comments

@Jag96 Jag96 Jag96 left review comments

@marcaaron marcaaron marcaaron approved these changes

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@tgolen tgolen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.