Code

Refactor workspace settings#5642

Code

Merged

marcaaron merged 135 commits intomainExpensify/App:mainfrom tgolen-workspace-settingsExpensify/App:tgolen-workspace-settingsCopy head branch name to clipboardOct 8, 2021

+3,097-834

Commits

Commits on Oct 4, 2021

• Add new routes and link configs

  tgolen

  committed
  36115d2

• Rename some workspace pages

  tgolen

  committed
  eb2a247

• Rename editor to settings

  tgolen

  committed
  98e02af

• Add new skeleton pages

  tgolen

  committed
  80f2d6d

Commits on Oct 5, 2021

• Merge branch 'main' into tgolen-workspace-settings

  tgolen

  committed
  719c713

• Get site running with navigation pieces in place

  tgolen

  committed
  4142566

Commits on Oct 6, 2021

• Update link text and icons

  tgolen

  committed
  cbe7b39

• Add copy and a new component for ordered list

  tgolen

  committed
  ae5a51e

• Add MenuItemList component

  tgolen

  committed
  0258acd

• Add navigation to cards page

  tgolen

  committed
  6bd1721

• Move the view into a subView

  tgolen

  committed
  cabe79b

• DRY up the code some and add a new view

  tgolen

  committed
  20407a1

• Add third view and unDRY things

  tgolen

  committed
  a17caa7

• Add logic for detecting the state of the VBA

  tgolen

  committed
  a15c8c8

• Move bank-account flow into workspace flow

  marcaaron

  committed
  73ff6ab

• DRY up the code with a section component

  tgolen

  committed
  86b27c3

• Move card pages into a folder

  tgolen

  committed
  7efa7e7

• Rename folder to just card

  tgolen

  committed
  10563c7

• Move reimburse page to a folder

  tgolen

  committed
  734184e

• Add the reimburse pages

  tgolen

  committed
  1e1615a

• adding the basically done thing page but bank icons need a bankName and none exists

  marcaaron

  committed
  a7727f4

• Add copy to clipboard component

  tgolen

  committed
  b259d54

• Add the proper links to the reimburse pages

  tgolen

  committed
  bc53e47

• Create interstitial page to redirect or show continue button

  marcaaron

  committed
  16a458e

• Add the bill pay pages

  tgolen

  committed
  eaa4780

• Parse user's email domain

  tgolen

  committed
  191273d

• fix subStep logic so that we remember the option selected;

  marcaaron

  committed
  9e03ec0

• Remove loading indicators so pages will work offline

  tgolen

  committed
  782816f

• DRY up the section pages

  tgolen

  committed
  7039372

• DRY up the reimburse page

  tgolen

  committed
  4f15e2a

• DRY up the bills page

  tgolen

  committed
  5a9f472

• Fix bankName stuff

  marcaaron

  committed
  8519ad3

• DRY the card page

  tgolen

  committed
  e5efd86

• add initial english translations

  marcaaron

  committed
  74e4a55

• clean up getPaymentMethods

  marcaaron

  committed
  235b3d9

• use initWithStoredValues

  marcaaron

  committed
  93e9d35

Commits on Oct 7, 2021

• Remove add work email and replace with Concierge

  marcaaron

  committed
  d87cfc8

• Add noop onPress

  marcaaron

  committed
  1038edf

• dont show the continue setup screen if we are in an open state

  marcaaron

  committed
  72fb8d7

• Add the invoices page

  tgolen

  committed
  04ed733

• DRY up the bills page a little

  tgolen

  committed
  ecab72f

• Fix component display name

  tgolen

  committed
  a507a61

• fix weird bug that silently breaks navigating to a new step

  marcaaron

  committed
  8db44a0

• pop the WorkspaceBankAccountPage before navigating to /bank-account

  marcaaron

  committed
  cd2d639

• remove unneeded link out to olddot

  marcaaron

  committed
  10e27c7

• Navigate to correct next step

  marcaaron

  committed
  62a5191

• add missing propTypes

  marcaaron

  committed
  183903a

• Adding product illustrations

  shawnborton

  committed
  8b32d0e

• Merge branch 'tgolen-workspace-settings' of github.com:Expensify/App into tgolen-workspace-settings

  tgolen

  committed
  0b18732

• Add travel page

  tgolen

  committed
  16f511b

• Rename asset files

  tgolen

  committed
  1ba208c

• Adding one color icons

  shawnborton

  committed
  2eaad80

• Merge branch 'tgolen-workspace-settings' of github.com:Expensify/App into tgolen-workspace-settings

  tgolen

  committed
  c1558d9

• Add illustration icon file

  tgolen

  committed
  11e13d0

• Update icon list

  tgolen

  committed
  4a30e0b

• Update icons on the card pages

  tgolen

  committed
  c647cca

• Fix icons on the receipt page

  tgolen

  committed
  18b47f6

• Fix icons on the bills page

  tgolen

  committed
  a4e1758

• Fix icons on the invoices page

  tgolen

  committed
  ee196da

• Add Spanish translations for new workspaces

  Gonals

  committed
  e5cac37

• Fix icons on the travel page

  tgolen

  committed
  53d93d3

• Add back navigation to members and invite page

  tgolen

  committed
  864f709

• Update bills page for public domains

  tgolen

  committed
  21a73c9

• Merge pull request #5711 from Expensify/alberto-workspace-settings-spanish

  Show description for c4dfad5
  tgolen

  authored
  c4dfad5

• Use better back navigation for member page

  tgolen

  committed
  80da4a7

• Merge branch 'tgolen-workspace-settings' of github.com:Expensify/App into tgolen-workspace-settings

  tgolen

  committed
  f078520

• Clean up some translation stuff

  tgolen

  committed
  1b7b3b4

• Use ternarys and a few cleanups

  tgolen

  committed
  f981a76

• add translations

  marcaaron

  committed
  81dea7f

• Merge branch 'main' into tgolen-workspace-settings

  tgolen

  committed
  ca1d9a8

• Add currency selector to settings page

  iwiznia

  committed
  6bfe2e9

• Lint

  tgolen

  committed
  b695594

• add translations and assets

  marcaaron

  committed
  ac85502

• Merge branch 'tgolen-workspace-settings' into marcaaron-connectBankAccount2

  marcaaron

  authored
  665da6d

• remove unneeded import

  marcaaron

  committed
  18b05d3

• Disable currency field if vba is set and add some styles

  iwiznia

  committed
  884e2a5

• update copy

  marcaaron

  committed
  6dce153

• change icon

  marcaaron

  committed
  89a326f

• Add spanish translations

  iwiznia

  committed
  23fdff0

• Address review comments

  iwiznia

  committed
  480cefe

• Merge pull request #5713 from Expensify/ionatan_settings_page

  Show description for 1363f8f
  tgolen

  authored
  1363f8f

• remove assets

  marcaaron

  committed
  198a064

• Force button to the bottom of the page

  tgolen

  committed
  cafbfdf

• remove unused things

  marcaaron

  committed
  c06423f

• Remove unused imports

  tgolen

  committed
  0326535

• Move workspace screens into the settings stack

  tgolen

  committed
  8a67d92

• Clean up unnecessary function nesting

  tgolen

  committed
  089ced3

• fix conflicts

  marcaaron

  committed
  87271a8

• Use the correct reconciliation link

  tgolen

  committed
  53b5f10

• update route

  marcaaron

  committed
  78da1f0

• Update src/pages/workspace/WorkspaceSettingsPage.js

  Show description for fafa0ce
  

  tgolen

  and

  roryabraham

  authored
  fafa0ce

• Update src/languages/en.js

  Show description for 4929f79
  

  tgolen

  and

  roryabraham

  authored
  4929f79

• Fix proptype warning

  tgolen

  committed
  75dffa7

• Clear setTimeout interval on unmount

  tgolen

  committed
  308bd4b

• Remove fragment

  tgolen

  committed
  3b998c1

• Add cursor pointer

  tgolen

  committed
  a447340

• DRY the style proptypes

  tgolen

  committed
  1665825

• move loading false so ACHContractStep does not reshow

  marcaaron

  committed
  50ab411

• Merge branch 'tgolen-workspace-settings' of github.com:Expensify/App into tgolen-workspace-settings

  tgolen

  committed
  62057fd

• Fix link position

  tgolen

  committed
  889f94c

• Remove exact routes

  tgolen

  committed
  459a721

• Rename methods to have better names

  tgolen

  committed
  f561152

• use lodashGet

  tgolen

  committed
  978aae5

• Improve policy imports

  tgolen

  committed
  b075c12

• Fix component name

  tgolen

  committed
  16085b9

• Remove unnecessary compose

  tgolen

  committed
  fbe5495

• Use the proper text component

  tgolen

  committed
  21e6742

• add workaround for navigation

  marcaaron

  committed
  075fc07

• fix conflicts

  marcaaron

  committed
  d8a9be7

• remove pop

  marcaaron

  committed
  d68da52

• Remove extra dismissModal as it is no longer needed. Add a dismissModal in EnableStep

  marcaaron

  committed
  a409a59

Commits on Oct 8, 2021

• Some extra translations for workspaces

  Gonals

  committed
  0210427

• Merge pull request #5703 from Expensify/marcaaron-connectBankAccount2

  Show description for 67ec342
  tgolen

  authored
  67ec342

• Fix unnecessary fragments

  tgolen

  committed
  d8b3023

• Fixing some component names and other review comments

  tgolen

  committed
  1c9d8d6

• Merge branch 'main' into tgolen-workspace-settings

  tgolen

  committed
  18db228

• Add display name

  tgolen

  committed
  9151b74

• style and typo

  tgolen

  committed
  860e35c

• Fix lint and remove unused translation

  tgolen

  committed
  46bb911

• add members

  Gonals

  committed
  db6612f

• Merge branch 'tgolen-workspace-settings' into alberto-workspace-translation

  tgolen

  authored
  73b76c8

• Merge pull request #5725 from Expensify/alberto-workspace-translation

  Show description for d521f9f
  tgolen

  authored
  d521f9f

• Fix image uploading

  tgolen

  committed
  da1b829

• Fix propType warning

  tgolen

  committed
  ad9868d

• Remove default prop

  tgolen

  committed
  64cb9d4

• Simplify function references

  tgolen

  committed
  51bfb9b

• Fix casing on menu item prop types

  tgolen

  committed
  45011d6

• Fix display name, delete unused file

  tgolen

  committed
  2fc0b74

• Fix undefined

  tgolen

  committed
  a2bfa87

• Remove event being passed to goBack()

  tgolen

  committed
  fc61822

• Simplify prop logic

  tgolen

  committed
  905e48c

• Remove uniqueId from keys

  tgolen

  committed
  ce2dabe

• Remove style prop and simplify component

  tgolen

  committed
  66838fa

• Merge branch 'main' into tgolen-workspace-settings

  tgolen

  committed
  318d90a

• Don't navigate after saving policy settings

  tgolen

  committed
  cc12068