Don't override Environment on hybrid app #57015

jnowakow · 2025-02-18T11:59:30Z

Explanation of Change

It restores changes from #56401 that were reverted.

Fixed Issues

$ #52199 (comment)
PROPOSAL: N/A

Tests

Test case 1:

Navigate to the bank account connect flow
Reach the plaid modal
Plaid should point to the Sandbox environment to be able to test it.

Test case 2:

Open iOS Hybrid app.
Log in with a expensifail account.
Tap on: Settings > Workspaces > More features
Enable 'Expensify Cards'
Go to 'Expensify Cards'
Tap on 'Issue card'
Assign the card to yourself. Choose a virtual card. Complete the flow.
Go to the WS chat
Tap on the hyperlink 'Expensify card'
The details of the card is displayed.

Test case 3:

Launch ND or hybrid app.
Go to Account settings.
Tap Domains.
Domains page will open in external browser.

Test case 4:

Launch hybrid app.
Log in with a new Expensifail account.
Create a new workspace.
Go to Concierge chat.
Click any task with link in the description (Create a workspace task).
Onboarding links are valid and will not show "undefined".

Test case 5:

Launch hybrid app.
Go to workspace settings > Workflows.
Tap Connect bank account.
Tap Log into your bank.
Select Wells Fargo.
Go through Plaid flow on the browser.
After completing the Plaid flow, it will land in the app.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test case 1:

Navigate to the bank account connect flow
Reach the plaid modal
Plaid should point to the Sandbox environment to be able to test it.

Test case 2:

Open iOS Hybrid app.
Log in with a expensifail account.
Tap on: Settings > Workspaces > More features
Enable 'Expensify Cards'
Go to 'Expensify Cards'
Tap on 'Issue card'
Assign the card to yourself. Choose a virtual card. Complete the flow.
Go to the WS chat
Tap on the hyperlink 'Expensify card'
The details of the card is displayed.

Test case 3:

Launch ND or hybrid app.
Go to Account settings.
Tap Domains.
Domains page will open in external browser.

Test case 4:

Launch hybrid app.
Log in with a new Expensifail account.
Create a new workspace.
Go to Concierge chat.
Click any task with link in the description (Create a workspace task).
Onboarding links are valid and will not show "undefined".

Test case 5:

Launch hybrid app.
Go to workspace settings > Workflows.
Tap Connect bank account.
Tap Log into your bank.
Select Wells Fargo.
Go through Plaid flow on the browser.
After completing the Plaid flow, it will land in the app.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-02-18T11:59:35Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-02-18T12:01:06Z

@jnowakow
Do you need help with a review ?

jnowakow · 2025-02-18T12:20:32Z

@ZhenjaHorbach I think it would be good to trigger adhoc builds and test this PR that earlier there were some issues . I wasn't able to reproduce them locally.
cc @AndrewGable @Julesssss

ZhenjaHorbach · 2025-02-18T12:25:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

NA

iOS: Native

2025-02-18.15.00.40.mp4

2025-02-18.15.00.36.mp4

2025-02-18.15.20.40.mp4

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

NA

MacOS: Desktop

NA

ZhenjaHorbach · 2025-02-18T12:26:19Z

@ZhenjaHorbach I think it would be good to trigger adhoc builds and test this PR that earlier there were some issues . I wasn't able to reproduce them locally. cc @AndrewGable @Julesssss

Agree that it is better to test this PR using adhoc builds !

@mountiny
Maybe you are free to trigger builds? 😀

github-actions · 2025-02-18T12:42:44Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-02-18T13:18:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57015/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/57015/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

jnowakow · 2025-02-18T13:30:24Z

@mountiny can you ask testers to examine the builds? More issues are on iOS and I don't have access to one

mountiny · 2025-02-18T13:32:04Z

@jnowakow can you list all the test steps in the PR body so I can just link the PR to them?

jnowakow · 2025-02-18T13:41:41Z

@mountiny updated :D

mountiny · 2025-02-18T14:51:47Z

Asked QA https://expensify.slack.com/archives/C9YU7BX5M/p1739886537092349

ZhenjaHorbach · 2025-02-18T14:54:40Z

Just tested IOS
None of issues are reproduced !

And left only one issue for android to test
But for some reason I constantly see the same error as here

vincdargento · 2025-02-18T19:36:14Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Workspace - Connect BA - Error message appears when try to add BA via Plaid modal

Version Number: v.9.1.0-0 PR:57015 Ad-Hoc
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause Internal Team

Action Performed:

Open the Ad-Hoc App
Login with any account
Go to Settings -> Open any WS (create it if needed) -> Workflows -> Add approval workflow
Change currency to USD
Choose Plaid and enter a magic code

Expected Result:

You can continue the flow of adding BA

Actual Result:

Error message arrears and cannot procced the flow

Workaround:

Unknown

Platforms:

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

jnowakow · 2025-02-19T07:59:12Z

This issue seems to be not related. It seems that there is limit on how many times you can go through Plaid's flow. Even in sandbox environment

mountiny · 2025-02-19T08:03:51Z

Seems like we are good then! @jnowakow can you please update the PR title?

mountiny · 2025-02-19T08:04:02Z

@ZhenjaHorbach can you complete the checklist please?

ZhenjaHorbach · 2025-02-19T08:07:34Z

@ZhenjaHorbach can you complete the checklist please?

Done !
And LGTM !

jnowakow · 2025-02-19T08:13:28Z

@mountiny done! 🫡

jnowakow · 2025-02-19T08:19:11Z

One more thing. @mountiny can you check in Plaid's dashboard which android package is registered?

mountiny · 2025-02-19T08:40:48Z

Hmm never had to go there, asking around. Any reason you asking? seems like Plaid is working fine so I guess its correctly setup

jnowakow · 2025-02-19T08:57:27Z

Earlier there was com.expensify.chat hardcoded so I want to be sure that Plaid's configuration match reality. Now actual package name will be passed so this should fix this issue on staging. I want to be sure that there's package name for production hybrid app which is org.me.mobiexpensifyg.
It worked before even though there was mismatch but I think it would be good to adjust package names in console

ZhenjaHorbach · 2025-02-19T09:07:03Z

Actually just tested another adhoc build
And I don't have this issue on android

jnowakow · 2025-02-19T09:08:15Z

Hmm actually I just noticed that the issue with disabled login is caused by package mismatch

jnowakow · 2025-02-19T09:24:42Z

This would mean that #56719 is reproducible on production 🤔

mountiny · 2025-02-19T09:27:53Z

It might be, we dont have testing account for production so real data would have to be used to confirm

jnowakow · 2025-02-19T09:33:12Z

Okey, so I think it's reasonable to add package names that match hybrid app

OSBotify · 2025-02-19T16:13:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-20T03:07:41Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.1.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-02-20T11:53:30Z

PR is failing on Android with #57152 and
failing on iOS with issues: #57148, #57149, #57150

1740021243345.57015_iOS_-_Test_1.mp4

1740022302909.57015_iOS_-_Test_4.mp4

Pending validation on Desktop

jnowakow · 2025-02-20T12:04:17Z

Fix for all three iOS issues is here.
Fix for Android requires changes in Plaid's dashboard

izarutskaya · 2025-02-20T12:45:15Z

@jnowakow Tester can reproduce the issue #52199 on IOs
Can you please check the video and let me know? Thank you

1740021243345.57015_iOS_-_Test_1.1.mp4

jnowakow · 2025-02-20T12:48:49Z

@izarutskaya this should be fixed by https://github.com/Expensify/Mobile-Expensify/pull/13433 as well

github-actions · 2025-02-20T22:00:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.2-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Restore PR 56401

6345199

jnowakow requested a review from a team as a code owner February 18, 2025 11:59

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team February 18, 2025 11:59

mountiny added the Ready To Build label Feb 18, 2025

mountiny assigned jnowakow Feb 18, 2025

ZhenjaHorbach approved these changes Feb 19, 2025

View reviewed changes

melvin-bot bot requested a review from AndrewGable February 19, 2025 08:07

jnowakow changed the title ~~Restore PR 56401~~ Don't override Environment on hybrid app Feb 19, 2025

ZhenjaHorbach mentioned this pull request Feb 19, 2025

[Due for payment 2025-02-27] [Due for payment 2025-02-19] Hybrid - Bank Account - Plaid flow is not pointing to Sandbox environment #52199

Open

8 tasks

AndrewGable approved these changes Feb 19, 2025

View reviewed changes

AndrewGable merged commit e2eab2a into Expensify:main Feb 19, 2025
19 checks passed

github-actions bot mentioned this pull request Feb 20, 2025

Deploy Checklist: New Expensify 2025-02-20 #57146

Closed

30 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't override Environment on hybrid app #57015

Don't override Environment on hybrid app #57015

jnowakow commented Feb 18, 2025 •

edited

Loading

melvin-bot bot commented Feb 18, 2025

ZhenjaHorbach commented Feb 18, 2025

jnowakow commented Feb 18, 2025

ZhenjaHorbach commented Feb 18, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

jnowakow commented Feb 18, 2025

mountiny commented Feb 18, 2025

jnowakow commented Feb 18, 2025

mountiny commented Feb 18, 2025

ZhenjaHorbach commented Feb 18, 2025 •

edited

Loading

vincdargento commented Feb 18, 2025

jnowakow commented Feb 19, 2025

mountiny commented Feb 19, 2025

mountiny commented Feb 19, 2025

ZhenjaHorbach commented Feb 19, 2025

jnowakow commented Feb 19, 2025

jnowakow commented Feb 19, 2025

mountiny commented Feb 19, 2025

jnowakow commented Feb 19, 2025

ZhenjaHorbach commented Feb 19, 2025

jnowakow commented Feb 19, 2025

jnowakow commented Feb 19, 2025

mountiny commented Feb 19, 2025

jnowakow commented Feb 19, 2025

OSBotify commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

izarutskaya commented Feb 20, 2025

jnowakow commented Feb 20, 2025

izarutskaya commented Feb 20, 2025

jnowakow commented Feb 20, 2025

github-actions bot commented Feb 20, 2025

Don't override Environment on hybrid app #57015

Don't override Environment on hybrid app #57015

Conversation

jnowakow commented Feb 18, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 18, 2025

ZhenjaHorbach commented Feb 18, 2025

jnowakow commented Feb 18, 2025

ZhenjaHorbach commented Feb 18, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ZhenjaHorbach commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

jnowakow commented Feb 18, 2025

mountiny commented Feb 18, 2025

jnowakow commented Feb 18, 2025

mountiny commented Feb 18, 2025

ZhenjaHorbach commented Feb 18, 2025 • edited Loading

vincdargento commented Feb 18, 2025

Workspace - Connect BA - Error message appears when try to add BA via Plaid modal

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

jnowakow commented Feb 19, 2025

mountiny commented Feb 19, 2025

mountiny commented Feb 19, 2025

ZhenjaHorbach commented Feb 19, 2025

jnowakow commented Feb 19, 2025

jnowakow commented Feb 19, 2025

mountiny commented Feb 19, 2025

jnowakow commented Feb 19, 2025

ZhenjaHorbach commented Feb 19, 2025

jnowakow commented Feb 19, 2025

jnowakow commented Feb 19, 2025

mountiny commented Feb 19, 2025

jnowakow commented Feb 19, 2025

OSBotify commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

izarutskaya commented Feb 20, 2025

jnowakow commented Feb 20, 2025

izarutskaya commented Feb 20, 2025

jnowakow commented Feb 20, 2025

github-actions bot commented Feb 20, 2025

jnowakow commented Feb 18, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 18, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 18, 2025 •

edited

Loading