Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put report check for unknown report #5964

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #5897

Tests | QA Steps

  1. Log in with any account
  2. Navigate to a conversation
  3. In the URL, change the report number to something random

Tested On

  • Web (only platform allow url change)
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

output_file.mp4

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner October 20, 2021 18:35
@MelvinBot MelvinBot requested review from deetergp and removed request for a team October 20, 2021 18:35
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests well on web and mWeb. Thanks!

@deetergp
Copy link
Contributor

The iOS tests are failing even after a second re-run and I am not sure what the deal is.

@parasharrajat
Copy link
Member Author

It was Xcode. If I merge master it will pass. Let me do it.

@parasharrajat
Copy link
Member Author

Here you go.

@parasharrajat
Copy link
Member Author

@deetergp Ready for merge.

@deetergp deetergp merged commit 801473a into Expensify:main Oct 21, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @deetergp in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants