Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "unknown report check" due to regression - unable to create group chats #6615

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

Beamanator
Copy link
Contributor

@Beamanator Beamanator commented Dec 7, 2021

Reverting this PR: #5964

cc @parasharrajat

Fixes

$ #6609

Tests

  1. Create a new group chat with a unique group of participants (the group chat shouldn't have existed before)
  2. You should successfully be navigated to the group and be able to send messages with error warning appearing

QA Steps

Same as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Incoming...

Web

Screen.Recording.2021-12-07.at.1.17.29.PM.mov

Mobile Web

Screen.Recording.2021-12-07.at.1.23.34.PM.mov

Desktop

iOS

Screen.Recording.2021-12-07.at.1.28.10.PM.mov

Android

@Beamanator Beamanator requested a review from a team as a code owner December 7, 2021 11:15
@Beamanator Beamanator self-assigned this Dec 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from puneetlath and removed request for a team December 7, 2021 11:15
@Beamanator Beamanator changed the title Revert "unknown report check" due to regression Revert "unknown report check" due to regression - unable to create group chats Dec 7, 2021
@Beamanator Beamanator merged commit c343d5d into main Dec 7, 2021
@Beamanator Beamanator deleted the beaman-revertUnknownReportCheck branch December 7, 2021 12:03
github-actions bot pushed a commit that referenced this pull request Dec 7, 2021
Revert "unknown report check" due to regression - unable to create group chats

(cherry picked from commit c343d5d)
@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to staging by @Beamanator in version: 1.1.18-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants