Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Keyboard shortcuts modal #6112
Added Keyboard shortcuts modal #6112
Changes from 16 commits
baf320a
fdf81af
e00816c
28855fb
cb54938
a6c28bd
6bad775
290acb8
f31f5ed
2b6e319
32622ab
2e0d4c7
2096196
18fbadf
640687d
c18e2a4
ea2a41f
e1a8e96
e39b198
77c9381
111edbc
06e42c4
1018fb5
dbfa47e
048c729
666e499
eeb16d1
fa76933
99e7a4f
1f57f37
6943aa1
4c29fc0
7de6c54
e5b034d
3cbd1bf
fc03898
eb6ef1c
e2e456c
f09b027
2eeed69
06c77ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this same code in
AuthScreens.js
, and I think it would be valuable to extract some of this to a separate util.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked too. Couldn't find an simple way to move to utils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a simple function in
src/libs/KeyboardShortcut/index.js
like this to start:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer returning a map but an array of objects, so we should rename the function to
getKeyboardShortcuts