Config URL Cleanup #7662

mananjadhav · 2022-02-09T21:07:05Z

Details

Fixed Issues

$ #7489

Tests

Tested that .env file changes load the correct environment
Verified changes in the Readme
Tested App Download link
Google Api test done ~~CORS origin from localhost:8080~~
Plaid Test done ~~CORS origin from localhost:8080~~

Verify that no errors appear in the JS console

QA Steps

Check correct URL is picked

While PR changes configs and variables, one thing to check is that the App works as expected and all API requests are running to env specific APIs, ie, Staging connects to Staging URL, and so on

App Download

Got the settings by clicking on Avatar on LHN
Click on About -> App Download links menu
Click on macOS download link, and it should download the correct bundle

Plaid Link

Got the settings by clicking on Avatar on LHN
Click on Payments -> Add Payment menu
Click on "Bank Account" and ensure that Plaid flow is working fine

Verify that no errors appear in the JS console

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

mananjadhav · 2022-02-09T21:14:08Z

@rushatgabhane @iwiznia, three quick questions:

How to best test this with .env changes?
I've also renamed EXPENSIFY_URL_COM to EXPENSIFY_URL matching the variable expensifyUrl
The content variable CONST.NEWDOT I am using NEW_EXPENSIFY_URL, but note that when on staging it might show Staging URL. I am guessing it should be fine but let me know if you think otherwise.

iwiznia · 2022-02-09T21:24:30Z

How to best test this with .env changes?

I guess you can change the URLs there and test pointing to staging and prod?

The content variable CONST.NEWDOT I am using NEW_EXPENSIFY_URL, but note that when on staging it might show Staging URL. I am guessing it should be fine but let me know if you think otherwise.

I think that's perfect. Staging should point to staging and prod should point to prod.

…/change-url-vars # Conflicts: # src/CONST/index.js

mananjadhav · 2022-02-20T14:51:13Z

@iwiznia @rushatgabhane Will this go via QA? I am not sure what to add for screenshots for different variable changes and QA steps.

rushatgabhane

@mananjadhav looks good, just requesting a tiny change.

rushatgabhane · 2022-02-21T13:05:16Z

.env.production

@@ -1,6 +1,6 @@
-EXPENSIFY_URL_CASH=https://new.expensify.com/
+NEW_EXPENSIFY_URL=https://new.expensify.com/
 EXPENSIFY_URL_SECURE=https://secure.expensify.com/


Let's change it to SECURE_EXPENSIFY_URL everywhere?

rushatgabhane · 2022-02-21T14:10:58Z

Will this go via QA?

I don't know. We need to make sure all URLs are used correctly.

…/change-url-vars

rushatgabhane

I guess you can change the URLs there and test pointing to staging and prod?

This works as expected.

@iwiznia LGTM! 🎉️

rushatgabhane · 2022-02-24T02:59:46Z

Pending: Google Api test, CORS origin from localhost:8080
Pending: Plaid Test, CORS origin from localhost:8080

@mananjadhav This chrome extension gets the job done for me.

iwiznia

Looks good, but holding merge on:

The pending tests
Since this is renaming some widely used variables, you should merge main into this branch right before we merge, to reduce the possibility of some other PR having added usages of the old variables

…/change-url-vars

mananjadhav · 2022-02-27T08:42:55Z

Merged latest main. Checked the Plaid flow and Google API. I didn't complete the whole flow, just tested that it is working fine.

OSBotify · 2022-02-28T18:47:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-03-01T19:53:47Z

🚀 Deployed to staging by @iwiznia in version: 1.1.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

mvtglobally · 2022-03-01T20:56:21Z

@mananjadhav @rushatgabhane @iwiznia Anything QA team need to run here ?

OSBotify · 2022-03-02T10:47:05Z

🚀 Deployed to staging by @iwiznia in version: 1.1.41-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

francoisl · 2022-03-07T17:55:25Z

@mananjadhav @rushatgabhane @iwiznia Bump on the above please, looks like QA doesn't need to do anything other than check there are overall no errors in the console, can you confirm please?

mananjadhav · 2022-03-07T18:32:22Z

We could add maybe general app loading and URL checks, but as these are just code cleanup QA can look at console errors. Keen on hearing from @rushatgabhane and @iwiznia

rushatgabhane · 2022-03-07T19:54:53Z

I'm so sorry about this.
@mananjadhav yes, could you please add the QA steps related to app download, terms page and plaid link.

iwiznia · 2022-03-07T20:56:20Z

I assumed it was no QA because most of it would be caught in regression testing, but if there are specific things to QA here, please let's add them.

mananjadhav · 2022-03-08T03:38:11Z

Updated

marcaaron · 2022-03-08T17:50:17Z

Do we need an [Action Required] update or email for this?

rushatgabhane · 2022-03-08T18:02:07Z

Do we need an [Action Required] update or email for this?

Are you asking if we change the title of PR?

marcaaron · 2022-03-08T18:04:59Z

No, sorry to clarify... if we change the variable names for the environment variables that everyone who works on the codebase uses - then they might need to know about this change. They may have a bunch of pointless or undefined stuff in their local .env file because we changed the names of things.

rushatgabhane · 2022-03-08T19:26:17Z

@marcaaron oh yeah, good call. Here are the renames that need to be made in a .env

I've posted it on #expensify-open-source here
It'd best if you also post it internally for more eyes. Thanks!

EXPENSIFY_URL_CASH -> NEW_EXPENSIFY_URL

EXPENSIFY_URL_SECURE -> SECURE_EXPENSIFY_URL

EXPENSIFY_URL_COM -> EXPENSIFY_URL

OSBotify · 2022-03-11T00:03:39Z

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 6 commits February 10, 2022 02:05

config: Updated Config urls and references for new_expensify_url

33028d0

config: Renamed active url

a755d58

config: Removed NewDot and replaced with ACTIVE_EXPENSIFY_URL

6755e64

feat: Renamed urls active_expensify_url

912e4bb

config: Changed old expensify url

bbfbc2b

config: Changed ReadMe and .env files

b760e47

Merge branch 'main' of https://github.com/mananjadhav/App into config…

6d8acfc

…/change-url-vars # Conflicts: # src/CONST/index.js

mananjadhav marked this pull request as ready for review February 20, 2022 14:50

mananjadhav requested a review from a team as a code owner February 20, 2022 14:50

botify requested review from iwiznia and rushatgabhane February 20, 2022 14:50

MelvinBot removed the request for review from a team February 20, 2022 14:50

rushatgabhane suggested changes Feb 21, 2022

View reviewed changes

mananjadhav added 2 commits February 24, 2022 00:02

config: Updated secure url

543585a

config: Updated variable name

09fd0c8

mananjadhav requested a review from rushatgabhane February 23, 2022 20:45

Merge branch 'main' of https://github.com/mananjadhav/App into config…

ffabaa1

…/change-url-vars

rushatgabhane approved these changes Feb 24, 2022

View reviewed changes

iwiznia approved these changes Feb 24, 2022

View reviewed changes

Merge branch 'main' of https://github.com/mananjadhav/App into config…

5880cbf

…/change-url-vars

iwiznia merged commit 53581fe into Expensify:main Feb 28, 2022

OSBotify mentioned this pull request Mar 1, 2022

Deploy Checklist: New Expensify 2022-03-01 #7954

Closed

68 tasks

iwiznia mentioned this pull request Mar 3, 2022

[HOLD for payment 2022-06-01] [$2000] Request a call is redirecting to the link - reported by @adeel0202 #7909

Closed

botify mentioned this pull request Mar 10, 2022

[HOLD for payment 2022-03-17] Cleanup: URL Configs #7489

Closed

Stutikuls mentioned this pull request Mar 16, 2022

Implement infinite sessions #7

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Config URL Cleanup #7662

Config URL Cleanup #7662

mananjadhav commented Feb 9, 2022 •

edited

Loading

mananjadhav commented Feb 9, 2022

iwiznia commented Feb 9, 2022 •

edited

Loading

mananjadhav commented Feb 20, 2022 •

edited

Loading

rushatgabhane left a comment

rushatgabhane Feb 21, 2022

mananjadhav Feb 23, 2022

rushatgabhane commented Feb 21, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Feb 24, 2022 •

edited

Loading

iwiznia left a comment

mananjadhav commented Feb 27, 2022 •

edited

Loading

OSBotify commented Feb 28, 2022

OSBotify commented Mar 1, 2022

mvtglobally commented Mar 1, 2022

OSBotify commented Mar 2, 2022

francoisl commented Mar 7, 2022

mananjadhav commented Mar 7, 2022

rushatgabhane commented Mar 7, 2022

iwiznia commented Mar 7, 2022

mananjadhav commented Mar 8, 2022

marcaaron commented Mar 8, 2022

rushatgabhane commented Mar 8, 2022

marcaaron commented Mar 8, 2022 •

edited

Loading

rushatgabhane commented Mar 8, 2022 •

edited

Loading

OSBotify commented Mar 11, 2022

Config URL Cleanup #7662

Config URL Cleanup #7662

Conversation

mananjadhav commented Feb 9, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

mananjadhav commented Feb 9, 2022

iwiznia commented Feb 9, 2022 • edited Loading

mananjadhav commented Feb 20, 2022 • edited Loading

rushatgabhane left a comment

Choose a reason for hiding this comment

rushatgabhane Feb 21, 2022

Choose a reason for hiding this comment

mananjadhav Feb 23, 2022

Choose a reason for hiding this comment

rushatgabhane commented Feb 21, 2022 • edited Loading

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane commented Feb 24, 2022 • edited Loading

iwiznia left a comment

Choose a reason for hiding this comment

mananjadhav commented Feb 27, 2022 • edited Loading

OSBotify commented Feb 28, 2022

OSBotify commented Mar 1, 2022

mvtglobally commented Mar 1, 2022

OSBotify commented Mar 2, 2022

francoisl commented Mar 7, 2022

mananjadhav commented Mar 7, 2022

rushatgabhane commented Mar 7, 2022

iwiznia commented Mar 7, 2022

mananjadhav commented Mar 8, 2022

marcaaron commented Mar 8, 2022

rushatgabhane commented Mar 8, 2022

marcaaron commented Mar 8, 2022 • edited Loading

rushatgabhane commented Mar 8, 2022 • edited Loading

OSBotify commented Mar 11, 2022

mananjadhav commented Feb 9, 2022 •

edited

Loading

iwiznia commented Feb 9, 2022 •

edited

Loading

mananjadhav commented Feb 20, 2022 •

edited

Loading

rushatgabhane commented Feb 21, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Feb 24, 2022 •

edited

Loading

mananjadhav commented Feb 27, 2022 •

edited

Loading

marcaaron commented Mar 8, 2022 •

edited

Loading

rushatgabhane commented Mar 8, 2022 •

edited

Loading