Deploy Checklist: New Expensify 2022-03-01

[OSBotify]

Release Version: 1.1.41-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix: App changes positions of Ui elements when phone language RTL #7594

  • QA
  • Accessibility

• Config URL Cleanup #7662

  • QA
  • Accessibility

• Refactor AddressSearch to be compatible with Form #7701

  • QA
  • Accessibility

• Remove "Comment Deleted" message #7711

  • QA
  • Accessibility

• Reduce desktop app size #7744

  • QA
  • Accessibility

• Update label for Close account login field #7783

  • QA
  • Accessibility

• P2P KYC - Ask user to provide full SSN when LexisNexis cannot #7804

  • QA
  • Accessibility

• Cancel pending requests when signing out #7805

  • QA
  • Accessibility

• Enable haptic feedback on the NumberPad #7827

  • QA
  • Accessibility

• Fix/disable new room non workspace members #7829

  • QA
  • Accessibility

• remove emoji picker menu from tablets #7851

  • QA
  • Accessibility

• Deprecate requiresTwoFactorAuth property #7864

  • QA
  • Accessibility

• Upload image preview placeholder - Follow-up #7569 #7874

  • QA
  • Accessibility

• add informative text for visibility settings #7876

  • QA
  • Accessibility

• Change the message that shows when trying to name a room using a name that already exists #7878

  • QA
  • Accessibility

• Fix autofill for full name input row #7879

  • QA
  • Accessibility

• fix: prevent height from increasing after max limit #7891

  • QA
  • Accessibility

• removed Navigation.closeDrawer(); to fix 6908. #7892

  • QA
  • Accessibility

• Fix links in PR checklist #7898

  • QA
  • Accessibility

• fix first load #7922

  • QA
  • Accessibility

• Do not reauthenticate Pusher if we failed for any reason other than expired session #7924

  • QA
  • Accessibility

• Fix desktop npm install in postinstall script #7927

  • QA
  • Accessibility

• Revert "feat: add image loading placeholder" #7933

  • QA
  • Accessibility

• Revert "Make push notifications navigate to the correct chat - iOS" #7939

  • QA
  • Accessibility

• Fix storybook build #7955

  • QA
  • Accessibility

• Add the zip target to fix Desktop auto updates #7989

  • QA
  • Accessibility

• [CP Stg] Add title and artifactName back in ElectronBuilder config #7996

  • QA
  • Accessibility

• [No QA][CP Stg] Export ELECTRON_ENV to electronBuilder.config.js #8000

  • QA
  • Accessibility

• Fix reportDetails icons for chatrooms #8011

  • QA
  • Accessibility

• Revert PR 8013, which introduced a bug #8054

  • QA
  • Accessibility

Internal QA:

• [P2P Statements] Add Loading Indicator #7921 - @Gonals @nickmurray47
• Don't set default badge when only one defaultable payment method is available #7767 - @marcochavezf @marcaaron

Deploy Blockers:

• Sign in - 2FA input box does not appear until entering a password and tap "Sign in" for the 2FA user #7961
• Web - Profile - Autofill prompt does not appear for names fields #7982
• Desktop build is not updated  #7987
• Desktop app size is 161 Mb instead 90 Mb #8014
• Desktop - App is stuck with blank screen when logout from expensifail and login with gmail account #8015
• Room - App crashed after tap on room name and unable log in app again after that. #8040

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.41-0 🚀

[roryabraham]

Web deploy failed, hopeful fix here

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.41-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-1 has been deployed to staging 🎉

[mvtglobally]

@roryabraham if we are 1.1.40-0 on other platforms, can we start QA tests?

[roryabraham]

@mvtglobally no we should be at least 1.1.41-0 on all platforms ... but 1.1.41-1 should be available now?

[mvtglobally]

Sorry typo , I meant to say 1.1.41-0. We don't need to wait for -1, right?

Web is available 1.1.41-1, Desktop and IOS not yet

[roryabraham]

Correct, 1.1.41-0 is a high enough version because the diff between 41-0 and 41-1 is just related to building our (storybook) documentation site, not the actual application.

[marcaaron]

Checking off #7767 after testing on staging

[mvtglobally]

@roryabraham Desktop staging app is still 1.1.40-2

[roryabraham]

Checked off #7933 and #7939 because they were deployed with the last checklist. I think it's a bug that they showed up here, but I don't have time to look into it right now unfortunately.

@roryabraham Desktop staging app is still 1.1.40-2

Oh, @mvtglobally, that's not good. This is potentially because of #7744 cc @kidroca. It might also just be because of #7765, which increase the interval at which NewDot check for updates from 1 hour to 8 hours.

[kidroca]

What happens after Desktop is built?
@roryabraham can the changed folder cause an issue? - the Desktop app output is no longer in dist but in desktop-build
Otherwise we're now build for 3 target x86, arm64 and universal apps, could that be a problem? We used to build only x86 before

I've examined the build script and was left under the impressions that publishing is handled by electron-builder as part of the build process - if it fails there would be a bang (I suppose)

Can you manually download or force update Desktop?

Should be there:

• x64: uploading file=New Expensify-1.1.41-1.dmg provider=S3
• arm64: uploading file=New Expensify-1.1.41-1-arm64.dmg provider=S3
• universal: uploading file=New Expensify-1.1.41-1-universal.dmg provider=S3

Could it be the lack of this zip?
uploading file=New Expensify-1.1.40-2-mac.zip provider=S3

(If we enable it, it would make a zip for each platform and take more space...)

[mvtglobally]

@roryabraham do you need a bug for this build issue?

[roryabraham]

@roryabraham do you need a bug for this build issue?

Yes please

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.41-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-2 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.41-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-3 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.41-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-4 has been deployed to staging 🎉

[roryabraham]

#7987 is resolved and desktop staging builds/auto-update should be working again.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.41-5 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-5 has been deployed to staging 🎉

[mvtglobally]

Comments left.
#7662 (comment)
#7594 (comment)
#7922 (comment)

PR #7744 is failing due to #8014
PR #7805 is failing due to #8015
PR #7891 is failing due to #7980

Checking off #7879 as #7982 was closed
Checking off #7996 & #7989 verified it is autoupdated and fixed

[francoisl]

Hi @mvtglobally, for the last two comments you left (#7594 (comment) and #7922 (comment)), someone left a suggestion here explaining how to test.

[francoisl]

Adding #8014 as a deploy blocker pending more investigation, because the desktop app seems to be broken/uninstallable.

[francoisl]

• Crossing internal QA checkbox for Don't set default badge when only one defaultable payment method is available #7767 (comment) because it was already tested.
• Bumped [P2P Statements] Add Loading Indicator #7921.

[mvtglobally]

Checking off #7594 and #7922

[mvtglobally]

@francoisl the following items are pending to close this checklist.

We are re-checking #7662 based on new test steps
Can we check off PR #7744 as #8014 no longer marked a blocker?
PR #7805 is failing due to #8015
Checking off PR #7891 as #7980 is not a blocker
We tested new PR #8011. It is failing due to #8040. This was working before.something reverted old fix.

[francoisl]

Noted, thanks. Looking into the remaining open issues now.

Can we check off PR #7744 as #8014 no longer marked a blocker?

Yes, let's check it off.

[francoisl]

• Desktop - App is stuck with blank screen when logout from expensifail and login with gmail account #8015: I think that this is not a regression and that it's due to the accounts being used having a lot of IOU reports. I left a comment in the issue, it would be great if you could test the same flow on production with the account rybkina@gmail.com, to see if you get the same blank page.
• Room - App crashed after tap on room name and unable log in app again after that. #8040: Also left a comment, it looks like QA was done on version 1.1.41-4 instead of 1.1.41-5? I can't reproduce the error, let's try that one again to confirm please.

And I think these are the last 2 remaining items once #7662 is checked again!

[mvtglobally]

Checking off #7662

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.41-6 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.41-6 has been deployed to staging 🎉

[TomatoToaster]

#8040 should be fixed now so I think the deploy is no longer blocked.

One issue is that the icons will be small for room details:

This will be fixed immediately on the next staging deploy when this PR is deployed to staging:
#7852
after which this will be merged making the icons bigger again
#8058

so the small icons should not block the deploy.

[francoisl]

• Checking internal QA [P2P Statements] Add Loading Indicator #7921, it will need to be tested in production instead

---

@mvtglobally can you please:

• Retest Fix reportDetails icons for chatrooms #8011 - it should be fixed now
• Test Cancel pending requests when signing out #7805, but on production and with account rybkina@gmail.com, to see if we get the same result (more details here)

[mvtglobally]

@francoisl

checking off #8011 its a pass
#7805 is not repro in PROD.

[isagoico]

@roryabraham @francoisl - Looks like the only thing missing from the checklist is this Deploy Blocker #8015 (issue is not reproducible in prod, confirmed above) any chance that can be looked at and probably get a deploy today? 🥺

[francoisl]

Still trying to consistently reproduce the issue. To clarify, are you only getting the blank screen when you sign in the account rybkina@gmail.com? And is that a personal account, or a test account you would be willing to share (i.e. add it to 1Password?)

I tested with different accounts, and the app takes at most 10 to 12 seconds to start rendering chat data in large accounts, both with the staging and production app. The only difference I see with the account rybkina@gmail.com is that it has a lot of IOUs. I asked around if we have test accounts with a lot of IOUs, but if you'd be willing to share the credentials for rybkina@gmail.com in the meantime, that would be helpful.

[francoisl]

Thanks, I ran some tests and can't see a lot of differences so I'm curious for second opinions from anyone else here. Let's keep the discussion in the GH issue though.

---

Once we're all done testing, can you please rotate the password of that account @mvtglobally? I know it's just a test account, but this is a public repo, so let's make sure the account won't be used for spam or shady stuff (I'm also deleting the previous comment as an extra precaution).

[francoisl]

Removed the deploy blocker label from #8015 since we're also seeing the same behavior with the production app. We'll keep the issue open so it can be looked further into though, given that it's pretty bad that the desktop app takes so long to load.

This was the last checkbox so we can go ahead with the deploy!

[francoisl]

[Stutikuls]

Checked all PRs and added comments to all PRs where accessibility issues were found without the Android platform (due to build issues on Android) only one issue is left and have query on #7864
The non-applicable PRs are - #7594, #7662, #7701, #7744, #7805, #7827
Impossibility to verify (After client confirmation) - #7804

[SumitDiyora]

Checked all PRs and added comments to all PRs where accessibility issues were found.
The non-applicable PRs are - #7892, #7898, #7922, #7924, #7927, #7939, #7955, #7989, #7996, #8000