Desktop build is not updated

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. keep previous build app open in docket
2. wait for next build update notification

Expected Result:

1.1.41-0 build should be either autoupdated or user should get notification

Actual Result:

Build is not updated. Desktop staging app is still 1.1.40-2

Context
This is potentially because of #7744. It might also just be because of #7765, which increase the interval at which NewDot check for updates from 1 hour to 8 hours.
The Desktop app output is no longer in dist but in desktop-build
Otherwise we're now build for 3 target x86, arm64 and universal apps, could that be a problem? We used to build only x86 before.
More info here #7954 (comment)

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.40-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[flodnv]

@kidroca can you take this given you've already done part of the investigation?

[kidroca]

Ok, can we start with someone answering my questions here : #7954 (comment)

• What happens after Desktop is built?
• Is there a way to manually download Desktop?
• Could it be the lack of this zip?

Is the guide here meant for external contributors?
https://github.com/Expensify/App/blob/main/desktop/README.md#testing-electron-auto-update

I'll investigate and report back

[flodnv]

@neil-marcellini @roryabraham can you help out @kidroca here?

Is there a way to manually download Desktop?

Yes, here: https://new.expensify.com/NewExpensify.dmg and here https://staging.new.expensify.com/NewExpensify.dmg AFAIK

[kidroca]

Is there a way to manually download Desktop?

Yes, here: https://new.expensify.com/NewExpensify.dmg and here https://staging.new.expensify.com/NewExpensify.dmg AFAIK

What is making it available there though? Right now I downloaded v1.1.40-2 from that link while v1.1.41-0 seems to be the latest version

What would put a new version at that route?
A .dmg search review only 3 results in the repo: https://github.com/Expensify/App/search?q=.dmg&type=code

[kidroca]

Oh wow, it seems to be caused by removing the zip file indeed: electron-userland/electron-builder#2199 (comment)

[kidroca]

Submitted a PR that should fix auto-updates: #7989

I'm not sure whether it would fix the .dmg being hosted here: https://new.expensify.com/NewExpensify.dmg

[roryabraham]

Self-assigning and trying to get a fix ASAP.

[roryabraham]

Looking at the deploy logs from #7989, I'm seeing some suspicious log lines:

uploading       file=New Expensify-1.1.41-2.dmg
...
uploading       file=New Expensify-1.1.41-2-arm64.dmg provider=S3
...
uploading       file=New Expensify-1.1.41-2-universal.dmg provider=S3

Going to investigate whether the package version being tacked onto the file is our problem. Also @kidroca I don't recall why we added target architectures in electronBuilder.config.js 🤔

[roryabraham]

Older successful deploys had this:

uploading       file=NewExpensify.dmg provider=S3

Noticing that there was:

1. no version in the filename
2. No space between New and Expensify.

[roryabraham]

I'm hopeful that I've figured this out ... just testing with local builds which takes a lil while

[kidroca]

Also @kidroca I don't recall why we added target architectures in electronBuilder.config.js 🤔

So that we can support new M1 macs without them running App through Rosetta
Though if arm64 or the universal app are not exposed for downloading it's probably no good

[roryabraham]

Though if arm64 or the universal app are not exposed for downloading it's probably no good

I was wondering if a single .dmg could/would be "smart enough" to detect the architecture and install the correct app 🤔

[kidroca]

I was wondering if a single .dmg could/would be "smart enough" to detect the architecture and install the correct app

Only if we make a custom one - the ones from electron-builder are .dmg per arch
The universal works for bot but it's twice the size (installer and installed), though it's still 2x smaller than what we had before

We decided to not to make custom installer but make downloading download the correct .dmg for the user #6927 (comment)

[roryabraham]

Unfortunately I don't think this is resolved yet. #7996 changed these suspicious logs: https://github.com/Expensify/App/runs/5416585778?check_suite_focus=true

But I downloaded the staging desktop app and it's still on version 1.1.40-2

[kidroca]

Interesting how @mallenexpensify updated to v1.1.41-2 here: #7579 (comment)?

[roryabraham]

Le whoops ... staging builds are deploying the app straight to the production bucket 😬

[roryabraham]

I downloaded the app from https://new.expensify.com/NewExpensify.dmg and it was 1.1.41-3 😬

[roryabraham]

Fortunately this is only affecting desktop and not web

[kidroca]

Sorry, seems this has to have export so that it works in the config as well

App/scripts/build-desktop.sh

Line 4 in 40431f6

ELECTRON_ENV=${1:-development}

export ELECTRON_ENV=${1:-development}

we use it for the isStaging check

[roryabraham]

Yep, that's probably it. I'll work on a PR

[kidroca]

Hey BTW these work as well

• https://new.expensify.com/New%20Expensify-1.1.41-1.dmg
• https://new.expensify.com/New%20Expensify-1.1.41-1-arm64.dmg
• https://new.expensify.com/New%20Expensify-1.1.41-1-universal.dmg

We can use something like

artifactName: 'NewExpensify-{arch}.dmg',

to have platform specific .dmgs

[roryabraham]

artifactName: 'NewExpensify-{arch}.dmg',

That seems like a good idea. I'm going to create a follow-up issue to address the multiple architectures.

[kidroca]

https://www.electron.build/file-patterns#file-macros

You can use macros in the file patterns, artifact file name patterns and publish configuration url:

${arch} — expanded to ia32, x64. If no arch, macro will be removed from your pattern with leading space, - and _ (so, you don’t need to worry and can reuse pattern).

[roryabraham]

Confirmed this is fixed and desktop staging builds an un-broken.