Check for app updates every 8 hours

[neil-marcellini]

Details

Rather than checking for app updates once per hour after the initial check, check once every 8 hours.

Fixed Issues

$ #7643

Tests

1. Comment out this line so that you get update notifications on your dev environment
2. npm run desktop
3. Sign in to the local desktop app
4. Sign in to the production desktop app
5. Keep both apps open for 8 hours.
6. When update notifications pop up for the desktop app hourly, make sure they they don't pop up for the local app.

• Verify that no errors appear in the JS console

QA Steps

1. Sign in to the desktop staging app
2. Sign in to the production desktop app
3. Keep both apps open for 8 hours.
4. When update notifications pop up for the desktop app hourly, make sure they they don't pop up for the staging version.

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[neil-marcellini]

I haven't actually tested this yet, but I'm pretty sure it will work since it's a simple change. Tomorrow I will test this and add screenshots to be proper.

[mountiny]

I am not sure how much value testing this change thoroughly would bring. The logic is pretty simple here. LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @neil-marcellini in version: 1.1.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[flodnv]

Hmmm. The proposal was about reducing the notifications, not the checking itself.

[mountiny]

Oh, that is a good point, I have overlooked that during a review @neil-marcellini

[neil-marcellini]

@flodnv
What would be the benefit to checking more often, but notifying only every 8 hours?

[flodnv]

To clarify, does the app check on startup?

[neil-marcellini]

Yes it checks on startup. When init is called on the electron updater it checks for updates here. The behavior is similar for web.

[flodnv]

I think it's probably fine although it feels a bit weird to knowingly introduce an "improvement" that means that most of our user base will be on an older version for several hours at a time. Perhaps it's ok though.