-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS auto-update without extra zip file #2199
Comments
Will it matter if I have installed my app via pkg? |
You can ask us to support pkg but... #1728 (comment) Depends on user demand / donation. |
To make clear — when this feature will be implemented, it will be very easy to support virtually any format, including pkg. Not because our position about DMG is changed, but because of backward compatibility (need to support both zip and DMG, so, old clients will be able to update). |
@develar i think this feature has broken
The ArchiveTarget is called with isWriteUpdateInfo to false, so my latest.yml is not generated anymore
|
@farfromrefug By intention. If you need auto-update on macOS, you build both dmg and zip. Why do you build only zip and not dmg? |
Because i dont need dmg :D What's hard is that you broke support for it while it was there. Now i am not against switching to dmg! But does it mean i can only use dmg ,and update files will still be built ? If so, do the distrib updater my clients have within their app already know how to install dmg updates? Thanks |
I was not aware about such use case. Fix will be today evening CET (better if you will duplicate your comment as a new issue). |
@develar no problem, thanks for fixing this |
What is the current status of this issue? |
Hi @develar |
Adding the following to my electron builder config allowed me to proceed:
|
Feature is not implemented yet. |
Same as @ilyaLibin. Any update on this? |
Bumping this issue, I see no reason to have both |
Friendly ping from my side :) |
Until this issue is fixed electron-userland/electron-builder#2199, a zip file is requied for auto update.
Any news? |
Any update? 2017 feels like a while ago now! |
1 similar comment
Any update? 2017 feels like a while ago now! |
@develar I'd like to see this feature and am happy to work on a PR towards this goal. Seemed like you were actively working on it a few years ago, is there somewhere we can start? Or is the reason it was never implemented because it is a difficult problem to solve? I haven't actually tried using it, but this project claims to do differential updates on mac. https://github.com/imjsElectron/electron-differential-updater |
I'm running into this issue as well. For now, I'm building both dmg and zip so that auto-update works even if the app was installed using dmg. Would be nice if we didn't have to build zip file. |
@acnebs I'm happy to review any PR. |
For fully automatic macOS updates, electron-updater requires: 1. Distributing macOS file as .zip (electron-userland/electron-builder#2199) 2. Code signing for the application privacy.sexy as of today lacks both the distribution and code signing. This commit introduces auto-updates through automatically checking for updates, downloading them but requiring user to drag application icons to Applications by opening dmg file. This commit also fixes: 1. Progress state in update progress bar not being shown. 2. Downloading updates were being triggered even though it was not desired as downloads are being handled using different based on OS and user choice. In the end it refactors the code for handling updates of two different kinds, and making message dialog use enums for results instead of response integers as well as setting default and cancel button behavior. Refactorings make behaviors more explicit and extends the control.
This is extremely frustrating to realize that disabling |
This is the bare minimum to save people from breaking auto update on macos, as noted in electron-userland#2199 (comment)
This is the bare minimum to save people from breaking auto update on macos, as noted in #2199 (comment)
Although our users install Cozy Desktop via the `dmg` target on macOS, the `zip` target is still required for the updater to work. Indeed, if the generated zip file isn't published, the updater will fail as it is looking for its presence. The issue has been reported a long time ago in electron-userland/electron-builder#2199 but there is no recent work on any potential solution.
Although our users install Cozy Desktop via the `dmg` target on macOS, the `zip` target is still required for the updater to work. Indeed, if the generated zip file isn't published, the updater will fail as it is looking for its presence. The issue has been reported a long time ago in electron-userland/electron-builder#2199 but there is no recent work on any potential solution.
Although our users install Cozy Desktop via the `dmg` target on macOS, the `zip` target is still required for the updater to work. Indeed, if the generated zip file isn't published, the updater will fail as it is looking for its presence. The issue has been reported a long time ago in electron-userland/electron-builder#2199 but there is no recent work on any potential solution.
Although our users install Cozy Desktop via the `dmg` target on macOS, the `zip` target is still required for the updater to work. Indeed, if the generated zip file isn't published, the updater will fail as it is looking for its presence. The issue has been reported a long time ago in electron-userland/electron-builder#2199 but there is no recent work on any potential solution.
Although our users install Cozy Desktop via the `dmg` target on macOS, the `zip` target is still required for the updater to work. Indeed, if the generated zip file isn't published, the updater will fail as it is looking for its presence. The issue has been reported a long time ago in electron-userland/electron-builder#2199 but there is no recent work on any potential solution.
Although our users install Cozy Desktop via the `dmg` target on macOS, the `zip` target is still required for the updater to work. Indeed, if the generated zip file isn't published, the updater will fail as it is looking for its presence. The issue has been reported a long time ago in electron-userland/electron-builder#2199 but there is no recent work on any potential solution.
For fully automatic macOS updates, electron-updater requires: 1. Distributing macOS file as .zip (electron-userland/electron-builder#2199) 2. Code signing for the application privacy.sexy as of today lacks both the distribution and code signing. This commit introduces auto-updates through automatically checking for updates, downloading them but requiring user to drag application icons to Applications by opening dmg file. This commit also fixes: 1. Progress state in update progress bar not being shown. 2. Downloading updates were being triggered even though it was not desired as downloads are being handled using different based on OS and user choice. In the end it refactors the code for handling updates of two different kinds, and making message dialog use enums for results instead of response integers as well as setting default and cancel button behavior. Refactorings make behaviors more explicit and extends the control.
There is no any reason to require ZIP file. DMG should be enough.
Stay tuned — delta updates using DMG files are coming next week :)
The text was updated successfully, but these errors were encountered: