-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][CP Stg] Export ELECTRON_ENV to electronBuilder.config.js #8000
Conversation
|
Shouldn't we do something about this: There's no point building for 3 platforms if they overwrite themselves |
I think you're right. Fortunately it's the |
(cherry picked from commit 3998980)
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.41-4 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
Details
npm run desktop-build-staging -- --publish always
(as executed here) is deploying the desktop app to production 😬More context here
Fixed Issues
$ #7987
Tests
No way to test locally. Merge this PR and the desktop app should deploy to the staging S3 bucket.
QA Steps
None.