removed Navigation.closeDrawer(); to fix 6908.

[hiteshagja]

@mountiny @parasharrajat

Details

Removed Navigation.closeDrawser(); from navigateToConciergeChat() method to properly navigate to Concierge report.

Fixed Issues

$ #6908

Tests

1. Login app
2. Goto any report but not Concierge
3. Goto Settings => About => click/tap on "Report a bug"

• Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

• I made sure to pull main before submitting my PR for review
• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I clearly indicated the environment tests should be run in (Staging vs Production)
• I wrote testing steps that cover success & fail scenarios (if applicable)
• I ran the tests & they passed on all platforms
• I included screenshots or videos for tests on all platforms
• I verified there are no console errors related to changes in this PR
• I followed proper code patterns (see Reviewing the code)
  • I added comments when the code was not self explanatory
  • I put all copy / text shown in the product in all src/languages/* files (if applicable)
  • I followed proper naming convention for platform-specific files (if applicable)
  • I followed style guidelines (in Styling.md) for all style edits I made
• I followed the guidelines as stated in the Review Guidelines

PR Reviewer Checklist

• I verified the Author pulled main before submitting the PR
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the testing environment is mentioned in the test steps
• I verified testing steps cover success & fail scenarios (if applicable)
• I verified tests pass on all platforms & I tested again on all platforms
• I checked that screenshots or videos are included for tests on all platforms
• I verified there are no console errors related to changes in this PR
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified comments were added when the code was not self explanatory
  • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
  • I verified proper naming convention for platform-specific files was followed (if applicable)
  • I verified style guidelines were followed
• I verified that this PR follows the guidelines as stated in the Review Guidelines

QA Steps

Check all the steps in all the platforms

Scenario 1

1. Login app
2. Goto any report but not Concierge
3. Goto Settings => About => click/tap on "Report a bug"

Scenario 2

1. Login app
2. Goto any report but not Concierge
3. Write some text in message input box and send message
4. Goto another report
5. Goto Settings => About => click/tap on "Report a bug"

Scenario 3

1. Login app
2. Goto any report but not Concierge
3. Goto Settings => About => click/tap on "Report a bug"
4. Search any report and choose one

• Verify that no errors appear in the JS console

Tested On

• Web
• Desktop
• iOS
• Android

Web

exp_web.mp4

Desktop

exp_desktop.mp4

iOS

exp_ios.mp4

Android

exp_android.mp4

[parasharrajat]

Please fix issue link .

1. Mention to check this on all platforms in QA steps.

[mountiny]

Please, make sure you always link the issues like: $ https://github.com/Expensify/App/issues/6908. I have fixed it for you, for now, it is needed for our integration pipeline. Thank you very much for keeping an eye on this for the future!

[mountiny]

Oh, @parasharrajat missed that 😅

[hiteshagja]

Please, make sure you always link the issues like: $ https://github.com/Expensify/App/issues/6908. I have fixed it for you, for now, it is needed for our integration pipeline. Thank you very much for keeping an eye on this for the future!

it's my bad.

Thank you !!

[hiteshagja]

Please fix issue link .

1. Mention to check this on all platforms in QA steps.

@parasharrajat mentioned.

Thanks

[parasharrajat]

🙄

[mountiny]

I fixed it @thesahindia 😅 look at the history of the body and use the version I put in.

[thesahindia]

I fixed it @thesahindia 😅 look at the history of the body and use the version I put in.

Oops I guess it was for @hiteshagja

[mountiny]

@thesahindia ooops sorry about this! Yes, @hiteshagja was supposed to be tagged :)

[parasharrajat]

I still see that

@mountiny Could you please do that and we can merge the PR? Changes are good.

[parasharrajat]

LGTM... only the PR description needs to be fixed

cc: @mountiny

🎀 👀 🎀 C+ reviewed

[mountiny]

Thank you @parasharrajat.

@hiteshagja remember the linking format for future, thank you:)

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @mountiny in version: 1.1.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

[OSBotify]

🚀 Deployed to staging by @mountiny in version: 1.1.41-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

[OSBotify]

🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅