-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix first load #7922
fix first load #7922
Conversation
What's the context for this PR? Was there a regression somewhere? |
I find the edge case here when you install the app for the first time app does not read the RTL config from js until you reload it. and will work after that very fine. the js config we add before. work fine with us because the app was installed. just add this native config line that fix this case. i know this issue takes a while but we should solve this. |
Got it thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting a PR @ahmdshrif Appreciate it.
android/app/src/main/java/com/expensify/chat/MainApplication.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.1.41-0 🚀
|
🚀 Deployed to staging by @marcaaron in version: 1.1.41-0 🚀
|
Team is having a bit hard time validating this PR on Desktop/Web as it requires device language change and introducing navigation issues to flip language back as options shift. |
HI, @mvtglobally I will suggest here to change the language for the app and browser only from setting here. |
Hi @mvtglobally, were you able to test with the suggestion just above? |
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
Details
Fixed Issues
$ #7476
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
55b-d8534034caed.png)
Screen.Recording.2022-02-13.at.3.42.50.PM.mov
Android