show ToS error in connect manual bank account page #7978
Conversation
MelvinBot
requested review from
luacmartins and
parasharrajat
and removed request for
a team
| @@ -68,6 +68,7 @@ class BankAccountStep extends React.Component { | |||
| this.errorTranslationKeys = { | |||
| routingNumber: 'bankAccount.error.routingNumber', | |||
| accountNumber: 'bankAccount.error.accountNumber', | |||
| hasAcceptedTerms: 'addDebitCardPage.error.acceptedTerms', | |||
There was a problem hiding this comment.
Let's move the translations to common place from addDebitCardPage.error.acceptedTerms errors.acceptedTerms. And refactor other places where this error is used.
There was a problem hiding this comment.
@parasharrajat, do you want me to create a new errors object at the main level or shall I put acceptedTerms in common.error that is already there?
There was a problem hiding this comment.
yeah, let's put it in common.error then
There was a problem hiding this comment.
Thanks for the changes so far @adeel0202! Let's also include these in the refactor
|
@luacmartins, I had made the changes @parasharrajat asked for. |
There was a problem hiding this comment.
LGTM.
cc: @luacmartins
PR Reviewer Checklist
- I verified the Author pulled
mainbefore submitting the PR - I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the testing environment is mentioned in the test steps
- I verified testing steps cover success & fail scenarios (if applicable)
- I verified tests pass on all platforms & I tested again on all platforms
- I checked that screenshots or videos are included for tests on all platforms
- I verified there are no console errors related to changes in this PR
- I verified proper code patterns were followed (see Reviewing the code)
- I verified comments were added when the code was not self explanatory
- I verified any copy / text shown in the product was added in all
src/languages/*files (if applicable) - I verified proper naming convention for platform-specific files was followed (if applicable)
- I verified style guidelines were followed
- I verified that this PR follows the guidelines as stated in the Review Guidelines
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @luacmartins in version: 1.1.42-0 🚀
|
|
🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀
|
Details
Show the error when the user doesn't accept Terms of Service on Connect bank account manually page
Fixed Issues
$ #7839
Tests
PR Review Checklist
Contributor (PR Author) Checklist
mainbefore submitting my PR for review### Fixed Issuessection abovesrc/languages/*files (if applicable)Styling.md) for all style edits I madePR Reviewer Checklist
mainbefore submitting the PR### Fixed Issuessection abovesrc/languages/*files (if applicable)QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android