Fix accessing window and navigator global objects, fix Url import #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazejkustra
changed the title
blazejkustra
changed the title
blazejkustra
commented
May 28, 2024
| @@ -483,10 +483,10 @@ export default class ExpensiMark { | |||
| Log.alert('[ExpensiMark] Missing account name', {accountID: g1}); | |||
| return '@Hidden'; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
There was a prettier diff on main
|
Not sure who's going to review and merge this one as @roryabraham has context on it, but @thienlnam was assigned. Either way the PR is ready, thank you! |
roryabraham
approved these changes
May 28, 2024
|
🚀Published to npm in v2.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to the setup of TS in this repo. While testing in the E/App here I noticed two issues:
Urlexport is wrong (I tested it before but missed that Url was undefined 🤦)index.tscauses other exported files to run (for exampleBrowserDetect.jsx). This causes problems because code inexpensify-commonassumes thatwindowandnavigatorglobal objects exist, which isn't always true.Fixed Issues
$ Expensify/App#42245